Re: [gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

['Goktug Gokdogan' via GWT Contributors]

tbroyer: Are you using batch mode while testing? We are using -batch module
internally and maybe you guys do not externally? (though you linked the
code that only runs in batch mode, IIRC).

On Tue, Oct 10, 2017 at 1:04 PM, Thomas Broyer  wrote:

> I'll try with the manual runstyle, i.e. with a real browser, and see how
> it goes. Thanks for the feedback.
>
> --
> You received this message because you are subscribed to the Google Groups
> "GWT Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/google-web-toolkit-contributors/1fab1f52-557b-
> 4857-a0a9-f017c1d4822d%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA0whHNkZU%3D9kPzsYRnZhp_F__anb4fPacvUTrOnmz6PkQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: [gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

[Thomas Broyer]

I'll try with the manual runstyle, i.e. with a real browser, and see how it 
goes. Thanks for the feedback.

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/1fab1f52-557b-4857-a0a9-f017c1d4822d%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

['Daniel Kurka' via GWT Contributors]

I am not aware of anything specific we have done within Google, we never
imported the jetty upgrade. I think you just go ahead for open source and
make it work there. We do not care that much for htmlunit anymore within
Google.

On Tue, Oct 10, 2017 at 10:28 AM Thomas Broyer  wrote:

>
>
> On Tuesday, October 10, 2017 at 6:08:05 PM UTC+2, Colin Alworth wrote:
>>
>> Patch is accepted and merged into upstream HtmlUnit, see
>> https://sourceforge.net/p/htmlunit/bugs/1924/ for more detail.
>>
>> Daniel, when you can take a look at Thomas's question, we can get this
>> change made to open source GWT as you requested.
>>
>
> Here's the workaround for HtmlUnit
> https://gwt-review.googlesource.com/c/gwt/+/19680
> The only problem left is
> https://github.com/gwtproject/gwt/blob/a3df04c0f5469bdcf49bdd564467255951ef6559/user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java#L209-L215
> which doesn't play nicely with
> https://github.com/gwtproject/gwt/blob/a3df04c0f5469bdcf49bdd564467255951ef6559/user/src/com/google/gwt/core/client/impl/Impl.java#L273-L277
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "GWT Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/google-web-toolkit-contributors/245093f8-c1c1-4e71-9291-0b9e3af66eb9%40googlegroups.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/CALLujiohp1oqMvBYUFJPfx44pawqmpgC2G9CRwZUrz3mcmswfQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.

Re: [gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

[Thomas Broyer]

On Tuesday, October 10, 2017 at 6:08:05 PM UTC+2, Colin Alworth wrote:
>
> Patch is accepted and merged into upstream HtmlUnit, see 
> https://sourceforge.net/p/htmlunit/bugs/1924/ for more detail. 
>
> Daniel, when you can take a look at Thomas's question, we can get this 
> change made to open source GWT as you requested.
>

Here's the workaround for 
HtmlUnit https://gwt-review.googlesource.com/c/gwt/+/19680
The only problem left 
is 
https://github.com/gwtproject/gwt/blob/a3df04c0f5469bdcf49bdd564467255951ef6559/user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java#L209-L215
 
which doesn't play nicely 
with 
https://github.com/gwtproject/gwt/blob/a3df04c0f5469bdcf49bdd564467255951ef6559/user/src/com/google/gwt/core/client/impl/Impl.java#L273-L277
 

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/245093f8-c1c1-4e71-9291-0b9e3af66eb9%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

[Colin Alworth]

Patch is accepted and merged into upstream HtmlUnit, see
https://sourceforge.net/p/htmlunit/bugs/1924/ for more detail.
Daniel, when you can take a look at Thomas's question, we can get this
change made to open source GWT as you requested.

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/1507651680.2148273.1134128816.6B394BE1%40webmail.messagingengine.com.
For more options, visit https://groups.google.com/d/optout.