Re: [gwt-contrib] Preliminary testing for GWT 2.10 release
I could revert the deprecations (though they were specifically added at your request ;) ). That said, those changed when the old IE versions were removed, and I didn't see the showcase start to emit those errors then. Even with the JDT upgrade, I still don't see them for the showcase: https://github.com/niloc132/gwt/runs/6124099314?check_suite_focus=true#step:5:3295 The error also does not appear to happen when running from ant, at least not in the showcase sample. At a glance I can't see anything explicitly disabling deprecation warnings in that code. The warning is coming from JsniReferenceResolver. The linked log above is emitting warnings, but clearly not one for the code you see, even though the showcase references those types. Showcase's CwRichText explicitly uses the RichText widget. However, both maven and gradle projects do correctly include the warnings, if you happen to include those gwt modules in your project. That does make the iteration time a bit longer to test, but it appears we can suppress the warnings on a per-usage basis. I'll propose a patch (and upload a new build to test) as soon as I'm able. On Friday, April 22, 2022 at 9:12:58 AM UTC-5 Thomas Broyer wrote: > I tried changing only the version (from com.google.gwt:gwt:2.8.2 to > com.google.gwt:2.10.0-new-groupid-2). > Looking at a dependency graph (./gradlew dependencies), I can see the > com.google.gwt dependencies properly "relocated" to their org.gwtproject > equivalent > Java compilation passes without warning or error, same for JVM tests (I > don't have much that use GWT though), and even GWT tests! (I only have a > couple of them though) > GWT compilation emits a few unexpected warnings though: >[WARN] Warnings in > 'jar:file:/home/redacted/.gradle/caches/modules-2/files-2.1/org.gwtproject/gwt-user/2.10.0-new-groupid-2/10fcf6c7213db2fc2c71a7731c582b6d8f9a4739/gwt-user-2.10.0-new-groupid-2.jar!/com/google/gwt/user/client/impl/DOMImplMozilla.java' > [WARN] Line 30: Referencing deprecated class > 'com.google.gwt.user.client.impl.DOMImplStandard' > [WARN] Line 30: Referencing deprecated class > 'com.google.gwt.user.client.impl.DOMImplStandard' > [WARN] Line 57: Referencing deprecated class > 'com.google.gwt.user.client.impl.DOMImplStandard' >[WARN] Warnings in > 'jar:file:/home/redacted/.gradle/caches/modules-2/files-2.1/org.gwtproject/gwt-user/2.10.0-new-groupid-2/10fcf6c7213db2fc2c71a7731c582b6d8f9a4739/gwt-user-2.10.0-new-groupid-2.jar!/com/google/gwt/user/client/ui/impl/RichTextAreaImplMozilla.java' > [WARN] Line 40: Referencing deprecated class > 'com.google.gwt.user.client.ui.impl.RichTextAreaImplStandard' > [WARN] Line 68: Referencing deprecated class > 'com.google.gwt.user.client.ui.impl.RichTextAreaImplStandard' > > and later fails with errors in a (very old) third-party dependency, > related to generics and wildcards (see below); but those errors are already > there with GWT 2.9.0 actually, and if I remove -failOnError then it > compiles OK! > > Result of the compilation runs OK in Chrome (haven't tested others, and > haven't run extensive tests either, so I can't say there are no > regressions), and dev mode runs OK as well (after I remove -failOnError). > This is using Activities/Places, UiBinder, Editors and RequestFactory > extensively. Fwiw, it's also using elemental2-dom 1.0.0-RC1 (I probably > should have updated), and GIN 2.1.2 (with Guice 4.2.2). > > I also tried replacing the BOM dependency with org.gwtproject:gwt (without > changing the actual dependencies, so still using com.google.gwt:gwt-user), > works the same. > > I would prefer if the deprecation warnings above were suppressed before > the release, but it otherwise LGTM. At least the relocation works as > expected (from a Gradle point of view) > > Thanks a lot Colin for the hard work. > >Tracing compile failure path for type > 'org.waveprotocol.wave.model.supplement.WaveletBasedSupplement' > [ERROR] Errors in > 'jar:file:/home/redacted/.gradle/caches/modules-2/files-2.1/org.waveprotocol.waveinabox/waveinabox-model/redacted!/org/waveprotocol/wave/model/supplement/WaveletBasedSupplement.java' > [ERROR] Line 948: The method > createWaveletSeenVersion(DocumentEventRouter) in the type > WaveletBasedSupplement is not applicable for the arguments > (DocumentEventRouter) > [ERROR] Line 943: The method > create(ObservableMutableDocument) in the type > DefaultDocumentEventRouter is not applicable for the arguments > (ObservableMutableDocument) > [ERROR] Line 953: The method > create(ObservableMutableDocument) in the type > DefaultDocumentEventRouter is not applicable for the arguments > (ObservableMutableDocument) > [ERROR] Line 918: The method createMuted(DocumentEventRouter super E,E,?>) in the type WaveletBasedSupplement is not applicable for the > arguments (DocumentEventRouter) > [ERROR] Line 933: The method
Re: [gwt-contrib] Preliminary testing for GWT 2.10 release
I tried changing only the version (from com.google.gwt:gwt:2.8.2 to com.google.gwt:2.10.0-new-groupid-2). Looking at a dependency graph (./gradlew dependencies), I can see the com.google.gwt dependencies properly "relocated" to their org.gwtproject equivalent Java compilation passes without warning or error, same for JVM tests (I don't have much that use GWT though), and even GWT tests! (I only have a couple of them though) GWT compilation emits a few unexpected warnings though: [WARN] Warnings in 'jar:file:/home/redacted/.gradle/caches/modules-2/files-2.1/org.gwtproject/gwt-user/2.10.0-new-groupid-2/10fcf6c7213db2fc2c71a7731c582b6d8f9a4739/gwt-user-2.10.0-new-groupid-2.jar!/com/google/gwt/user/client/impl/DOMImplMozilla.java' [WARN] Line 30: Referencing deprecated class 'com.google.gwt.user.client.impl.DOMImplStandard' [WARN] Line 30: Referencing deprecated class 'com.google.gwt.user.client.impl.DOMImplStandard' [WARN] Line 57: Referencing deprecated class 'com.google.gwt.user.client.impl.DOMImplStandard' [WARN] Warnings in 'jar:file:/home/redacted/.gradle/caches/modules-2/files-2.1/org.gwtproject/gwt-user/2.10.0-new-groupid-2/10fcf6c7213db2fc2c71a7731c582b6d8f9a4739/gwt-user-2.10.0-new-groupid-2.jar!/com/google/gwt/user/client/ui/impl/RichTextAreaImplMozilla.java' [WARN] Line 40: Referencing deprecated class 'com.google.gwt.user.client.ui.impl.RichTextAreaImplStandard' [WARN] Line 68: Referencing deprecated class 'com.google.gwt.user.client.ui.impl.RichTextAreaImplStandard' and later fails with errors in a (very old) third-party dependency, related to generics and wildcards (see below); but those errors are already there with GWT 2.9.0 actually, and if I remove -failOnError then it compiles OK! Result of the compilation runs OK in Chrome (haven't tested others, and haven't run extensive tests either, so I can't say there are no regressions), and dev mode runs OK as well (after I remove -failOnError). This is using Activities/Places, UiBinder, Editors and RequestFactory extensively. Fwiw, it's also using elemental2-dom 1.0.0-RC1 (I probably should have updated), and GIN 2.1.2 (with Guice 4.2.2). I also tried replacing the BOM dependency with org.gwtproject:gwt (without changing the actual dependencies, so still using com.google.gwt:gwt-user), works the same. I would prefer if the deprecation warnings above were suppressed before the release, but it otherwise LGTM. At least the relocation works as expected (from a Gradle point of view) Thanks a lot Colin for the hard work. Tracing compile failure path for type 'org.waveprotocol.wave.model.supplement.WaveletBasedSupplement' [ERROR] Errors in 'jar:file:/home/redacted/.gradle/caches/modules-2/files-2.1/org.waveprotocol.waveinabox/waveinabox-model/redacted!/org/waveprotocol/wave/model/supplement/WaveletBasedSupplement.java' [ERROR] Line 948: The method createWaveletSeenVersion(DocumentEventRouter) in the type WaveletBasedSupplement is not applicable for the arguments (DocumentEventRouter) [ERROR] Line 943: The method create(ObservableMutableDocument) in the type DefaultDocumentEventRouter is not applicable for the arguments (ObservableMutableDocument) [ERROR] Line 953: The method create(ObservableMutableDocument) in the type DefaultDocumentEventRouter is not applicable for the arguments (ObservableMutableDocument) [ERROR] Line 918: The method createMuted(DocumentEventRouter) in the type WaveletBasedSupplement is not applicable for the arguments (DocumentEventRouter) [ERROR] Line 933: The method createPendingNotification(DocumentEventRouter) in the type WaveletBasedSupplement is not applicable for the arguments (DocumentEventRouter) [ERROR] Line 938: The method createWaveletReadState(DocumentEventRouter, ObservablePrimitiveSupplement.Listener) in the type WaveletBasedSupplement is not applicable for the arguments (DocumentEventRouter, ObservablePrimitiveSupplement.Listener) [ERROR] Line 958: The method create(ObservableMutableDocument) in the type DefaultDocumentEventRouter is not applicable for the arguments (ObservableMutableDocument) [ERROR] Line 923: The method create(ObservableMutableDocument) in the type DefaultDocumentEventRouter is not applicable for the arguments (ObservableMutableDocument) [ERROR] Line 913: The method createFolders(DocumentEventRouter) in the type WaveletBasedSupplement is not applicable for the arguments (DocumentEventRouter) [ERROR] Line 913: The method create(ObservableMutableDocument) in the type DefaultDocumentEventRouter is not applicable for the arguments (ObservableMutableDocument) [ERROR] Line 938: The method create(ObservableMutableDocument) in the type DefaultDocumentEventRouter is not applicable for the arguments (ObservableMutableDocument) [ERROR] Line 933: The method create(ObservableMutableDocument) in the type DefaultDocumentEventRouter is not applicable
[gwt-contrib] Re: License for gwt-site content
Ah thank you, I'm very happy to be wrong. I checked a several commits but didn't think to look at PRs. Changes made to gwt-site do not go through gerrit, but through github since late 2014, though the CLA bot does still track it. I had already gone through the list of committers who made changes to markdown that were more than 5 lines in total and narrowed that list to only ones who didn't have a CLA on gwt-review.googlesource.com, but it turns out that list of ~38 people must have signed the CLA in some other way. I'll recheck the PRs those committers were involved in to confirm, but it sounds like we just need to clarify the license directly, since the CLA gives us (well, Google technically) the right to do that. As Google is winding down their direct involvement in the project, the CLA bot will be turned off soon, and we'll want to be sure we have an explicitly license in all projects that covers contributions, but so far this was the only project deficient in this way - and the only project not covered by gerrit. Thanks again for finding my mistake. On Friday, April 22, 2022 at 3:40:42 AM UTC-5 Jens wrote: > Haven't all changes been made through gerrit and did require a CLA? > > --J. > > Colin Alworth schrieb am Donnerstag, 21. April 2022 um 17:34:49 UTC+2: > >> See the question raised at >> https://github.com/gwtproject/gwt-site/issues/328. >> >> While gwtproject explicitly licenses all "software and sample code" as >> under the Apache License 2.0, it appears that we don't have a license >> specified for the contents of the gwtproject website ( >> https://gwtproject.org, https://github.com/gwtproject/gwt-site/). A case >> could be made that the content is already licensed as under the same >> license. It was my understanding that this is discouraged (though at the >> moment I'm having a hard time seeing why that would be). I can find >> concrete examples of the Apache Foundation licensing their documentation >> under the Apache License >> * https://github.com/apache/couchdb-documentation >> * https://github.com/apache/cordova-docs >> >> On the other hand, if the Apache license that applies to all code and >> samples does not apply to the contents, then each author owns their own >> content directly. >> >> I am not a lawyer, but my understanding is that (at least in the country >> in which I reside) content is copyrighted by default, and the author owns >> that copyright. Additional rights must be granted by the author. If we want >> to change the license, we need the approval of the authors so far - >> https://github.com/gwtproject/gwt-site/graphs/contributors. Anyone who >> doesn't approve would need to have their content removed, if we decide to >> change. >> >> Are we sufficiently clear that all content is Apache licensed, including >> the website documentation? Is there a good reason to consider a different >> license instead? Should we seek confirmation from any authors of >> substantial amounts of content that their content falls under the license >> we choose? >> >> My suggestion is to clarify that all content is under the Apache License, >> and see a confirmation from any author who wrote more than ~5 lines of >> content. If we think we are already clear that all content is under that >> license, then we should state that in an up front way, such as setting the >> "license" metadata of the gwt-site repo, and adding a LICENSE file. >> >> Thoughts, suggestions, pointers to how other projects have handled this? >> > -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/5a00b0b9-fb6b-48c1-a6c9-156908ba3dean%40googlegroups.com.
[gwt-contrib] Re: License for gwt-site content
Haven't all changes been made through gerrit and did require a CLA? --J. Colin Alworth schrieb am Donnerstag, 21. April 2022 um 17:34:49 UTC+2: > See the question raised at > https://github.com/gwtproject/gwt-site/issues/328. > > While gwtproject explicitly licenses all "software and sample code" as > under the Apache License 2.0, it appears that we don't have a license > specified for the contents of the gwtproject website ( > https://gwtproject.org, https://github.com/gwtproject/gwt-site/). A case > could be made that the content is already licensed as under the same > license. It was my understanding that this is discouraged (though at the > moment I'm having a hard time seeing why that would be). I can find > concrete examples of the Apache Foundation licensing their documentation > under the Apache License > * https://github.com/apache/couchdb-documentation > * https://github.com/apache/cordova-docs > > On the other hand, if the Apache license that applies to all code and > samples does not apply to the contents, then each author owns their own > content directly. > > I am not a lawyer, but my understanding is that (at least in the country > in which I reside) content is copyrighted by default, and the author owns > that copyright. Additional rights must be granted by the author. If we want > to change the license, we need the approval of the authors so far - > https://github.com/gwtproject/gwt-site/graphs/contributors. Anyone who > doesn't approve would need to have their content removed, if we decide to > change. > > Are we sufficiently clear that all content is Apache licensed, including > the website documentation? Is there a good reason to consider a different > license instead? Should we seek confirmation from any authors of > substantial amounts of content that their content falls under the license > we choose? > > My suggestion is to clarify that all content is under the Apache License, > and see a confirmation from any author who wrote more than ~5 lines of > content. If we think we are already clear that all content is under that > license, then we should state that in an up front way, such as setting the > "license" metadata of the gwt-site repo, and adding a LICENSE file. > > Thoughts, suggestions, pointers to how other projects have handled this? > -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/36d93c6d-09d6-46c4-bfc6-86df8d8cc5abn%40googlegroups.com.
