Re: [gwt-contrib] Preliminary testing for GWT 2.10 release

2022-04-24 Thread Juan Pablo Gardella
Tried with Maven 3.8.5 and still fails with same issue. Reported at
https://github.com/tbroyer/gwt-maven-plugin/issues/152

On Sun, Apr 24, 2022 at 3:59 PM Colin Alworth  wrote:

> I've pushed a new build with version 2.10.0-new-groupid-3 that has several
> @SuppressWarnings("deprecation")s added, and hopefully will solve the WARN
> logging issue.
>
> --
> You received this message because you are subscribed to the Google Groups
> "GWT Contributors" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/google-web-toolkit-contributors/28cff012-2206-48a8-8882-11b0ea945046n%40googlegroups.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/CA%2BkiFsdpiEDJOdjMYg52WnmDi-zt%3DPipSk9LXb_T-Ben9A5QYQ%40mail.gmail.com.


Re: [gwt-contrib] Preliminary testing for GWT 2.10 release

2022-04-24 Thread Colin Alworth
I've pushed a new build with version 2.10.0-new-groupid-3 that has several 
@SuppressWarnings("deprecation")s added, and hopefully will solve the WARN 
logging issue.

-- 
You received this message because you are subscribed to the Google Groups "GWT 
Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/28cff012-2206-48a8-8882-11b0ea945046n%40googlegroups.com.


Re: [gwt-contrib] Preliminary testing for GWT 2.10 release

2022-04-24 Thread Thomas Broyer
Le dim. 24 avr. 2022 à 18:14, Juan Pablo Gardella <
gardellajuanpa...@gmail.com> a écrit :

> I tested and I updated from net.ltgt.gwt.maven:gwt-maven-plugin:1.0.0 to
> net.ltgt.gwt.maven:gwt-maven-plugin:1.0.1 in order to see the proper
> error (* Value 'ie10' in not a valid value for property 'user.agent'*)
> instead of [1]. After that I see following error:
>
> [ERROR] Failed to execute goal
> net.ltgt.gwt.maven:gwt-maven-plugin:1.0.1:package-app (default-package-app)
> on project xxx-client: Execution default-package-app of goal
> net.ltgt.gwt.maven:gwt-maven-plugin:1.0.1:package-app failed: An API
> incompatibility was encountered while executing
> net.ltgt.gwt.maven:gwt-maven-plugin:1.0.1:package-app:
> java.lang.NoSuchMethodError:
> org.codehaus.plexus.util.DirectoryScanner.setFilenameComparator(Ljava/util/Comparator;)V
>

Could you file a bug with the full stack trace?
https://github.com/tbroyer/gwt-maven-plugin/issues

Version 1.0.1 also updated dependencies (
https://github.com/tbroyer/gwt-maven-plugin/commit/d61e5f14cf9b5485494723e212153d23fec0c4c5)
so maybe it caused a regression with Maven 3.6 (this is only tested with
the latest version -what's available on Arch Linux- and the version
available on GitHub Actions, which I believe are currently both 3.8.4), you
could try downgrading those by declaring plugin dependencies in your POM.


> Using either java8 or java11 as default java but java8 with toolchains
>  for
> the project. Reverted to net.ltgt.gwt.maven:gwt-maven-plugin:1.0.0 I
> still see NPE[1]. No luck from my side to switch. Any ideas? I am using
> Apache Maven 3.6.3.
>
> Juan
>
> [1]
> Caused by: java.lang.NullPointerException
> at
> net.ltgt.gwt.maven.GenerateModuleMojo.generateInheritsFromDependencies
> (GenerateModuleMojo.java:251)
> at net.ltgt.gwt.maven.GenerateModuleMojo.execute
> (GenerateModuleMojo.java:180)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:210)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
> at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:498)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:347)
>
> On Fri, Apr 22, 2022 at 3:35 PM Colin Alworth  wrote:
>
>> I could revert the deprecations (though they were specifically added at
>> your request ;) ).
>>
>> That said, those changed when the old IE versions were removed, and I
>> didn't see the showcase start to emit those errors then. Even with the JDT
>> upgrade, I still don't see them for the showcase:
>>
>> https://github.com/niloc132/gwt/runs/6124099314?check_suite_focus=true#step:5:3295
>>
>> The error also does not appear to happen when running from ant, at least
>> not in the showcase sample.
>>
>> At a glance I can't see anything explicitly disabling deprecation
>> warnings in that code. The warning is coming from JsniReferenceResolver.
>> The linked log above is emitting warnings, but clearly not one for the code
>> you see, even though the showcase references those types. Showcase's
>> CwRichText explicitly uses the RichText widget.
>>
>> However, both maven and gradle projects do correctly include the
>> warnings, if you happen to include those gwt modules in your project. That
>> does make the iteration time a bit 

Re: [gwt-contrib] Preliminary testing for GWT 2.10 release

2022-04-24 Thread Juan Pablo Gardella
I tested and I updated from net.ltgt.gwt.maven:gwt-maven-plugin:1.0.0 to
net.ltgt.gwt.maven:gwt-maven-plugin:1.0.1 in order to see the proper error (*
Value 'ie10' in not a valid value for property 'user.agent'*) instead of
[1]. After that I see following error:

[ERROR] Failed to execute goal
net.ltgt.gwt.maven:gwt-maven-plugin:1.0.1:package-app (default-package-app)
on project xxx-client: Execution default-package-app of goal
net.ltgt.gwt.maven:gwt-maven-plugin:1.0.1:package-app failed: An API
incompatibility was encountered while executing
net.ltgt.gwt.maven:gwt-maven-plugin:1.0.1:package-app:
java.lang.NoSuchMethodError:
org.codehaus.plexus.util.DirectoryScanner.setFilenameComparator(Ljava/util/Comparator;)V

Using either java8 or java11 as default java but java8 with toolchains
 for the
project. Reverted to net.ltgt.gwt.maven:gwt-maven-plugin:1.0.0 I still see
NPE[1]. No luck from my side to switch. Any ideas? I am using Apache Maven
3.6.3.

Juan

[1]
Caused by: java.lang.NullPointerException
at
net.ltgt.gwt.maven.GenerateModuleMojo.generateInheritsFromDependencies
(GenerateModuleMojo.java:251)
at net.ltgt.gwt.maven.GenerateModuleMojo.execute
(GenerateModuleMojo.java:180)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
(DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:210)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:148)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:117)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:81)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
(SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
(Launcher.java:282)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch
(Launcher.java:225)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
(Launcher.java:406)
at org.codehaus.plexus.classworlds.launcher.Launcher.main
(Launcher.java:347)

On Fri, Apr 22, 2022 at 3:35 PM Colin Alworth  wrote:

> I could revert the deprecations (though they were specifically added at
> your request ;) ).
>
> That said, those changed when the old IE versions were removed, and I
> didn't see the showcase start to emit those errors then. Even with the JDT
> upgrade, I still don't see them for the showcase:
>
> https://github.com/niloc132/gwt/runs/6124099314?check_suite_focus=true#step:5:3295
>
> The error also does not appear to happen when running from ant, at least
> not in the showcase sample.
>
> At a glance I can't see anything explicitly disabling deprecation warnings
> in that code. The warning is coming from JsniReferenceResolver. The linked
> log above is emitting warnings, but clearly not one for the code you see,
> even though the showcase references those types. Showcase's CwRichText
> explicitly uses the RichText widget.
>
> However, both maven and gradle projects do correctly include the warnings,
> if you happen to include those gwt modules in your project. That does make
> the iteration time a bit longer to test, but it appears we can suppress the
> warnings on a per-usage basis. I'll propose a patch (and upload a new build
> to test) as soon as I'm able.
>
>
> On Friday, April 22, 2022 at 9:12:58 AM UTC-5 Thomas Broyer wrote:
>
>> I tried changing only the version (from com.google.gwt:gwt:2.8.2 to
>> com.google.gwt:2.10.0-new-groupid-2).
>> Looking at a dependency graph (./gradlew dependencies), I can see the
>> com.google.gwt dependencies properly "relocated" to their org.gwtproject
>> equivalent 
>> Java compilation passes without warning or error, same for JVM tests (I
>> don't have much that use GWT though), and even GWT tests!  (I only have a
>> couple of them though)
>> GWT compilation emits a few unexpected warnings though:
>>[WARN] Warnings in