Re: [gwt-contrib] [google-web-toolkit] r8780 committed - Fixes https://jira.springsource.org/browse/ROO-1213 - Hide Property fr...

2010-09-16 Thread Patrick Julien 
2010/9/15 Miguel Méndez mmen...@google.com:
 Thanks for spotting that Patrick.  I'll get the code updated.

no thank you

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] [google-web-toolkit] r8780 committed - Fixes https://jira.springsource.org/browse/ROO-1213 - Hide Property fr...

2010-09-15 Thread Patrick Julien 
On Wed, Sep 15, 2010 at 4:45 PM, Patrick Julien pjul...@gmail.com wrote:
 Oh, and forgot to mention, that the root problem is of course this:

 public String getValue(R object) {
    ProxyImpl proxyImpl = (ProxyImpl) object;
    return renderer.render(proxyImpl.Tget(property, String.class));
  }

 in PropertyColumn, I believe it should be:

 public String getValue(R object) {
    ProxyImpl proxyImpl = (ProxyImpl) object;
    return renderer.render(proxyImpl.Tget(property));


Except that doesn't work because the single argument version needs a
PropertyV instead of a String.

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] [google-web-toolkit] r8780 committed - Fixes https://jira.springsource.org/browse/ROO-1213 - Hide Property fr...

2010-09-15 Thread Pascal Patry 
On Wednesday, September 15, 2010 16:16:06 Patrick Julien wrote:
   public String getValue(R object) {
 -return renderer.render(object.get(property));
 +ProxyImpl proxyImpl = (ProxyImpl) object;
 +return renderer.render(proxyImpl.Tget(property, String.class));
   }
 
 This blows up on anything that isn't a String.  At least on
 Windows/Chrome it does in dev mode.  In Linux seems to work fine.
 [...]

Yeah, I'm also getting this issue on FF on linux when debugging a gwt
app.

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] [google-web-toolkit] r8780 committed - Fixes https://jira.springsource.org/browse/ROO-1213 - Hide Property fr...

2010-09-15 Thread Patrick Julien 
using this as tmp work around for now:

package com...workarounds;

import com.google.gwt.app.place.PropertyColumn;
import com.google.gwt.requestfactory.client.impl.ProxyImpl;
import com.google.gwt.requestfactory.shared.EntityProxy;
import com.google.gwt.text.shared.Renderer;

public final class WorkAroundPropertyColumnR extends EntityProxy, T
extends PropertyColumnR, T {
private final RendererT renderer;
private final String property;
private final ClassT clazz;

public WorkAroundPropertyColumn(final String property, final String
displayName, final RendererT renderer, final ClassT clazz) {
super(property, displayName, renderer);
this.property = property;
this.renderer = renderer;
this.clazz = clazz;
}

@Override
public String getValue(final R object) {
final ProxyImpl proxyImpl = (ProxyImpl) object;
return renderer.render(proxyImpl.T get(property, clazz));
}
}


On Wed, Sep 15, 2010 at 5:10 PM, Pascal Patry i...@invalidip.com wrote:
 On Wednesday, September 15, 2010 16:16:06 Patrick Julien wrote:
   public String getValue(R object) {
 -    return renderer.render(object.get(property));
 +    ProxyImpl proxyImpl = (ProxyImpl) object;
 +    return renderer.render(proxyImpl.Tget(property, String.class));
   }

 This blows up on anything that isn't a String.  At least on
 Windows/Chrome it does in dev mode.  In Linux seems to work fine.
 [...]

 Yeah, I'm also getting this issue on FF on linux when debugging a gwt
 app.

 --
 http://groups.google.com/group/Google-Web-Toolkit-Contributors

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] [google-web-toolkit] r8780 committed - Fixes https://jira.springsource.org/browse/ROO-1213 - Hide Property fr...

2010-09-15 Thread Miguel Méndez 
Thanks for spotting that Patrick.  I'll get the code updated.

On Wed, Sep 15, 2010 at 5:54 PM, Patrick Julien pjul...@gmail.com wrote:

 using this as tmp work around for now:

 package com...workarounds;

 import com.google.gwt.app.place.PropertyColumn;
 import com.google.gwt.requestfactory.client.impl.ProxyImpl;
 import com.google.gwt.requestfactory.shared.EntityProxy;
 import com.google.gwt.text.shared.Renderer;

 public final class WorkAroundPropertyColumnR extends EntityProxy, T
 extends PropertyColumnR, T {
 private final RendererT renderer;
 private final String property;
private final ClassT clazz;

public WorkAroundPropertyColumn(final String property, final String
 displayName, final RendererT renderer, final ClassT clazz) {
super(property, displayName, renderer);
 this.property = property;
this.renderer = renderer;
 this.clazz = clazz;
}

@Override
public String getValue(final R object) {
final ProxyImpl proxyImpl = (ProxyImpl) object;
return renderer.render(proxyImpl.T get(property, clazz));
 }
 }


 On Wed, Sep 15, 2010 at 5:10 PM, Pascal Patry i...@invalidip.com wrote:
  On Wednesday, September 15, 2010 16:16:06 Patrick Julien wrote:
public String getValue(R object) {
  -return renderer.render(object.get(property));
  +ProxyImpl proxyImpl = (ProxyImpl) object;
  +return renderer.render(proxyImpl.Tget(property, String.class));
}
 
  This blows up on anything that isn't a String.  At least on
  Windows/Chrome it does in dev mode.  In Linux seems to work fine.
  [...]
 
  Yeah, I'm also getting this issue on FF on linux when debugging a gwt
  app.
 
  --
  http://groups.google.com/group/Google-Web-Toolkit-Contributors

 --
 http://groups.google.com/group/Google-Web-Toolkit-Contributors




-- 
Miguel

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors