[gwt-contrib] Change in gwt[master]: Chooses a default GWT source level to match the current java...
Hello Matthew Dempsky, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2910 to look at the new patch set (#8). Change subject: Chooses a default GWT source level to match the current java runtime. .. Chooses a default GWT source level to match the current java runtime. Now the GWT default source compatibility level will try to match the system property java.specification.version. A small refactor in SourceLevel and a fix to apicheck have been made to allow specifing the java source compatibility level when processing apis in order to avoid a compile error on an old version of emul.Enum. Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f --- M dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java M dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java M dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java M dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSource.java M dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java M dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java M dev/core/src/com/google/gwt/util/tools/Utility.java M dev/core/test/com/google/gwt/dev/CompilerTest.java M dev/core/test/com/google/gwt/dev/javac/CompilationStateTestBase.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java M dev/core/test/com/google/gwt/dev/util/UtilityTest.java M tools/api-checker/config/gwt25_26userApi.conf M tools/api-checker/src/com/google/gwt/tools/apichecker/ApiCompatibilityChecker.java M tools/api-checker/src/com/google/gwt/tools/apichecker/ApiContainer.java 18 files changed, 171 insertions(+), 48 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2910 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f Gerrit-PatchSet: 8 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Chooses a default GWT source level to match the current java...
Roberto Lublinerman has submitted this change and it was merged.
Change subject: Chooses a default GWT source level to match the current
java runtime.
..
Chooses a default GWT source level to match the current java runtime.
Now the GWT default source compatibility level will try to match the
system property java.specification.version.
A small refactor in SourceLevel and a fix to apicheck have been made to
allow specifing the java source compatibility level when processing apis
in order to avoid a compile error on an old version of emul.Enum.
Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f
---
M dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java
M dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java
M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java
M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java
M dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java
M dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java
M dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSource.java
M dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java
M dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java
M dev/core/src/com/google/gwt/util/tools/Utility.java
M dev/core/test/com/google/gwt/dev/CompilerTest.java
M dev/core/test/com/google/gwt/dev/javac/CompilationStateTestBase.java
M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java
M dev/core/test/com/google/gwt/dev/util/UtilityTest.java
M tools/api-checker/config/gwt25_26userApi.conf
M
tools/api-checker/src/com/google/gwt/tools/apichecker/ApiCompatibilityChecker.java
M tools/api-checker/src/com/google/gwt/tools/apichecker/ApiContainer.java
18 files changed, 171 insertions(+), 48 deletions(-)
Approvals:
Roberto Lublinerman: Looks good to me, approved
Leeroy Jenkins: Verified
diff --git a/dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java
b/dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java
index e16534f..de9e3fc 100644
--- a/dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java
+++ b/dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java
@@ -50,7 +50,7 @@
private int port = 9876;
private RecompileListener recompileListener = RecompileListener.NONE;
// Use the same default as the GWT compiler.
- private SourceLevel sourceLevel = OptionSource.DEFAULT_SOURCE_LEVEL;
+ private SourceLevel sourceLevel = SourceLevel.DEFAULT_SOURCE_LEVEL;
/**
* Sets each option to the appropriate value, based on command-line
arguments.
diff --git a/dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java
b/dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java
index 34cceb6..978cff9 100644
--- a/dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java
+++ b/dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java
@@ -16,7 +16,6 @@
package com.google.gwt.dev;
import com.google.gwt.core.ext.TreeLogger.Type;
-import com.google.gwt.dev.util.arg.OptionSource;
import com.google.gwt.dev.util.arg.SourceLevel;
import java.io.File;
@@ -31,7 +30,7 @@
private Type logLevel;
private final ListString moduleNames = new ArrayListString();
private File workDir;
- private SourceLevel sourceLevel = OptionSource.DEFAULT_SOURCE_LEVEL;
+ private SourceLevel sourceLevel = SourceLevel.DEFAULT_SOURCE_LEVEL;
public CompileTaskOptionsImpl() {
}
diff --git a/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java
b/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java
index 579275d..63016d1 100644
--- a/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java
+++ b/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java
@@ -33,7 +33,6 @@
import com.google.gwt.dev.resource.impl.ResourceOracleImpl;
import com.google.gwt.dev.util.Empty;
import com.google.gwt.dev.util.Util;
-import com.google.gwt.dev.util.arg.OptionSource;
import com.google.gwt.dev.util.arg.SourceLevel;
import com.google.gwt.dev.util.log.speedtracer.CompilerEventType;
import com.google.gwt.dev.util.log.speedtracer.SpeedTracerLogger;
@@ -366,7 +365,7 @@
}
public CompilationState getCompilationState(TreeLogger logger) throws
UnableToCompleteException {
-return getCompilationState(logger, false,
OptionSource.DEFAULT_SOURCE_LEVEL);
+return getCompilationState(logger, false,
SourceLevel.DEFAULT_SOURCE_LEVEL);
}
public synchronized CompilationState getCompilationState(TreeLogger
logger,
diff --git
a/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
b/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
index fc359db..d450ca7 100644
--- a/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
+++ b/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java
@@ -25,7 +25,6 @@
import com.google.gwt.dev.js.ast.JsRootScope;
import com.google.gwt.dev.resource.Resource;
[gwt-contrib] Change in gwt[master]: Chooses a default GWT source level to match the current java...
Roberto Lublinerman has posted comments on this change. Change subject: Chooses a default GWT source level to match the current java runtime. .. Patch Set 8: Code-Review+2 Patch is the same as #7 approved by mdempsky. Only added a comment. -- To view, visit https://gwt-review.googlesource.com/2910 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f Gerrit-PatchSet: 8 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Chooses a default GWT source level to match the current java...
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2910 to look at the new patch set (#5). Change subject: Chooses a default GWT source level to match the current java runtime. .. Chooses a default GWT source level to match the current java runtime. Now the GWT default source compatibility level will try to match the system property java.specification.version. A small refactor in SourceLevel and a fix to apicheck have been made to allow specifing the java source compatibility level when processing apis in order to avoid a compile error on an old version of emul.Enum. Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f --- M dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java M dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java M dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java M dev/core/src/com/google/gwt/dev/util/Util.java M dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSource.java M dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java M dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java M dev/core/src/com/google/gwt/util/tools/Utility.java M dev/core/test/com/google/gwt/dev/CompilerTest.java M dev/core/test/com/google/gwt/dev/javac/CompilationStateTestBase.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java M dev/core/test/com/google/gwt/dev/util/UtilityTest.java M tools/api-checker/config/gwt25_26userApi.conf M tools/api-checker/src/com/google/gwt/tools/apichecker/ApiCompatibilityChecker.java M tools/api-checker/src/com/google/gwt/tools/apichecker/ApiContainer.java 19 files changed, 171 insertions(+), 47 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2910 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Chooses a default GWT source level to match the current java...
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2910 to look at the new patch set (#6). Change subject: Chooses a default GWT source level to match the current java runtime. .. Chooses a default GWT source level to match the current java runtime. Now the GWT default source compatibility level will try to match the system property java.specification.version. A small refactor in SourceLevel and a fix to apicheck have been made to allow specifing the java source compatibility level when processing apis in order to avoid a compile error on an old version of emul.Enum. Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f --- M dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java M dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java M dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java M dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSource.java M dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java M dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java M dev/core/src/com/google/gwt/util/tools/Utility.java M dev/core/test/com/google/gwt/dev/CompilerTest.java M dev/core/test/com/google/gwt/dev/javac/CompilationStateTestBase.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java M dev/core/test/com/google/gwt/dev/util/UtilityTest.java M tools/api-checker/config/gwt25_26userApi.conf M tools/api-checker/src/com/google/gwt/tools/apichecker/ApiCompatibilityChecker.java M tools/api-checker/src/com/google/gwt/tools/apichecker/ApiContainer.java 18 files changed, 169 insertions(+), 47 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2910 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f Gerrit-PatchSet: 6 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Chooses a default GWT source level to match the current java...
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2910 to look at the new patch set (#7). Change subject: Chooses a default GWT source level to match the current java runtime. .. Chooses a default GWT source level to match the current java runtime. Now the GWT default source compatibility level will try to match the system property java.specification.version. A small refactor in SourceLevel and a fix to apicheck have been made to allow specifing the java source compatibility level when processing apis in order to avoid a compile error on an old version of emul.Enum. Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f --- M dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java M dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java M dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java M dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSource.java M dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java M dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java M dev/core/src/com/google/gwt/util/tools/Utility.java M dev/core/test/com/google/gwt/dev/CompilerTest.java M dev/core/test/com/google/gwt/dev/javac/CompilationStateTestBase.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java M dev/core/test/com/google/gwt/dev/util/UtilityTest.java M tools/api-checker/config/gwt25_26userApi.conf M tools/api-checker/src/com/google/gwt/tools/apichecker/ApiCompatibilityChecker.java M tools/api-checker/src/com/google/gwt/tools/apichecker/ApiContainer.java 18 files changed, 170 insertions(+), 48 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2910 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f Gerrit-PatchSet: 7 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Chooses a default GWT source level to match the current java...
Matthew Dempsky has posted comments on this change.
Change subject: Chooses a default GWT source level to match the current
java runtime.
..
Patch Set 4:
(2 comments)
Argh, apparently these comments didn't get posted when I reviewed patch set
5. Frustrating.
File dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java
Line 30: /**
Nit: Blank line before the javadoc.
Line 67: if (Util.versionCompare(javaSpecLevel,
sourceLevel.stringValue) = 0) {
I like Util.versionCompare() a lot more than the double parsing from
before. :) [Edit: Renaming to Utility is fine by me too.]
However, the last match wins strategy seems to assume that the
SourceLevels will be in increasing order? If so, I think that's worth
adding as a quick comment like Static initializer for DEFAULT_SOURCE_LEVEL
depends on these being in increasing order right before JAVA6 and JAVA7
above.
--
To view, visit https://gwt-review.googlesource.com/2910
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Chooses a default GWT source level to match the current java...
Matthew Dempsky has posted comments on this change. Change subject: Chooses a default GWT source level to match the current java runtime. .. Patch Set 7: Code-Review+2 Nice. -- To view, visit https://gwt-review.googlesource.com/2910 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f Gerrit-PatchSet: 7 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Chooses a default GWT source level to match the current java...
Roberto Lublinerman has posted comments on this change. Change subject: Chooses a default GWT source level to match the current java runtime. .. Patch Set 4: @Matthew, I ended up fixing ApiCompatibilityChecker to accept also the java source level in the configuration file so there is no need now to change the old file. -- To view, visit https://gwt-review.googlesource.com/2910 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Chooses a default gwt source level to match the current java...
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2910 to look at the new patch set (#2). Change subject: Chooses a default gwt source level to match the current java runtime. .. Chooses a default gwt source level to match the current java runtime. Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f --- M dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java M dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java 2 files changed, 42 insertions(+), 1 deletion(-) -- To view, visit https://gwt-review.googlesource.com/2910 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Chooses a default gwt source level to match the current java...
Matthew Dempsky has posted comments on this change. Change subject: Chooses a default gwt source level to match the current java runtime. .. Patch Set 1: (1 comment) File dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java Line 83: double javaSpecLevel = Double.parseDouble(System.getProperty(java.specification.version)); It looks like java.specification.version will give values like 1.6 and 1.7, so couldn't you just do a direct string equality comparison against stringValue instead of needing the Double parsing? Also, I'd probably just iterate through SourceLevel.values() and try to match each one. There's not that many SourceLevels currently, so no need to get fancy with hash maps to optimize it. :) -- To view, visit https://gwt-review.googlesource.com/2910 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Chooses a default gwt source level to match the current java...
Roberto Lublinerman has posted comments on this change.
Change subject: Chooses a default gwt source level to match the current
java runtime.
..
Patch Set 2:
I just noticed that the ApiChecker fails if you are running with source
compatibility 7 due to the fact that Enum.java in emul does not compile in
java 7.
I was thinking of updating the old source jar gwt25userApi. It is a minor
update (adds a cast) that does not affect the api in any way:
public final int compareTo(E other) {
// TODO: will a bridge method do the cast for us?
// if (this.getDeclaringClass() != other.getDeclaringClass()) {
// throw new ClassCastException();
// }
-return this.ordinal - other.ordinal;
+return this.ordinal - ((Enum) other).ordinal;
}
Any thoughts about it?
--
To view, visit https://gwt-review.googlesource.com/2910
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Chooses a default gwt source level to match the current java...
Matthew Dempsky has posted comments on this change. Change subject: Chooses a default gwt source level to match the current java runtime. .. Patch Set 2: The code should still compile the same as before with either JDK6 or JDK7, right? If so, I'm okay with making that change to the GWT 2.5.1 reference jar. People shouldn't really be using that jar for anything else anyway. -- To view, visit https://gwt-review.googlesource.com/2910 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Chooses a default gwt source level to match the current java...
Roberto Lublinerman has posted comments on this change. Change subject: Chooses a default gwt source level to match the current java runtime. .. Patch Set 1: (1 comment) File dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java Line 83: double javaSpecLevel = Double.parseDouble(System.getProperty(java.specification.version)); Hashmaps: yes, at fist I was not storing the java version value in the enum, will remove the hashmap :) I was trying to make it future proof, i.e. if you are running under 1.8 gwt should choose 1.7 (the best match) and for that relying in the numerical ordering seemed appropriate. We could rely on the string ordering and avoid all parsing, although it is only done once. -- To view, visit https://gwt-review.googlesource.com/2910 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Chooses a default GWT source level to match the current java...
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2910 to look at the new patch set (#3). Change subject: Chooses a default GWT source level to match the current java runtime. .. Chooses a default GWT source level to match the current java runtime. Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f --- M dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java M dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java 2 files changed, 25 insertions(+), 1 deletion(-) -- To view, visit https://gwt-review.googlesource.com/2910 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Chooses a default GWT source level to match the current java...
Matthew Dempsky has posted comments on this change.
Change subject: Chooses a default GWT source level to match the current
java runtime.
..
Patch Set 3:
(1 comment)
File dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java
Line 68: if (javaSpecLevel = sourceLevel.javaLevel
javaSpecLevel result.javaLevel) {
I think you mean sourceLevel.javaLevel result.javaLevel for the second
conditional?
--
To view, visit https://gwt-review.googlesource.com/2910
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Chooses a default GWT source level to match the current java...
Hello Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/2910 to look at the new patch set (#4). Change subject: Chooses a default GWT source level to match the current java runtime. .. Chooses a default GWT source level to match the current java runtime. Now the GWT default source compatibility level will try to match the system property java.specification.version. A small refactor in SourceLevel and a fix to apicheck have been made to allow specifing the java source compatibility level when processing apis in order to avoid a compile error on an old version of emul.Enum. Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f --- M dev/codeserver/java/com/google/gwt/dev/codeserver/Options.java M dev/core/src/com/google/gwt/dev/CompileTaskOptionsImpl.java M dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java M dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java M dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java M dev/core/src/com/google/gwt/dev/javac/testing/GeneratorContextBuilder.java M dev/core/src/com/google/gwt/dev/jjs/JJSOptionsImpl.java M dev/core/src/com/google/gwt/dev/util/Util.java M dev/core/src/com/google/gwt/dev/util/arg/ArgHandlerSource.java M dev/core/src/com/google/gwt/dev/util/arg/OptionSource.java M dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java M dev/core/test/com/google/gwt/dev/CompilerTest.java M dev/core/test/com/google/gwt/dev/javac/CompilationStateTestBase.java M dev/core/test/com/google/gwt/dev/jjs/impl/JJSTestBase.java M dev/core/test/com/google/gwt/dev/util/UtilityTest.java M tools/api-checker/config/gwt25_26userApi.conf M tools/api-checker/src/com/google/gwt/tools/apichecker/ApiCompatibilityChecker.java M tools/api-checker/src/com/google/gwt/tools/apichecker/ApiContainer.java 18 files changed, 169 insertions(+), 47 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2910 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f Gerrit-PatchSet: 4 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Chooses a default GWT source level to match the current java...
Roberto Lublinerman has posted comments on this change.
Change subject: Chooses a default GWT source level to match the current
java runtime.
..
Patch Set 3:
(1 comment)
File dev/core/src/com/google/gwt/dev/util/arg/SourceLevel.java
Line 68: if (javaSpecLevel = sourceLevel.javaLevel
javaSpecLevel result.javaLevel) {
Will fix.
--
To view, visit https://gwt-review.googlesource.com/2910
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I69dc0e9b1ac0ecf9a40ee2a08d8d555319d0af6f
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com
Gerrit-Reviewer: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
