[gwt-contrib] Change in gwt[master]: Upon selection in a SuggestBox's pop up, focus the text field
Daniel Kurka has abandoned this change. Change subject: Upon selection in a SuggestBox's pop up, focus the text field .. Abandoned Submitted Thanks! -- To view, visit https://gwt-review.googlesource.com/2100 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I08ba1abf8432ef4ad65c0a6b57983067d66b0d9f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Christian Aistleitner Gerrit-Reviewer: Christian Aistleitner Gerrit-Reviewer: Daniel Kurka Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Thomas Broyer -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Upon selection in a SuggestBox's pop up, focus the text field
Daniel Kurka has posted comments on this change. Change subject: Upon selection in a SuggestBox's pop up, focus the text field .. Patch Set 2: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/2100 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08ba1abf8432ef4ad65c0a6b57983067d66b0d9f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Christian Aistleitner Gerrit-Reviewer: Christian Aistleitner Gerrit-Reviewer: Daniel Kurka Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Upon selection in a SuggestBox's pop up, focus the text field
Daniel Kurka has posted comments on this change. Change subject: Upon selection in a SuggestBox's pop up, focus the text field .. Patch Set 2: Hi Christian, this was just me looking at the wrong place inside of google. Everyting is fine with your CLA. Sorry about that! -- To view, visit https://gwt-review.googlesource.com/2100 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08ba1abf8432ef4ad65c0a6b57983067d66b0d9f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Christian Aistleitner Gerrit-Reviewer: Christian Aistleitner Gerrit-Reviewer: Daniel Kurka Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Upon selection in a SuggestBox's pop up, focus the text field
Matthew Dempsky has posted comments on this change. Change subject: Upon selection in a SuggestBox's pop up, focus the text field .. Patch Set 2: Yeah, Gerrit takes care of CLA enforcement, so no need to check CLA-SIGNERS for patches from here. Maybe we should try harder to keep the file up to date anyway though. -- To view, visit https://gwt-review.googlesource.com/2100 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08ba1abf8432ef4ad65c0a6b57983067d66b0d9f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Christian Aistleitner Gerrit-Reviewer: Christian Aistleitner Gerrit-Reviewer: Daniel Kurka Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Upon selection in a SuggestBox's pop up, focus the text field
Thomas Broyer has posted comments on this change. Change subject: Upon selection in a SuggestBox's pop up, focus the text field .. Patch Set 2: Daniel, isn't the CLA process handled by Gerrit now? (BTW, CLA-SIGNERS is manually-edited and I believe there's a list inside Google with more people than those listed in this file; see the last commit: Bradley added in June when he actually signed the CLA in February) -- To view, visit https://gwt-review.googlesource.com/2100 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08ba1abf8432ef4ad65c0a6b57983067d66b0d9f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Christian Aistleitner Gerrit-Reviewer: Christian Aistleitner Gerrit-Reviewer: Daniel Kurka Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Upon selection in a SuggestBox's pop up, focus the text field
Daniel Kurka has posted comments on this change. Change subject: Upon selection in a SuggestBox's pop up, focus the text field .. Patch Set 2: Hello Christian, I could not find you on the CLA signers list: https://code.google.com/p/google-web-toolkit/source/browse/CLA-SIGNERS Could you submit a cla using one of this two this form (whichever suites you): https://developers.google.com/web-toolkit/makinggwtbetter#clas -- To view, visit https://gwt-review.googlesource.com/2100 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08ba1abf8432ef4ad65c0a6b57983067d66b0d9f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Christian Aistleitner Gerrit-Reviewer: Christian Aistleitner Gerrit-Reviewer: Daniel Kurka Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Upon selection in a SuggestBox's pop up, focus the text field
Thomas Broyer has posted comments on this change. Change subject: Upon selection in a SuggestBox's pop up, focus the text field .. Patch Set 2: Code-Review+1 LGTM -- To view, visit https://gwt-review.googlesource.com/2100 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08ba1abf8432ef4ad65c0a6b57983067d66b0d9f Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Christian Aistleitner Gerrit-Reviewer: Christian Aistleitner Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Upon selection in a SuggestBox's pop up, focus the text field
Thomas Broyer has posted comments on this change. Change subject: Upon selection in a SuggestBox's pop up, focus the text field .. Patch Set 1: Code-Review-1 (1 comment) Is there an issue open to track this? If not, please file one and add "Fixes issue " in your commit message. File user/src/com/google/gwt/user/client/ui/SuggestBox.java Line 1190: box.setFocus(true); You don't want to set the focus back to the textbox when the suggestion is selected from tabbing *out* of the textbox (see line #1138). You actually only want it when selecting the suggestion with the mouse, so moving that line to the SuggestionCallback would be better. -- To view, visit https://gwt-review.googlesource.com/2100 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08ba1abf8432ef4ad65c0a6b57983067d66b0d9f Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Christian Aistleitner Gerrit-Reviewer: Thomas Broyer Gerrit-HasComments: Yes -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
