[gwt-contrib] Change in gwt[master]: Workaround for resolving mouse button on mouse move in Firefox
Goktug Gokdogan has posted comments on this change. Change subject: Workaround for resolving mouse button on mouse move in Firefox .. Patch Set 3: Himm, I'm not very knowledgeable on browser quirks; will this work as expected in all Firefox versions? -- To view, visit https://gwt-review.googlesource.com/2330 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib73997af56ce0e7da5b41814a7ac2b208ab022aa Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Ahlroos Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: John Ahlroos Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Workaround for resolving mouse button on mouse move in Firefox
John Ahlroos has posted comments on this change. Change subject: Workaround for resolving mouse button on mouse move in Firefox .. Patch Set 3: Is there something still missing for this to get it accepted? -- To view, visit https://gwt-review.googlesource.com/2330 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib73997af56ce0e7da5b41814a7ac2b208ab022aa Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Ahlroos Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: John Ahlroos Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Workaround for resolving mouse button on mouse move in Firefox
John Ahlroos has uploaded a new patch set (#3). Change subject: Workaround for resolving mouse button on mouse move in Firefox .. Workaround for resolving mouse button on mouse move in Firefox Change-Id: Ib73997af56ce0e7da5b41814a7ac2b208ab022aa --- M user/src/com/google/gwt/dom/client/DOMImplMozilla.java 1 file changed, 26 insertions(+), 0 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2330 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib73997af56ce0e7da5b41814a7ac2b208ab022aa Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Ahlroos Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Workaround for resolving mouse button on mouse move in Firefox
Matthew Dempsky has posted comments on this change. Change subject: Workaround for resolving mouse button on mouse move in Firefox .. Patch Set 2: Verified+1 Woot, this patch set PASSED the build and checkstyle tests! :D Build details: http://gwt-ci.dempsky.org:8080/job/gwt.checkstyle/13/ -- To view, visit https://gwt-review.googlesource.com/2330 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib73997af56ce0e7da5b41814a7ac2b208ab022aa Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Ahlroos Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Matthew Dempsky Gerrit-Reviewer: Matthew Dempsky Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Workaround for resolving mouse button on mouse move in Firefox
Goktug Gokdogan has posted comments on this change. Change subject: Workaround for resolving mouse button on mouse move in Firefox .. Patch Set 2: Opps, I just checked the version field :) -- To view, visit https://gwt-review.googlesource.com/2330 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib73997af56ce0e7da5b41814a7ac2b208ab022aa Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Ahlroos Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Matthew Dempsky Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Workaround for resolving mouse button on mouse move in Firefox
Matthew Dempsky has posted comments on this change. Change subject: Workaround for resolving mouse button on mouse move in Firefox .. Patch Set 2: The bug was filed in 2002. I'm under the impression it's already been released? It would be interesting to know what other libraries do here if anyone knows off hand. -- To view, visit https://gwt-review.googlesource.com/2330 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib73997af56ce0e7da5b41814a7ac2b208ab022aa Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Ahlroos Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Matthew Dempsky Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Workaround for resolving mouse button on mouse move in Firefox
Goktug Gokdogan has posted comments on this change. Change subject: Workaround for resolving mouse button on mouse move in Firefox .. Patch Set 2: It looks like a bug for an unreleased version of Firefox. I don't think we need to work around that until (if ever) it is released. -- To view, visit https://gwt-review.googlesource.com/2330 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib73997af56ce0e7da5b41814a7ac2b208ab022aa Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Ahlroos Gerrit-Reviewer: Goktug Gokdogan Gerrit-Reviewer: Matthew Dempsky Gerrit-HasComments: No -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Workaround for resolving mouse button on mouse move in Firefox
Matthew Dempsky has posted comments on this change.
Change subject: Workaround for resolving mouse button on mouse move in
Firefox
..
Patch Set 2:
(2 comments)
Idea seems okay to me. Just some style nits.
File user/src/com/google/gwt/dom/client/DOMImplMozilla.java
Line 144: if (evt.getType().equals((BrowserEvents.MOUSEMOVE))) {
No need for the extra parentheses around BrowserEvents.MOUSEMOVE.
Line 294: if(evt.buttons){
Fix the spacing here (and below) please. It should be "if (evt.buttons) {".
--
To view, visit https://gwt-review.googlesource.com/2330
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib73997af56ce0e7da5b41814a7ac2b208ab022aa
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Ahlroos
Gerrit-Reviewer: Matthew Dempsky
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Workaround for resolving mouse button on mouse move in Firefox
John Ahlroos has uploaded a new patch set (#2). Change subject: Workaround for resolving mouse button on mouse move in Firefox .. Workaround for resolving mouse button on mouse move in Firefox Change-Id: Ib73997af56ce0e7da5b41814a7ac2b208ab022aa --- M user/src/com/google/gwt/dom/client/DOMImplMozilla.java 1 file changed, 26 insertions(+), 0 deletions(-) -- To view, visit https://gwt-review.googlesource.com/2330 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ib73997af56ce0e7da5b41814a7ac2b208ab022aa Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John Ahlroos -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Workaround for resolving mouse button on mouse move in Firefox
John Ahlroos has uploaded a new change for review.
https://gwt-review.googlesource.com/2330
Change subject: Workaround for resolving mouse button on mouse move in
Firefox
..
Workaround for resolving mouse button on mouse move in Firefox
Change-Id: Ib73997af56ce0e7da5b41814a7ac2b208ab022aa
---
M user/src/com/google/gwt/dom/client/DOMImplMozilla.java
1 file changed, 26 insertions(+), 0 deletions(-)
diff --git a/user/src/com/google/gwt/dom/client/DOMImplMozilla.java
b/user/src/com/google/gwt/dom/client/DOMImplMozilla.java
index 5dd8343..87d2455 100644
--- a/user/src/com/google/gwt/dom/client/DOMImplMozilla.java
+++ b/user/src/com/google/gwt/dom/client/DOMImplMozilla.java
@@ -140,6 +140,19 @@
}
@Override
+ public int eventGetButton(NativeEvent evt) {
+if (evt.getType().equals((BrowserEvents.MOUSEMOVE))) {
+ /*
+ * Workaround for Mozilla issue
https://bugzilla.mozilla.org/show_bug.cgi?id=129775 where
+ * mouse button is reported wrong on mouse move
+ */
+ return resolveButtonForMouseMove(evt);
+} else {
+ return super.eventGetButton(evt);
+}
+ }
+
+ @Override
public native int getBodyOffsetLeft(Document doc) /*-{
var style = $wnd.getComputedStyle(doc.documentElement, null);
if (style == null) {
@@ -276,5 +289,18 @@
var style = elem.ownerDocument.defaultView.getComputedStyle(elem,
null);
return style.direction == 'rtl';
}-*/;
+
+ private native int resolveButtonForMouseMove(NativeEvent evt)/*-{
+if(evt.buttons){
+ if (evt.buttons & 0x01){
+return 1;
+ } else if (evt.buttons & 0x02){
+return 2;
+ } else if (evt.buttons & 0x04){
+return 4;
+ }
+}
+return 1;
+ }-*/;
}
--
To view, visit https://gwt-review.googlesource.com/2330
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib73997af56ce0e7da5b41814a7ac2b208ab022aa
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Ahlroos
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
