Reviewers: tbroyer, jlabanca, jat, pdr,
Description:
Disable regex checking of URLs in SafeUriHostedModeUtils; this regex
appears to
cause stack overflows in some cases.
Please review this at http://gwt-code-reviews.appspot.com/1443813/
Affected files:
M user/src/com/google/gwt/safehtml/shared/SafeUriHostedModeUtils.java
Index: user/src/com/google/gwt/safehtml/shared/SafeUriHostedModeUtils.java
===================================================================
--- user/src/com/google/gwt/safehtml/shared/SafeUriHostedModeUtils.java
(revision 10284)
+++ user/src/com/google/gwt/safehtml/shared/SafeUriHostedModeUtils.java
(working copy)
@@ -104,9 +104,11 @@
}
private static boolean isValidUri(String uri) {
- if (!uri.matches(HREF_UCSCHAR)) {
- return false;
- }
+ // TODO(xtof): The regex appears to cause stack overflows in some
cases.
+ // Investigate and re-enable)
+ // if (!uri.matches(HREF_UCSCHAR)) {
+ // return false;
+ // }
/*
* pre-process to turn href-ucschars into ucschars, and encode to URI.
*
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
