Re: [gwt-contrib] How to include changesets to an existing gerrit review?

2015-03-09 Thread 'Daniel Kurka' via GWT Contributors
You make the changes in your local git client and amend the commit: 'git
commit --amend'

Then you just push to gerrit: 'git push origin HEAD:refs/for/master' and
this will update the review.

On Mon, Mar 9, 2015 at 3:49 PM, Juan Pablo Gardella 
gardellajuanpa...@gmail.com wrote:

 Hi all,

 I've started a gerrit review and I have to add to add some improvements
 due some review observations. How I can include the changes in the same
 gerrit review?

 Thanks

 --
 You received this message because you are subscribed to the Google Groups
 GWT Contributors group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
 To view this discussion on the web visit
 https://groups.google.com/d/msgid/google-web-toolkit-contributors/CA%2BkiFsfGwo0sk_h2S9nTPwNUs6GQsd14Fk0n8uog04bBkwf4dQ%40mail.gmail.com
 https://groups.google.com/d/msgid/google-web-toolkit-contributors/CA%2BkiFsfGwo0sk_h2S9nTPwNUs6GQsd14Fk0n8uog04bBkwf4dQ%40mail.gmail.com?utm_medium=emailutm_source=footer
 .
 For more options, visit https://groups.google.com/d/optout.




-- 
Google Germany GmbH
*Dienerstr. 12*
*80331 München*

Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg
Geschäftsführer: Graham Law, Katherine Stephens

-- 
You received this message because you are subscribed to the Google Groups GWT 
Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/CALLujipqsX8temc_0%2B0MQj2kgppCJE2n67AhFv32tR2P_jeSZA%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


Re: [gwt-contrib] How to include changesets to an existing gerrit review?

2015-03-09 Thread Juan Pablo Gardella
Thanks Daniel!

On 9 March 2015 at 11:55, 'Daniel Kurka' via GWT Contributors 
google-web-toolkit-contributors@googlegroups.com wrote:

 You make the changes in your local git client and amend the commit: 'git
 commit --amend'

 Then you just push to gerrit: 'git push origin HEAD:refs/for/master' and
 this will update the review.

 On Mon, Mar 9, 2015 at 3:49 PM, Juan Pablo Gardella 
 gardellajuanpa...@gmail.com wrote:

 Hi all,

 I've started a gerrit review and I have to add to add some improvements
 due some review observations. How I can include the changes in the same
 gerrit review?

 Thanks

 --
 You received this message because you are subscribed to the Google Groups
 GWT Contributors group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
 To view this discussion on the web visit
 https://groups.google.com/d/msgid/google-web-toolkit-contributors/CA%2BkiFsfGwo0sk_h2S9nTPwNUs6GQsd14Fk0n8uog04bBkwf4dQ%40mail.gmail.com
 https://groups.google.com/d/msgid/google-web-toolkit-contributors/CA%2BkiFsfGwo0sk_h2S9nTPwNUs6GQsd14Fk0n8uog04bBkwf4dQ%40mail.gmail.com?utm_medium=emailutm_source=footer
 .
 For more options, visit https://groups.google.com/d/optout.




 --
 Google Germany GmbH
 *Dienerstr. 12*
 *80331 München*

 Registergericht und -nummer: Hamburg, HRB 86891
 Sitz der Gesellschaft: Hamburg
 Geschäftsführer: Graham Law, Katherine Stephens

 --
 You received this message because you are subscribed to the Google Groups
 GWT Contributors group.
 To unsubscribe from this group and stop receiving emails from it, send an
 email to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
 To view this discussion on the web visit
 https://groups.google.com/d/msgid/google-web-toolkit-contributors/CALLujipqsX8temc_0%2B0MQj2kgppCJE2n67AhFv32tR2P_jeSZA%40mail.gmail.com
 https://groups.google.com/d/msgid/google-web-toolkit-contributors/CALLujipqsX8temc_0%2B0MQj2kgppCJE2n67AhFv32tR2P_jeSZA%40mail.gmail.com?utm_medium=emailutm_source=footer
 .
 For more options, visit https://groups.google.com/d/optout.


-- 
You received this message because you are subscribed to the Google Groups GWT 
Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/CA%2BkiFsehqfVbOaujh7EZJgF1W26ssdHuJTkL6PuFHSgos%2Bivdg%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.


[gwt-contrib] How to include changesets to an existing gerrit review?

2015-03-09 Thread Juan Pablo Gardella
Hi all,

I've started a gerrit review and I have to add to add some improvements due
some review observations. How I can include the changes in the same gerrit
review?

Thanks

-- 
You received this message because you are subscribed to the Google Groups GWT 
Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/google-web-toolkit-contributors/CA%2BkiFsfGwo0sk_h2S9nTPwNUs6GQsd14Fk0n8uog04bBkwf4dQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.