[gwt-contrib] Re: * Soft permutations fail to collapse. Collapse 'derived' properties chain when 'parent' properti... (issue1424803)

2011-04-19 Thread fabiomfv 

http://gwt-code-reviews.appspot.com/1424803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: * Soft permutations fail to collapse. Collapse 'derived' properties chain when 'parent' properti... (issue1424803)

2011-04-19 Thread fabiomfv 


http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java
File dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java
(right):

http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java#newcode45
dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java:45: *
Collapses derived properties.
On 2011/04/18 22:35:35, bobv wrote:

Expand this comment to roughly describe the process implemented for

future

maintainers.


Done.

http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java#newcode52
dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java:52: //
find collapsed properties
On 2011/04/18 22:35:35, bobv wrote:

For each input property, determine if it has a collapsed-value

equivalence set

containing the associated input value.


Done.

http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java#newcode68
dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java:68:
MapString, ArrayListString dependencies = new TreeMapString,
ArrayListString();
On 2011/04/18 22:35:35, bobv wrote:

Make this a MapBindingProperty, ListString.  Add doc: A map of

binding

properties to the names of the properties that must be evaluated prior

to

computing the value of the key object.


Done.

http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java#newcode72
dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java:72: if
(deps.size()  0) {
On 2011/04/18 22:35:35, bobv wrote:

!deps.isEmpty()


Done.

http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java#newcode76
dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java:76: for
(Map.EntryString, ArrayListString e : dependencies.entrySet()) {
On 2011/04/18 22:35:35, bobv wrote:

What is this loop doing?


Done.

http://gwt-code-reviews.appspot.com/1424803/diff/1/user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc
File
user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc
(right):

http://gwt-code-reviews.appspot.com/1424803/diff/1/user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc#newcode26
user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc:26:
permutations into a single compiled unit. As a consequence, collapsed
units
On 2011/04/18 22:35:35, bobv wrote:

into a single output file


Done.

http://gwt-code-reviews.appspot.com/1424803/diff/1/user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc#newcode39
user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc:39:
By default, GWT will collapse permutations of older and less used
browsers.
On 2011/04/18 22:35:35, bobv wrote:

s/GWT/this template/


?

http://gwt-code-reviews.appspot.com/1424803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: * Soft permutations fail to collapse. Collapse 'derived' properties chain when 'parent' properti... (issue1424803)

2011-04-19 Thread fabiomfv 

http://gwt-code-reviews.appspot.com/1424803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: * Soft permutations fail to collapse. Collapse 'derived' properties chain when 'parent' properti... (issue1424803)

2011-04-19 Thread fabiomfv 

http://gwt-code-reviews.appspot.com/1424803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: * Soft permutations fail to collapse. Collapse 'derived' properties chain when 'parent' properti... (issue1424803)

2011-04-18 Thread fabiomfv 

On 2011/04/18 19:09:21, fabiomfv wrote:
ping


http://gwt-code-reviews.appspot.com/1424803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: * Soft permutations fail to collapse. Collapse 'derived' properties chain when 'parent' properti... (issue1424803)

2011-04-18 Thread bobv 

This code needs comments.  I'm having a hard time figuring out what it
does.


http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java
File dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java
(right):

http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java#newcode45
dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java:45: *
Collapses derived properties.
Expand this comment to roughly describe the process implemented for
future maintainers.

http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java#newcode52
dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java:52: //
find collapsed properties
For each input property, determine if it has a collapsed-value
equivalence set containing the associated input value.

http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java#newcode68
dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java:68:
MapString, ArrayListString dependencies = new TreeMapString,
ArrayListString();
Make this a MapBindingProperty, ListString.  Add doc: A map of
binding properties to the names of the properties that must be evaluated
prior to computing the value of the key object.

http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java#newcode72
dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java:72: if
(deps.size()  0) {
!deps.isEmpty()

http://gwt-code-reviews.appspot.com/1424803/diff/1/dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java#newcode76
dev/core/src/com/google/gwt/dev/cfg/PropertyPermutations.java:76: for
(Map.EntryString, ArrayListString e : dependencies.entrySet()) {
What is this loop doing?

http://gwt-code-reviews.appspot.com/1424803/diff/1/user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc
File
user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc
(right):

http://gwt-code-reviews.appspot.com/1424803/diff/1/user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc#newcode26
user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc:26:
permutations into a single compiled unit. As a consequence, collapsed
units
into a single output file

http://gwt-code-reviews.appspot.com/1424803/diff/1/user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc#newcode39
user/src/com/google/gwt/user/tools/templates/sample/_srcFolder_/_moduleFolder_/_moduleShortName_.gwt.xmlsrc:39:
By default, GWT will collapse permutations of older and less used
browsers.
s/GWT/this template/

http://gwt-code-reviews.appspot.com/1424803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors