[gwt-contrib] Re: Allow @def to be retrieved as a String from CssResource

2009-07-02 Thread galgwt . reviews 

I added a test to show that the @ClassName annotation works to
differentiate between an @def and a class name accessor.


http://gwt-code-reviews.appspot.com/50804/diff/1/5
File user/src/com/google/gwt/resources/css/ast/CssVisitor.java (right):

http://gwt-code-reviews.appspot.com/50804/diff/1/5#newcode188
Line 188: e.printStackTrace();
On 2009/06/30 21:00:45, bobv wrote:
> Remove.

Done.

http://gwt-code-reviews.appspot.com/50804/diff/1/6
File user/src/com/google/gwt/resources/rg/CssResourceGenerator.java
(right):

http://gwt-code-reviews.appspot.com/50804/diff/1/6#newcode1739
Line 1739: if
("String".equals(toImplement.getReturnType().getSimpleSourceName())) {
On 2009/06/30 21:00:45, bobv wrote:
> Use JClassType comparison for correctness. This would match
com.foo.String.

Done.

http://gwt-code-reviews.appspot.com/50804/diff/1/6#newcode1740
Line 1740: returnExpr = "\"" + def.getValues().get(0) + "\"";
On 2009/06/30 21:00:45, bobv wrote:
> The value has to be escaped; see the Generator.escape().

Done.

http://gwt-code-reviews.appspot.com/50804/diff/1/6#newcode1790
Line 1790: // TODO(zundel): make conditional on Strict mode?
On 2009/06/30 21:00:45, bobv wrote:
> This condition should always be an error.

Done.

http://gwt-code-reviews.appspot.com/50804/diff/1/4
File user/test/com/google/gwt/resources/client/test.css (right):

http://gwt-code-reviews.appspot.com/50804/diff/1/4#newcode24
Line 24:
On 2009/06/30 21:00:45, bobv wrote:
> Revert.

Done.

http://gwt-code-reviews.appspot.com/50804

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---

[gwt-contrib] Re: Allow @def to be retrieved as a String from CssResource

2009-06-30 Thread bobv 

I think the following scenario should be made to work.


my.css:

@def shadow #abc
.shadow { color: shadow; }


my.java
MyCss implements CssResource {
   String shadow();

   @ClassName("shadow")
   String shadowClass();
}



http://gwt-code-reviews.appspot.com/50804/diff/1/5
File user/src/com/google/gwt/resources/css/ast/CssVisitor.java (right):

http://gwt-code-reviews.appspot.com/50804/diff/1/5#newcode188
Line 188: e.printStackTrace();
Remove.

http://gwt-code-reviews.appspot.com/50804/diff/1/6
File user/src/com/google/gwt/resources/rg/CssResourceGenerator.java
(right):

http://gwt-code-reviews.appspot.com/50804/diff/1/6#newcode1739
Line 1739: if
("String".equals(toImplement.getReturnType().getSimpleSourceName())) {
Use JClassType comparison for correctness. This would match
com.foo.String.

http://gwt-code-reviews.appspot.com/50804/diff/1/6#newcode1740
Line 1740: returnExpr = "\"" + def.getValues().get(0) + "\"";
The value has to be escaped; see the Generator.escape().

http://gwt-code-reviews.appspot.com/50804/diff/1/6#newcode1790
Line 1790: // TODO(zundel): make conditional on Strict mode?
This condition should always be an error.

http://gwt-code-reviews.appspot.com/50804/diff/1/4
File user/test/com/google/gwt/resources/client/test.css (right):

http://gwt-code-reviews.appspot.com/50804/diff/1/4#newcode24
Line 24:
Revert.

http://gwt-code-reviews.appspot.com/50804

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---