[gwt-contrib] Re: Add the option to use JSON rather than GWT RPC in remote logging (issue830802)

[fredsa]

http://gwt-code-reviews.appspot.com/830802/diff/3001/4002
File user/src/com/google/gwt/logging/client/JsonLogRecordClientUtil.java
(right):

http://gwt-code-reviews.appspot.com/830802/diff/3001/4002#newcode27
user/src/com/google/gwt/logging/client/JsonLogRecordClientUtil.java:27:
* A set of functions to convert JSON strings into
SerializableLogRecords.
Swap 1st javadoc sentence with JsonLogRecordServerUtil.java

http://gwt-code-reviews.appspot.com/830802/diff/3001/4003
File user/src/com/google/gwt/logging/server/JsonLogRecordServerUtil.java
(right):

http://gwt-code-reviews.appspot.com/830802/diff/3001/4003#newcode30
user/src/com/google/gwt/logging/server/JsonLogRecordServerUtil.java:30:
* format. The corresponding functions to convert them back are in
I think the 1st sentence of the javadoc on this and the corresponding
client class need to be swapped.

http://gwt-code-reviews.appspot.com/830802/diff/3001/4003#newcode33
user/src/com/google/gwt/logging/server/JsonLogRecordServerUtil.java:33:
public class JsonLogRecordServerUtil {
It might be useful to leave out the 'Server' (and 'Client') bits in the
classname, under the assumption that these two utility classes might be
used in reverse at some point, e.g. in a client app which is able to
pull down a bunch of log records from the server and display them.

http://gwt-code-reviews.appspot.com/830802/diff/3001/4005
File
user/src/com/google/gwt/logging/shared/SerializableStackTraceElement.java
(right):

http://gwt-code-reviews.appspot.com/830802/diff/3001/4005#newcode24
user/src/com/google/gwt/logging/shared/SerializableStackTraceElement.java:24:
public class SerializableStackTraceElement implements IsSerializable {
This class should no longer be needed now that we have
svn/trunk/user/super/com/google/gwt/emul/java/lang/StackTraceElement.java

http://gwt-code-reviews.appspot.com/830802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add the option to use JSON rather than GWT RPC in remote logging (issue830802)

[unnurg]

http://gwt-code-reviews.appspot.com/830802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add the option to use JSON rather than GWT RPC in remote logging (issue830802)

[unnurg]

http://gwt-code-reviews.appspot.com/830802/diff/3001/4002
File user/src/com/google/gwt/logging/client/JsonLogRecordClientUtil.java
(right):

http://gwt-code-reviews.appspot.com/830802/diff/3001/4002#newcode27
user/src/com/google/gwt/logging/client/JsonLogRecordClientUtil.java:27:
* A set of functions to convert JSON strings into
SerializableLogRecords.
On 2010/09/13 18:24:50, fredsa wrote:

Swap 1st javadoc sentence with JsonLogRecordServerUtil.java


Done.

http://gwt-code-reviews.appspot.com/830802/diff/3001/4003
File user/src/com/google/gwt/logging/server/JsonLogRecordServerUtil.java
(right):

http://gwt-code-reviews.appspot.com/830802/diff/3001/4003#newcode30
user/src/com/google/gwt/logging/server/JsonLogRecordServerUtil.java:30:
* format. The corresponding functions to convert them back are in
On 2010/09/13 18:24:50, fredsa wrote:

I think the 1st sentence of the javadoc on this and the corresponding

client

class need to be swapped.


Done.

http://gwt-code-reviews.appspot.com/830802/diff/3001/4003#newcode33
user/src/com/google/gwt/logging/server/JsonLogRecordServerUtil.java:33:
public class JsonLogRecordServerUtil {
On 2010/09/13 18:24:50, fredsa wrote:

It might be useful to leave out the 'Server' (and 'Client') bits in

the

classname, under the assumption that these two utility classes might

be used in

reverse at some point, e.g. in a client app which is able to pull down

a bunch

of log records from the server and display them.


They actually need to be included in the client and server directories
because they include different JSON** files. The ClientUtil includes the
gwt.json.client classes, and the ServerUtil includes org.json classes.
I don't know actually why the json stuff is not done as emulation -
rumor has it that Ray C is working on something along these lines. I
added som comments to the javadoc to explain this

http://gwt-code-reviews.appspot.com/830802/diff/3001/4005
File
user/src/com/google/gwt/logging/shared/SerializableStackTraceElement.java
(right):

http://gwt-code-reviews.appspot.com/830802/diff/3001/4005#newcode24
user/src/com/google/gwt/logging/shared/SerializableStackTraceElement.java:24:
public class SerializableStackTraceElement implements IsSerializable {
On 2010/09/13 18:24:50, fredsa wrote:

This class should no longer be needed now that we have


svn/trunk/user/super/com/google/gwt/emul/java/lang/StackTraceElement.java

Ah right - this is leftover from when I was doing the JSON serialization
differently - reverted.

http://gwt-code-reviews.appspot.com/830802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add the option to use JSON rather than GWT RPC in remote logging (issue830802)

[Fred Sauer]

LGTM

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add the option to use JSON rather than GWT RPC in remote logging (issue830802)

[unnurg]

http://gwt-code-reviews.appspot.com/830802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add the option to use JSON rather than GWT RPC in remote logging (issue830802)

[rjrjr]

Bob, can you take this one?

http://gwt-code-reviews.appspot.com/830802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add the option to use JSON rather than GWT RPC in remote logging (issue830802)

[Unnur Gretarsdottir]

Asking Fred to pick up the 2 logging CL's since they're fairly
independent of vega stuff and you guys sound swamped
- Unnur

On Fri, Sep 10, 2010 at 11:24 AM,  rj...@google.com wrote:
 Bob, can you take this one?

 http://gwt-code-reviews.appspot.com/830802/show


-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors