[gwt-contrib] Re: Added a placeholed for sample/mobilewebapp/war. Required by source target. (issue1451806)

2011-06-01 Thread jlabanca 

LGTM

We should put fortunes in these place holders.

http://gwt-code-reviews.appspot.com/1451806/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Added a placeholed for sample/mobilewebapp/war. Required by source target. (issue1451806)

2011-06-01 Thread rchandia 

[+1!]

Submitted as r10256

On 2011/06/01 19:35:53, jlabanca wrote:

LGTM



We should put fortunes in these place holders.




http://gwt-code-reviews.appspot.com/1451806/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Added a placeholed for sample/mobilewebapp/war. Required by source target. (issue1451806)

2011-06-01 Thread rjrjr 

Sorry, what does this fix?

On 2011/06/01 19:48:02, rchandia wrote:

[+1!]



Submitted as r10256



On 2011/06/01 19:35:53, jlabanca wrote:
 LGTM

 We should put fortunes in these place holders.




http://gwt-code-reviews.appspot.com/1451806/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Added a placeholed for sample/mobilewebapp/war. Required by source target. (issue1451806)

2011-06-01 Thread Rodrigo Chandia 
Fixes ant build breakage.

The source target used for samples/mobilewebapp and  samples/expenses looks
for content in war/. For Expenses, expenses/war/.place-holder fulfills that
requirement. I added the same thing to mobilewebapp to fix the ant build.

A better fix is to test for the existence of a war folder before trying to
copy it. I wanted to fix the build quickly, though.

El 1 de junio de 2011 15:49, rj...@google.com escribió:

 Sorry, what does this fix?


 On 2011/06/01 19:48:02, rchandia wrote:

 [+1!]


  Submitted as r10256


  On 2011/06/01 19:35:53, jlabanca wrote:
  LGTM
 
  We should put fortunes in these place holders.




 http://gwt-code-reviews.appspot.com/1451806/


-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors