[gwt-contrib] Re: DirectInstallLinker should not immediately remove the script tag it has inserted into the IFRAME... (issue1454802)

2011-07-25 Thread fredsa 

Committed in r10293

http://gwt-code-reviews.appspot.com/1454802/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: DirectInstallLinker should not immediately remove the script tag it has inserted into the IFRAME... (issue1454802)

2011-06-07 Thread unnurg 

On 2011/06/07 22:05:56, fredsa wrote:

Tell me more... this is not new - the xsiframe linker does this and we
haven't heard of any problems there...

http://gwt-code-reviews.appspot.com/1454802/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: DirectInstallLinker should not immediately remove the script tag it has inserted into the IFRAME... (issue1454802)

2011-06-07 Thread unnurg 

LGTM

ok - I'm dumb - the file that xsiframe linker is setting the contents of
the script tag and then removing it.  This code sets the src of the
script tag.  Probably not a good idea to remove it before the contents
come back :-)

Thanks!!
- Unnur

On 2011/06/07 22:38:26, unnurg wrote:

On 2011/06/07 22:05:56, fredsa wrote:



Tell me more... this is not new - the xsiframe linker does this and we

haven't

heard of any problems there...




http://gwt-code-reviews.appspot.com/1454802/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors