[gwt-contrib] Re: Enables on the persistent unit cache by default. (issue1448801)

2011-05-13 Thread jbrosenberg 


http://gwt-code-reviews.appspot.com/1448801/diff/1/dev/core/src/com/google/gwt/dev/javac/UnitCacheFactory.java
File dev/core/src/com/google/gwt/dev/javac/UnitCacheFactory.java
(right):

http://gwt-code-reviews.appspot.com/1448801/diff/1/dev/core/src/com/google/gwt/dev/javac/UnitCacheFactory.java#newcode53
dev/core/src/com/google/gwt/dev/javac/UnitCacheFactory.java:53: } else
if (cacheDir == null) {
Shouldn't we offer a useful default for the cacheDir, such as the
java.io.tmpdir property, so that users will be able to take advantage of
caching out of the box, without having to take special effort.

http://gwt-code-reviews.appspot.com/1448801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enables on the persistent unit cache by default. (issue1448801)

2011-05-13 Thread zundel 


http://gwt-code-reviews.appspot.com/1448801/diff/1/dev/core/src/com/google/gwt/dev/javac/UnitCacheFactory.java
File dev/core/src/com/google/gwt/dev/javac/UnitCacheFactory.java
(right):

http://gwt-code-reviews.appspot.com/1448801/diff/1/dev/core/src/com/google/gwt/dev/javac/UnitCacheFactory.java#newcode53
dev/core/src/com/google/gwt/dev/javac/UnitCacheFactory.java:53: } else
if (cacheDir == null) {
On 2011/05/13 17:20:35, jbrosenberg wrote:

Shouldn't we offer a useful default for the cacheDir, such as the

java.io.tmpdir

property, so that users will be able to take advantage of caching out

of the

box, without having to take special effort.


We do offer a sane default, but its hard to offer one here.  The
different entry points GWTShell, DevMode and Compiler offer defaults
based on other settings.

For DevMode and Compiler, it puts it under war/WEB-INF/gwt-unitCache

For GWTShell it puts it under .gwt-tmp/gwt-unitCache

http://gwt-code-reviews.appspot.com/1448801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enables on the persistent unit cache by default. (issue1448801)

2011-05-13 Thread jbrosenberg 

LGTM

http://gwt-code-reviews.appspot.com/1448801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enables on the persistent unit cache by default. (issue1448801)

2011-05-13 Thread tobyr 

LGTM

http://gwt-code-reviews.appspot.com/1448801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enables on the persistent unit cache by default. (issue1448801)

2011-05-12 Thread zundel 

I know the paint is still drying on the last patch I submitted for the
Persistent Unit Cache, but no real problems have been reported in...
weeks!  I think its ready to be on by default.

http://gwt-code-reviews.appspot.com/1448801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enables on the persistent unit cache by default. (issue1448801)

2011-05-12 Thread Scott Blum 
SGTM.  At some point I'll have to deal with versioning for the embedded GWT
ASTs, but I can burn that bridge when I come to it.

On Thu, May 12, 2011 at 6:48 PM, zun...@google.com wrote:

 I know the paint is still drying on the last patch I submitted for the
 Persistent Unit Cache, but no real problems have been reported in...
 weeks!  I think its ready to be on by default.


 http://gwt-code-reviews.appspot.com/1448801/


-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors