[gwt-contrib] Re: Extract violations from being a field in sideEffects to a top-level field. Removed the handling ... (issue846802)

2010-09-13 Thread rjrjr 

LGTM


http://gwt-code-reviews.appspot.com/846802/diff/1/8
File
user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java
(right):

http://gwt-code-reviews.appspot.com/846802/diff/1/8#newcode672
user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:672:
envelop.put(violations, violationsAsJson);
If the RequestData.SIDE_EFFECTS_TOKEN constant is no longer used, please
delete it.

http://gwt-code-reviews.appspot.com/846802/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Extract violations from being a field in sideEffects to a top-level field. Removed the handling ... (issue846802)

2010-09-13 Thread Amit Manjhi 
RequestData.SIDE_EFFECTS_TOKEN is still being used at one place. Commiting
the change.

On Mon, Sep 13, 2010 at 10:03 AM, rj...@google.com wrote:

 LGTM


 http://gwt-code-reviews.appspot.com/846802/diff/1/8
 File

 user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java
 (right):

 http://gwt-code-reviews.appspot.com/846802/diff/1/8#newcode672

 user/src/com/google/gwt/requestfactory/server/JsonRequestProcessor.java:672:
 envelop.put(violations, violationsAsJson);
 If the RequestData.SIDE_EFFECTS_TOKEN constant is no longer used, please
 delete it.


 http://gwt-code-reviews.appspot.com/846802/show


-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors