On 2012/07/26 07:02:08, tbroyer wrote:
I'm not against this kind of change but IMO any deviation from the
JSON and/or
ECMAScript specs should be documented, or we risk removing them at a
later time
and break things again (that being said, I don't understand what's
broken here
and how this CL fixes it wrt JDK 7, as all I see is JavaScript /
client code;
if the issue is that HTMLUnit doesn't follow the specs but rely on
Java's
Unicode support, then it should be documented that this is a
workaround for an
HTMLUnit bug)
Yes, sorry for being unclear. What we know is that
JSONTest.testParseEscaped() fails on JDK7 without this fix. It's
probably a bug in HTMLUnit, but we didn't find the root cause.
However, it seems okay to be conservative when escaping characters in
JSON strings. JSON only requires double quote, control characters, and
backslash to be escaped, but we were already escaping many more
characters than that.
I'll fix the description in the submitted patch.
http://gwt-code-reviews.appspot.com/1796803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
