http://gwt-code-reviews.appspot.com/1817803/diff/1/plugins/xpcom/JavaObject.cpp
File plugins/xpcom/JavaObject.cpp (right):
http://gwt-code-reviews.appspot.com/1817803/diff/1/plugins/xpcom/JavaObject.cpp#newcode385
plugins/xpcom/JavaObject.cpp:385: (JSVAL_IS_PRIMITIVE(argv[1])
!JSVAL_IS_NULL(argv[1]))) {
On 2012/08/25 19:37:18, cromwellian wrote:
I'm curious, why was this change made?
This method can get called either with an object or a null at argv[1].
(A null is handled in the else clause at line 419). I don't know what's
in argv[1] but I'm guessing this might be a static method call? Before I
put this change in, Dev Mode would print an error on and not start up.
About the #ifdef: the JSVAL_IS_OBJECT macro was removed in Firefox 15.
It returned true for either objects or nulls. That's confusing, so I'm
guessing that's why they got rid of it.
See the error in my comment in
http://gwt-code-reviews.appspot.com/1816803/
http://gwt-code-reviews.appspot.com/1817803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
