[gwt-contrib] Re: Fixes a bug in StackTraceDeobfuscator where line numbers from the symbol map were being used in ... (issue1457801)

2011-06-08 Thread fredsa 

LGTM


http://gwt-code-reviews.appspot.com/1457801/diff/4001/user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
File user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
(right):

http://gwt-code-reviews.appspot.com/1457801/diff/4001/user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java#newcode145
user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java:145:
if (lineNumber == -1) {
Sorry, one more thought: I think it would be good to extract -1 into a
static final, say LINE_NUMBER_UNKNOWN, similar what's in
StackTraceCreator.java

http://gwt-code-reviews.appspot.com/1457801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixes a bug in StackTraceDeobfuscator where line numbers from the symbol map were being used in ... (issue1457801)

2011-06-08 Thread ahumesky 

http://gwt-code-reviews.appspot.com/1457801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixes a bug in StackTraceDeobfuscator where line numbers from the symbol map were being used in ... (issue1457801)

2011-06-08 Thread ahumesky 

On 2011/06/08 20:01:41, ahumesky wrote:

Committed in r10297

http://gwt-code-reviews.appspot.com/1457801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors