[gwt-contrib] Re: Improve correctness of UnicodeEscapingTest

2009-07-02 Thread jat 

LGTM other than removing the Safari2 support.


http://gwt-code-reviews.appspot.com/48806/diff/1/3
File user/test/com/google/gwt/user/client/rpc/UnicodeEscapingTest.java
(left):

http://gwt-code-reviews.appspot.com/48806/diff/1/3#oldcode66
Line 66: private static native boolean isSafari2() /*-{
Don't we still need this?  Until we official drop support for Safari2
(and our build doesn't test it), I think we need to keep the test
passing there.

http://gwt-code-reviews.appspot.com/48806

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---

[gwt-contrib] Re: Improve correctness of UnicodeEscapingTest

2009-07-02 Thread jgw 

On 2009/07/02 20:58:49, jat wrote:
 LGTM other than removing the Safari2 support.

 http://gwt-code-reviews.appspot.com/48806/diff/1/3
 File user/test/com/google/gwt/user/client/rpc/UnicodeEscapingTest.java
(left):

 http://gwt-code-reviews.appspot.com/48806/diff/1/3#oldcode66
 Line 66: private static native boolean isSafari2() /*-{
 Don't we still need this?  Until we official drop support for Safari2
(and our
 build doesn't test it), I think we need to keep the test passing
there.

We (and just about everyone else) officially dropped support for Safari
2 some time ago. It was uncontroversial when discussed on gwt-contrib.

http://gwt-code-reviews.appspot.com/48806

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---

[gwt-contrib] Re: Improve correctness of UnicodeEscapingTest

2009-07-02 Thread John Tamplin 
On Thu, Jul 2, 2009 at 5:05 PM, j...@google.com wrote:

 We (and just about everyone else) officially dropped support for Safari
 2 some time ago. It was uncontroversial when discussed on gwt-contrib.


Ok -- Eric misinformed me about still running the Safari2 tests.

In that case, we should remove its associated regex and the webkit version
check that goes with it.

-- 
John A. Tamplin
Software Engineer (GWT), Google

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---

[gwt-contrib] Re: Improve correctness of UnicodeEscapingTest

2009-07-02 Thread bobv 

http://gwt-code-reviews.appspot.com/48806

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---