[gwt-contrib] Re: Introducing a new CellTableBuilder API, which allows users to customize the structure of a CellT... (issue1501803)
committed as r10476 http://gwt-code-reviews.appspot.com/1501803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Re: Introducing a new CellTableBuilder API, which allows users to customize the structure of a CellT... (issue1501803)
For what it's worth, I'd be in favour of the header and footer being decoupled from the columns. We had to home-bake a CellTable equivalent that has a header with multiple rows and cells that span multiple columns Just my 2c. :) On 25 July 2011 17:04, John LaBanca wrote: > The primary reason is that we didn't want to impose the restriction that > all table based implementations of HasDataPresenter contain a header and a > footer consisting of a single header/footer per column. You can imagine a > variation of CellTable that does not include headers, or one that supports > multi-line headers. To be honest though, we (I) may have walked into a > over-design hole. Technically the header/footer is part of the view, but it > probably would have been fine to just include it in the Column. > > > John LaBanca | GWT Software Engineer | jlaba...@google.com > > > > > On Mon, Jul 25, 2011 at 9:44 AM, Jeff Larsen wrote: > >> I had about an hour-hour and a half to play with this over the weekend and >> I have to say it looks great. I have to ask though, is there a reason why >> Column doesn't contain the header and footer cell? It would sure make >> it easier for things like reordering columns, hiding columns. Also it seems >> like the header/footer are a kind of metadata for the column itself. >> Admittedly, there is nothing stopping me from doing this on my own, but it >> seems to me like the header and footer belong to the column itself. What >> edge case haven't I considered? > > > -- > http://groups.google.com/group/Google-Web-Toolkit-Contributors > -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Introducing a new CellTableBuilder API, which allows users to customize the structure of a CellT... (issue1501803)
The primary reason is that we didn't want to impose the restriction that all table based implementations of HasDataPresenter contain a header and a footer consisting of a single header/footer per column. You can imagine a variation of CellTable that does not include headers, or one that supports multi-line headers. To be honest though, we (I) may have walked into a over-design hole. Technically the header/footer is part of the view, but it probably would have been fine to just include it in the Column. John LaBanca | GWT Software Engineer | jlaba...@google.com On Mon, Jul 25, 2011 at 9:44 AM, Jeff Larsen wrote: > I had about an hour-hour and a half to play with this over the weekend and > I have to say it looks great. I have to ask though, is there a reason why > Column doesn't contain the header and footer cell? It would sure make > it easier for things like reordering columns, hiding columns. Also it seems > like the header/footer are a kind of metadata for the column itself. > Admittedly, there is nothing stopping me from doing this on my own, but it > seems to me like the header and footer belong to the column itself. What > edge case haven't I considered? -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Introducing a new CellTableBuilder API, which allows users to customize the structure of a CellT... (issue1501803)
I had about an hour-hour and a half to play with this over the weekend and I have to say it looks great. I have to ask though, is there a reason why Column doesn't contain the header and footer cell? It would sure make it easier for things like reordering columns, hiding columns. Also it seems like the header/footer are a kind of metadata for the column itself. Admittedly, there is nothing stopping me from doing this on my own, but it seems to me like the header and footer belong to the column itself. What edge case haven't I considered? -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
