[gwt-contrib] Re: Issue 6834 Geolocation API Bug (issue1563803)

[rdayal]

Hi Daniel,

Did you sign the GWT CLA? I was about to submit your patch, but I
noticed that you're not on the list..


Rajeev

http://gwt-code-reviews.appspot.com/1563803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Issue 6834 Geolocation API Bug (issue1563803)

[kurka . daniel]

I did sign it when I started this issue.

Should I sign it again

On 2011/12/08 20:33:18, rdayal wrote:

Hi Daniel,



Did you sign the GWT CLA? I was about to submit your patch, but I

noticed that

you're not on the list..




Rajeev




http://gwt-code-reviews.appspot.com/1563803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Issue 6834 Geolocation API Bug (issue1563803)

[kurka . daniel]

fixed indentation

http://gwt-code-reviews.appspot.com/1563803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Issue 6834 Geolocation API Bug (issue1563803)

[rice]

LGTM


http://gwt-code-reviews.appspot.com/1563803/diff/1/user/src/com/google/gwt/geolocation/client/Geolocation.java
File user/src/com/google/gwt/geolocation/client/Geolocation.java
(right):

http://gwt-code-reviews.appspot.com/1563803/diff/1/user/src/com/google/gwt/geolocation/client/Geolocation.java#newcode297
user/src/com/google/gwt/geolocation/client/Geolocation.java:297: var id
= -1;
Fix indentation - don't use tabs

http://gwt-code-reviews.appspot.com/1563803/diff/1/user/src/com/google/gwt/geolocation/client/Geolocation.java#newcode301
user/src/com/google/gwt/geolocation/client/Geolocation.java:301: return
id;
Ditto

http://gwt-code-reviews.appspot.com/1563803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors