[gwt-contrib] Re: More TCK tests (issue1567804)

2011-10-17 Thread nchalko 

On 2011/10/13 18:53:54, Nick Chalko wrote:

ping

http://gwt-code-reviews.appspot.com/1567804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: More TCK tests (issue1567804)

2011-10-17 Thread Ray Ryan 
Missed this, looking now.

On Mon, Oct 17, 2011 at 10:26 AM, ncha...@google.com wrote:

 On 2011/10/13 18:53:54, Nick Chalko wrote:

 ping

 http://gwt-code-reviews.**appspot.com/1567804/http://gwt-code-reviews.appspot.com/1567804/


-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: More TCK tests (issue1567804)

2011-10-17 Thread rjrjr 

LGTM


http://gwt-code-reviews.appspot.com/1567804/diff/1/user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTest.gwt.xml
File
user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTest.gwt.xml
(right):

http://gwt-code-reviews.appspot.com/1567804/diff/1/user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTest.gwt.xml#newcode4
user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTest.gwt.xml:4:
Copyright 2010 Google Inc.
2011. Others?

http://gwt-code-reviews.appspot.com/1567804/diff/1/user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTestValidatorFactory.java
File
user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTestValidatorFactory.java
(right):

http://gwt-code-reviews.appspot.com/1567804/diff/1/user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTestValidatorFactory.java#newcode16
user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTestValidatorFactory.java:16:
package org.hibernate.jsr303.tck.tests.bootstrap.customprovider;
Is it really appropriate for this to be in the org.hibernate space
rather than com.google.gwt?

http://gwt-code-reviews.appspot.com/1567804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: More TCK tests (issue1567804)

2011-10-17 Thread nchalko 


http://gwt-code-reviews.appspot.com/1567804/diff/1/user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTestValidatorFactory.java
File
user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTestValidatorFactory.java
(right):

http://gwt-code-reviews.appspot.com/1567804/diff/1/user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTestValidatorFactory.java#newcode16
user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTestValidatorFactory.java:16:
package org.hibernate.jsr303.tck.tests.bootstrap.customprovider;
On 2011/10/17 20:55:03, rjrjr wrote:

Is it really appropriate for this to be in the org.hibernate space

rather than

com.google.gwt?


This is the same directory as the test.   For some of the tests it was
important to be in the same package.

http://gwt-code-reviews.appspot.com/1567804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: More TCK tests (issue1567804)

2011-10-17 Thread Ray Ryan 
LGTM
On Oct 17, 2011 4:26 PM, ncha...@google.com wrote:


 http://gwt-code-reviews.**appspot.com/1567804/diff/1/**
 user/test/org/hibernate/**jsr303/tck/tests/bootstrap/**customprovider/**
 TckTestValidatorFactory.javahttp://gwt-code-reviews.appspot.com/1567804/diff/1/user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTestValidatorFactory.java
 File
 user/test/org/hibernate/**jsr303/tck/tests/bootstrap/**customprovider/**
 TckTestValidatorFactory.java
 (right):

 http://gwt-code-reviews.**appspot.com/1567804/diff/1/**
 user/test/org/hibernate/**jsr303/tck/tests/bootstrap/**customprovider/**
 TckTestValidatorFactory.java#**newcode16http://gwt-code-reviews.appspot.com/1567804/diff/1/user/test/org/hibernate/jsr303/tck/tests/bootstrap/customprovider/TckTestValidatorFactory.java#newcode16
 user/test/org/hibernate/**jsr303/tck/tests/bootstrap/**customprovider/**
 TckTestValidatorFactory.java:**16:
 package org.hibernate.jsr303.tck.**tests.bootstrap.**customprovider;
 On 2011/10/17 20:55:03, rjrjr wrote:

 Is it really appropriate for this to be in the org.hibernate space

 rather than

 com.google.gwt?


 This is the same directory as the test.   For some of the tests it was
 important to be in the same package.

 http://gwt-code-reviews.**appspot.com/1567804/http://gwt-code-reviews.appspot.com/1567804/


-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors