[gwt-contrib] Re: Need review for more 1.6 WAR changes
John, this is the corresponding change to the Linux binary to support it. BTW: how do we build libstdc++5 compatible binaries these days? --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~--- jni-linux-r4295.patch Description: Binary data
[gwt-contrib] Re: Need review for more 1.6 WAR changes
dev/core/src/com/google/gwt/core/ext/linker/AbstractLinker.java | 7170 +1 - 0 ! What's with the @SuppressWarnings tags? dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java | 20 13 +7 - 0 ! emitSelectionScript(): add a comment to explain logic L233: break string literal dev/core/src/com/google/gwt/core/ext/linker/impl/StandardLinkerContext.java | 18 11 +7 - 0 ! Constructor: That one-liner comment was intended to prevent the reader from wondering when generated artifacts are included in the SLC. produceOutputDirectory(): Should that be a = instead of ? dev/core/src/com/google/gwt/core/linker/IFrameLinker.java | 3632 +4 - 0 ! Extract a URLArtifact type? dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js | 2216 +6 - 0 ! isHostedMode(): Cute. dev/core/src/com/google/gwt/dev/GWTCompiler.java | 2421 +3 - 0 ! dev/core/src/com/google/gwt/dev/GWTShell.java | 2421 +3 - 0 ! Use JavaDoc @deprecated and add a WARN message to indicate that these entrypoints will be removed. dev/core/src/com/google/gwt/dev/HostedMode.java | 168120 + 48 -0 ! link() and relink() have the same JavaDoc comments. Suggest moving the computation of moduleOutDir and moduleExtraDir into a utility function, since this gets repeated in several places. dev/core/src/com/google/gwt/dev/HostedModeBase.java | 8357 +26 -0 ! Document refresh param on loadModule() dev/core/src/com/google/gwt/dev/shell/BrowserWidget.java | 7239 +33 -0 ! Update EXPECTED_GWT_ONLOAD_VERSION? -- Bob Vawter Google Web Toolkit Team --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Need review for more 1.6 WAR changes
On Wed, Dec 10, 2008 at 6:59 PM, John Tamplin [EMAIL PROTECTED] wrote: On Wed, Dec 10, 2008 at 3:51 PM, Scott Blum [EMAIL PROTECTED] wrote: John, this is the corresponding change to the Linux binary to support it. Changing the test for the number of arguments to gwtOnLoad will prevent older hosted.html from working with no possibility of working supporting it in the Java code -- is that what we want to do here? Yes. The two-or-three argument version was transitional from 1.4 to 1.5. I think it's time to remove it now. I haven't tested it, but otherwise LGTM. Thanks! Scott --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Need review for more 1.6 WAR changes
On Wed, Dec 10, 2008 at 6:51 PM, BobV [EMAIL PROTECTED] wrote: dev/core/src/com/google/gwt/core/ext/linker/AbstractLinker.java | 7170 +1 - 0 ! What's with the @SuppressWarnings tags? logger is unused, UnableToComplete not actually thrown. dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java | 20 13 +7 - 0 ! emitSelectionScript(): add a comment to explain logic L233: break string literal Done. dev/core/src/com/google/gwt/core/ext/linker/impl/StandardLinkerContext.java | 18 11 +7 - 0 ! Constructor: That one-liner comment was intended to prevent the reader from wondering when generated artifacts are included in the SLC. produceOutputDirectory(): Should that be a = instead of ? Reverted comment erasure; changed to = dev/core/src/com/google/gwt/core/linker/IFrameLinker.java | 3632 +4 - 0 ! Extract a URLArtifact type? Added a TODO in the spirit of 0, 1, infinity. dev/core/src/com/google/gwt/core/linker/IFrameTemplate.js | 2216 +6 - 0 ! isHostedMode(): Cute. Sorry! I'd prefer not-cute if I could make it as efficient. dev/core/src/com/google/gwt/dev/GWTCompiler.java | 2421 +3 - 0 ! dev/core/src/com/google/gwt/dev/GWTShell.java | 2421 +3 - 0 ! Use JavaDoc @deprecated and add a WARN message to indicate that these entrypoints will be removed. Done, but using stderr. dev/core/src/com/google/gwt/dev/HostedMode.java | 168120 + 48 -0 ! link() and relink() have the same JavaDoc comments. Suggest moving the computation of moduleOutDir and moduleExtraDir into a utility function, since this gets repeated in several places. Fixed; added TODOs to do this later. dev/core/src/com/google/gwt/dev/HostedModeBase.java | 8357 +26 -0 ! Document refresh param on loadModule() Done. dev/core/src/com/google/gwt/dev/shell/BrowserWidget.java | 7239 +33 -0 ! Update EXPECTED_GWT_ONLOAD_VERSION? Good point, fixed. Thanks! Scott --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Need review for more 1.6 WAR changes
On Tue, Dec 9, 2008 at 9:43 PM, Scott Blum [EMAIL PROTECTED] wrote: We deal with this problem now by asserting that hosted mode will generally not overwrite web mode artifacts unless they are newer. For the specific case of the selection script, we give the hosted mode generated selection script the same timestamp as the GWT module that produced it. This means a hosted mode selection script will not overwrite a web mode selection script except when you change the module definition, which should be acceptable. What about if the change was actually in an inherited module? Will it simply continue to use the old selection script until I manually remove it or do a web mode compile? Would it be possible to have them both produce the same selection script so it doesn't matter? -- John A. Tamplin Software Engineer (GWT), Google --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Need review for more 1.6 WAR changes
On Tue, Dec 9, 2008 at 9:48 PM, John Tamplin [EMAIL PROTECTED] wrote: On Tue, Dec 9, 2008 at 9:43 PM, Scott Blum [EMAIL PROTECTED] wrote: We deal with this problem now by asserting that hosted mode will generally not overwrite web mode artifacts unless they are newer. For the specific case of the selection script, we give the hosted mode generated selection script the same timestamp as the GWT module that produced it. This means a hosted mode selection script will not overwrite a web mode selection script except when you change the module definition, which should be acceptable. What about if the change was actually in an inherited module? Will it simply continue to use the old selection script until I manually remove it or do a web mode compile? Changing and inherited module would update the lastModification time on the leaf module, triggering an overwrite. Would it be possible to have them both produce the same selection script so it doesn't matter? In the general case, I can't think of a clean way to do it. You'd have to add some really weird logic to the primary linker. Scott --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
