LGTM.

This is another great change - thanks!


http://gwt-code-reviews.appspot.com/1139801/diff/1/2
File dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
(right):

http://gwt-code-reviews.appspot.com/1139801/diff/1/2#newcode789
dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java:789:
outFile.println("<a name=\"" + filename(className) + "\"></a><h3>" +
className + "</h3>");
Longer than 100 chars?

http://gwt-code-reviews.appspot.com/1139801/diff/1/2#newcode1445
dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java:1445:
String drillDownFileName = classesInPackageFileName(breakdown,
getPermutationId()) + "#" + filename(packageName);
100 chars?

http://gwt-code-reviews.appspot.com/1139801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to