[gwt-contrib] Re: Rework StackTraceDeobfuscator to improve symbol map caching. Users can now specify if they want ... (issue1866803)

2012-11-08 Thread skybrian 

LGTM


http://gwt-code-reviews.appspot.com/1866803/diff/1/user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
File user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
(right):

http://gwt-code-reviews.appspot.com/1866803/diff/1/user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java#newcode245
user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java:245:
if (symbolData != null  !symbolData.isEmpty()) {
FYI: I don't think symbolData can be null anymore, so in theory this if
statement can go away. (Not really worth fixing.)

http://gwt-code-reviews.appspot.com/1866803/diff/1/user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java#newcode353
user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java:353:
private boolean currentlyInCache(String strongName, String symbol) {
I think this is unused.

http://gwt-code-reviews.appspot.com/1866803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Rework StackTraceDeobfuscator to improve symbol map caching. Users can now specify if they want ... (issue1866803)

2012-11-08 Thread skybrian 


http://gwt-code-reviews.appspot.com/1866803/diff/1/user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
File user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java
(right):

http://gwt-code-reviews.appspot.com/1866803/diff/1/user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java#newcode245
user/src/com/google/gwt/logging/server/StackTraceDeobfuscator.java:245:
if (symbolData != null  !symbolData.isEmpty()) {
On 2012/11/08 19:46:22, srogoff wrote:

It can't be null, but it can still be empty (because of how we store

 when we

can't load the data).


Right, but if you split the empty string, you won't get 6 fields so the
next if is sufficient. (Again, doesn't matter, just kibitzing.)

http://gwt-code-reviews.appspot.com/1866803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors