[gwt-contrib] Re: Switch CssResource to strict-by-default mode

2009-10-08 Thread rjrjr 

LGTM

Just nits.


http://gwt-code-reviews.appspot.com/75804/diff/1/3
File user/src/com/google/gwt/resources/client/CssResource.java (right):

http://gwt-code-reviews.appspot.com/75804/diff/1/3#newcode120
Line 120: * The {...@code @external} at-rule can be used in strict mode to
indicate that
did you mean {...@literal @external}? Also, {...@literal @}external works just
fine.

http://gwt-code-reviews.appspot.com/75804/diff/1/5
File user/src/com/google/gwt/resources/rg/CssResourceGenerator.java
(right):

http://gwt-code-reviews.appspot.com/75804/diff/1/5#newcode716
Line 716: @SuppressWarnings(deprecation)
Should comment why this was needed.

http://gwt-code-reviews.appspot.com/75804

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---

[gwt-contrib] Re: Switch CssResource to strict-by-default mode

2009-10-08 Thread rjrjr 

And don't forget to update your wiki pages

http://gwt-code-reviews.appspot.com/75804

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---