[gwt-contrib] Re: TabBar setTabText doesn't set word wrap false

[Emily Crutcher]

Ah, I see, the normal add(String) already sets word-wrap to false.

In that case LGTM.


On Tue, Dec 9, 2008 at 6:05 PM, <[EMAIL PROTECTED]> wrote:

> insertTab(String text, boolean asHTML, int beforeIndex) already disabled
> wordWrap, and we want insertTab() and setTabText() to be consistent.
> setTabText() actually unwraps the text because it replaces the element.
>
> I think its too late to change the fact that we set wordWrap to false in
> insertTab, and I think they should be consistent.  At least now users
> can change the value.
>
>
> http://gwt-code-reviews.appspot.com/604/diff/1/2
> File user/src/com/google/gwt/user/client/ui/TabBar.java (right):
>
> http://gwt-code-reviews.appspot.com/604/diff/1/2#newcode488
> Line 488: focusablePanel.setWidget(new HTML(html, false));
> On 2008/12/09 22:57:55, ecc wrote:
>
>> Why are we disabling word wrap here?
>>
>
> Because its disabled by default in:
> insertTab(String text, boolean asHTML, int beforeIndex);
>
> We want them to be consistent.
>
>
> http://gwt-code-reviews.appspot.com/604
>



-- 
"There are only 10 types of people in the world: Those who understand
binary, and those who don't"

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---

[gwt-contrib] Re: TabBar setTabText doesn't set word wrap false

[jlabanca]

insertTab(String text, boolean asHTML, int beforeIndex) already disabled
wordWrap, and we want insertTab() and setTabText() to be consistent.
setTabText() actually unwraps the text because it replaces the element.

I think its too late to change the fact that we set wordWrap to false in
insertTab, and I think they should be consistent.  At least now users
can change the value.


http://gwt-code-reviews.appspot.com/604/diff/1/2
File user/src/com/google/gwt/user/client/ui/TabBar.java (right):

http://gwt-code-reviews.appspot.com/604/diff/1/2#newcode488
Line 488: focusablePanel.setWidget(new HTML(html, false));
On 2008/12/09 22:57:55, ecc wrote:
> Why are we disabling word wrap here?

Because its disabled by default in:
insertTab(String text, boolean asHTML, int beforeIndex);

We want them to be consistent.

http://gwt-code-reviews.appspot.com/604

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---

[gwt-contrib] Re: TabBar setTabText doesn't set word wrap false

[ecc]

The expansion of the tab interface looks great. Don't quite understand
the change to the default word wrapping...


http://gwt-code-reviews.appspot.com/604/diff/1/2
File user/src/com/google/gwt/user/client/ui/TabBar.java (right):

http://gwt-code-reviews.appspot.com/604/diff/1/2#newcode488
Line 488: focusablePanel.setWidget(new HTML(html, false));
Why are we disabling word wrap here?

http://gwt-code-reviews.appspot.com/604/diff/1/2#newcode507
Line 507: }
See above comment.

http://gwt-code-reviews.appspot.com/604

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---