LGTM
Nice!
On Tue, Sep 6, 2011 at 1:22 PM, rchan...@google.com wrote:
Reviewers: rjrjr, drfibonacci,
Description:
Updates pom.xml to use new Request Factory libraries
Please review this at
http://gwt-code-reviews.**appspot.com/1541803/http://gwt-code-reviews.appspot.com/1541803/
Affected files:
M samples/mobilewebapp/pom.xml
Index: samples/mobilewebapp/pom.xml
==**==**===
--- samples/mobilewebapp/pom.xml(revision 10615)
+++ samples/mobilewebapp/pom.xml(working copy)
@@ -48,10 +48,15 @@
!-- Google Web Toolkit (GWT) itself --
dependency
- groupIdcom.google.gwt/**groupId
- artifactIdgwt-servlet/**artifactId
+ groupIdcom.google.web.**bindery/groupId
+ artifactIdrequestfactory-**server/artifactId
version${gwtVersion}/**version
scoperuntime/scope
+/dependency
+dependency
+ groupIdcom.google.web.**bindery/groupId
+ artifactIdrequestfactory-**apt/artifactId
+ version${gwtVersion}/**version
/dependency
dependency
groupIdcom.google.gwt/**groupId
@@ -75,12 +80,6 @@
/dependency
!-- GWT RequestFactory will use JSR 303 javax.validation if you let it
--
-dependency
- groupIdjavax.validation/**groupId
- artifactIdvalidation-api/**artifactId
- version1.0.0.GA/version
- classifiersources/**classifier
-/dependency
dependency
groupIdorg.hibernate/**groupId
artifactIdhibernate-**validator/artifactId
@@ -97,17 +96,7 @@
/exclusions
/dependency
-!-- GWT RequestFactory requires org.json --
-!-- TODO: can we declare the json and validation dependencies
somewhere for the world to pick up,
-rather than requiring everyone to know about them? --
-dependency
- groupIdorg.json/groupId
- artifactIdjson/artifactId
- version20090211/version
-/dependency
-
!-- Google App Engine (GAE) itself --
-
dependency
groupIdcom.google.appengine**/groupId
artifactIdappengine-api-1.0-**sdk/artifactId
@@ -172,11 +161,11 @@
version1.6.1/version
/dependency
/dependencies
-
+
build
-!-- Generate compiled stuff in the folder used for developing mode
--
+!-- Generate compiled stuff in the folder used for developing mode
--
outputDirectory${project.**build.directory}/${project.**
build.finalName}/WEB-INF/**classes/outputDirectory
-
+
plugins
!-- GWT Maven Plugin--
plugin
@@ -200,7 +189,7 @@
version${gwtVersion}/**version
/dependency
/dependencies
-!-- JS is only needed in the package phase, this speeds up
testing --
+!-- JS is only needed in the package phase, this speeds up
testing --
executions
execution
phaseprepare-package/phase
@@ -209,8 +198,8 @@
/goals
/execution
/executions
-!-- Plugin configuration. There are many available options,
- see gwt-maven-plugin documentation at codehaus.org --
+!-- Plugin configuration. There are many available options,
+ see gwt-maven-plugin documentation at codehaus.org --
configuration
!-- URL that should be automatically opened in the GWT shell
(gwt:run). --
runTargetMobileWebApp.html/**runTarget
@@ -255,7 +244,7 @@
useManifestOnlyJarfalse/**useManifestOnlyJar
forkModealways/forkMode
- !-- Folder for generated testing stuff --
+ !-- Folder for generated testing stuff --
systemProperties
property
namegwt.args/name
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
