[gwt-contrib] Re: changes to hyperlink and Showcase sample (issue74801)

2010-05-14 Thread zundel

close me?


http://gwt-code-reviews.appspot.com/74801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors


[gwt-contrib] Re: changes to hyperlink and Showcase sample

2009-10-01 Thread kprobst

Thanks to both of you!  Committed to branch at r6278.


http://gwt-code-reviews.appspot.com/74801/diff/1002/1006
File
samples/showcase/src/com/google/gwt/sample/showcase/server/CrawlServlet.java
(right):

http://gwt-code-reviews.appspot.com/74801/diff/1002/1006#newcode37
Line 37: * Servlet that makes this application crawlable.
On 2009/09/30 20:48:34, zundel wrote:
 On 2009/09/30 20:38:21, kathrin wrote:
  On 2009/09/30 14:09:43, zundel wrote:
   I don't see anything in here that looks showcase specific.  Is
there a plan
 to
   bundle this up as a library?
 
  Good question.  The plan was to ship a modified app that serves as a
template
  for other applications, and the CrawlServlet would be part of this
sample app.

  How do you think we could bundle this up as a library?

 I dunno, I was just thinking we might include this class in GWT proper
and
 bundle it up along with the gwt-servlet distro.  Then, could anyone
just throw
 it in their web.xml?



This sounds like a good idea.  I'll leave this as a to-do for now until
I figure out where it should best go, etc.

http://gwt-code-reviews.appspot.com/74801/diff/1015/31#newcode45
Line 45: if (i == -1) {
On 2009/09/30 21:01:41, Dan Rice wrote:
 comment

Done.

http://gwt-code-reviews.appspot.com/74801/diff/1015/31#newcode46
Line 46: i = queryStringSb.indexOf(?_escaped_fragment_=);
On 2009/09/30 21:01:41, Dan Rice wrote:
 comment

Done.

http://gwt-code-reviews.appspot.com/74801

--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---