[gwt-contrib] Re: restore GwtEvent.setSource visibility (issue1450801)

[Ray Ryan]

Sneaky. You asked for package protected. I don't want to *expand* the public
foot print.

On Tue, May 17, 2011 at 3:34 PM, stephen.haber...@gmail.com wrote:

 Reviewers: rjrjr,

 Description:
 Redefines Event.setSource in the GwtEvent subclass to restore
 c.g.g.e.shared package visibility.

 Please review this at http://gwt-code-reviews.appspot.com/1450801/

 Affected files:
  user/src/com/google/gwt/event/shared/GwtEvent.java


 Index: user/src/com/google/gwt/event/shared/GwtEvent.java
 ===
 --- user/src/com/google/gwt/event/shared/GwtEvent.java  (revision 10188)
 +++ user/src/com/google/gwt/event/shared/GwtEvent.java  (working copy)
 @@ -101,6 +101,10 @@
 setSource(null);
   }

 +  protected void setSource(Object source) {
 +super.setSource(source);
 +  }
 +
   void overrideSource(Object source) {
 super.setSource(source);
   }




-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: restore GwtEvent.setSource visibility (issue1450801)

[stephen . haberman]

On 2011/05/17 19:40:11, rjrjr wrote:

Sneaky. You asked for package protected. I don't want to *expand* the

public foot print.

Not intended. When making the patch, I just looked at Event.setSource
(which is protected) and copied that.

The thought crossed my mind while submitted the email/patch that I
didn't actually go look at what GwtEvent.setSource's visibility used to
be, although I did blithely write my email saying package private.
And, yeah, it was package private. Fixing.


http://gwt-code-reviews.appspot.com/1450801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors