Re: [gwt-contrib] Removal of IE6/7 specific code from the code base
I've just submitted a shallow removal of IE6 specific code in https://gwt-review.googlesource.com/#/c/9513/ - this patch starts with all .gwt.xml files that mention the user.agent value ie6 and removes those property checks, along with any classes *only* referenced from those rebind rules. Far from a complete job of what remains, but takes another swipe at removing old dead junk. -- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/9c02912b-fd7f-4594-9287-061d166ead8c%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [gwt-contrib] Removal of IE6/7 specific code from the code base
Sorry for being away so long. I will have some time next week to work on this. -- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAAfA4FzE900SfZVU9pVK-0XJ6ccojYubQpohmPYBcTzEJd6c9A%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: [gwt-contrib] Removal of IE6/7 specific code from the code base
There are still 80+ references to IE6 in the code base. Still looking for more patches... On Sat, Jul 12, 2014 at 6:15 AM, Jens jens.nehlme...@gmail.com wrote: Michael, you should track https://gwt-review.googlesource.com/#/c/5304/ so you don't do the same work again. -- J. -- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/6eb89ab9-5109-4658-9dae-95e14072dd3c%40googlegroups.com https://groups.google.com/d/msgid/google-web-toolkit-contributors/6eb89ab9-5109-4658-9dae-95e14072dd3c%40googlegroups.com?utm_medium=emailutm_source=footer . For more options, visit https://groups.google.com/d/optout. -- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA2G8PvQOe2Uguay0YJquojixb89kfbxdTPPv0kMsrXa2w%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
Re: [gwt-contrib] Removal of IE6/7 specific code from the code base
Michael, you should track https://gwt-review.googlesource.com/#/c/5304/ so you don't do the same work again. -- J. -- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/6eb89ab9-5109-4658-9dae-95e14072dd3c%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: [gwt-contrib] Removal of IE6/7 specific code from the code base
I will be offline [1] from tomorrow on, probably until 7/22, but I will have a look at what I can do to remove IE6/7 specific code when this is helpful. Can push to Gerrit on 22nd. Greetings, Michael [1] except a really slow tourist sim internet connection -- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAAfA4FyzVFYH-oVT5p2vrU1nvF6zvFu9ZTau6njPHxiFz_sugA%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
[gwt-contrib] Removal of IE6/7 specific code from the code base
At the end of last year, Daniel started to remove IE6/7 specific code from the SDK and make simplifications based on that; especially for the deferred bindings. We had some progress on it (see some examples [1]) though there are still work to do and looking at our plans it doesn't look like we will able to invest much time into it any time soon. So if you love cleaning up code and making things simpler and also want to be a good GWT citizen, you are highly encouraged to help out :) Please don't forget to attach IE6 topic to your patches as it helps to track them. To find such code, searching the code base with keywords (e.g. IE6. IE7, IE, ActiveX etc) is your best bet. Please always double check that the code or the workaround is only needed for IE6/7. If you encounter cases where the workaround is only required by IE8, please also add a comment for that so we can easily find it when the time comes. I don't know how many people would be interested in this work but just in case to avoid duplicate work, please update this thread after you invest some time into the patch. Cheers, - Goktug [1] https://gwt-review.googlesource.com/#/q/topic:ie6+-status:abandoned -- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/google-web-toolkit-contributors/CAN%3DyUA3qm4of4wTThprE1V%2BpY5oXELm%3DpzDS7WCi3COoh7N5DQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.