Re: [gwt-contrib] Reviewer needed
The mirror scripts are run manually currently, and I'd only been running the svn-git script. I now know how to run the p4-svn script too, so I'll try to keep both of them in sync now. In particular, your commit is now available in Git: https://gwt.googlesource.com/gwt/+/d6d81facb0d08ba6d78e8a7f91c4a6e001f34b34 Sorry for the delay! On Fri, Nov 9, 2012 at 1:19 PM, Daniel Kurka kurka.dan...@gmail.com wrote: Hi Matthew, how often is the mirror script supposed to run, because so far this has not made its way back to svn/git ? -Daniel 2012/11/8 Matthew Dempsky mdemp...@google.com Oops, I thought I already imported that. Apparently not. I'll do that now. On Thu, Nov 8, 2012 at 12:46 PM, Daniel Kurka kurka.dan...@gmail.comwrote: Hi everyone, I still need a reviewer for: https://gwt-review.googlesource.com/#/c/1130/ -Daniel -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Reviewer needed
Hi Matthew, how often is the mirror script supposed to run, because so far this has not made its way back to svn/git ? -Daniel 2012/11/8 Matthew Dempsky mdemp...@google.com Oops, I thought I already imported that. Apparently not. I'll do that now. On Thu, Nov 8, 2012 at 12:46 PM, Daniel Kurka kurka.dan...@gmail.comwrote: Hi everyone, I still need a reviewer for: https://gwt-review.googlesource.com/#/c/1130/ -Daniel -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Reviewer needed
Hi everyone, I still need a reviewer for: https://gwt-review.googlesource.com/#/c/1130/ -Daniel -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Reviewer needed
On Thu, Nov 8, 2012 at 3:46 PM, Daniel Kurka kurka.dan...@gmail.com wrote: Hi everyone, I still need a reviewer for: https://gwt-review.googlesource.com/#/c/1130/ It looks like you need an approver, but I don't know who that can be. Should everyone who is a committer be setup as a reviewer in Gerrit? Also, in Rietveld the mailing list was copied by default on code reviews, can we setup Gerrit the same way? -- John A. Tamplin -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Reviewer needed
you are right I read someone to approve and to pull this into google infrastructure, while we are still on a pull mirror model. -Daniel 2012/11/8 John A. Tamplin j...@jaet.org On Thu, Nov 8, 2012 at 3:46 PM, Daniel Kurka kurka.dan...@gmail.comwrote: Hi everyone, I still need a reviewer for: https://gwt-review.googlesource.com/#/c/1130/ It looks like you need an approver, but I don't know who that can be. Should everyone who is a committer be setup as a reviewer in Gerrit? Also, in Rietveld the mailing list was copied by default on code reviews, can we setup Gerrit the same way? -- John A. Tamplin -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Reviewer needed
Oops, I thought I already imported that. Apparently not. I'll do that now. On Thu, Nov 8, 2012 at 12:46 PM, Daniel Kurka kurka.dan...@gmail.comwrote: Hi everyone, I still need a reviewer for: https://gwt-review.googlesource.com/#/c/1130/ -Daniel -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
