Re: [GRASS-dev] PR workflow fails due to ubuntu-20.04
Hi Vaclav, pá 10. 12. 2021 v 14:52 odesílatel Vaclav Petras napsal: > As for the many jobs for PRs being queued, that's now pretty much standard in > times which seem to be Western hemisphere working hours. I think the 20 > concurrent jobs limit [2] applies to the whole OSGeo org. > > Let me know if this addresses your question or not. Nothing wrong with your > code. The jobs are finished or running at the time of writing this email. correct, I was just not patient :-) Martin -- Martin Landa http://geo.fsv.cvut.cz/gwiki/Landa http://gismentors.cz/mentors/landa ___ grass-dev mailing list grass-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] [release planning] GRASS GIS 8.0.0
Huge +1!!! But... we have 3 blocker PRs: https://github.com/OSGeo/grass/pulls?q=is%3Aopen+is%3Apr+milestone%3A8.0.0+label%3Ablocker - #2011 seems ready to merge I think - #1927 rename gui tabs seems also ready (discussion about changing module -> tool everywhere in the code base should happen in a separate issue/PR) - #1892 utils/mkhtml.py: fix get and set addon manual page source and history URL link <<-- more work required according to Tomas, also it is related to PR #615 in the addons repo So, I believe the last one seems the only one remaining, no? Sorry for spoiling it... I really want to see an RC of GRASS 8 asap too Best, Vero El vie, 10 dic 2021 a las 17:26, Markus Neteler () escribió: > Hi devs, > > All major issues have been tackled and 8.0.0 is due by December 10, > 2021 (hey, that's today!): > https://github.com/OSGeo/grass/milestone/4 > > We have no more blockers: > > https://github.com/OSGeo/grass/issues?q=is%3Aopen+is%3Aissue+label%3Ablocker+milestone%3A8.0.0 > > Hence I would suggest that I create 8.0.0RC1 over the weekend. > > Any objections? > > Best, > Markus > > -- > Markus Neteler, PhD > https://www.mundialis.de - free data with free software > https://grass.osgeo.org > https://courses.neteler.org/blog > ___ > grass-dev mailing list > grass-dev@lists.osgeo.org > https://lists.osgeo.org/mailman/listinfo/grass-dev > ___ grass-dev mailing list grass-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/grass-dev
[GRASS-dev] [release planning] GRASS GIS 8.0.0
Hi devs, All major issues have been tackled and 8.0.0 is due by December 10, 2021 (hey, that's today!): https://github.com/OSGeo/grass/milestone/4 We have no more blockers: https://github.com/OSGeo/grass/issues?q=is%3Aopen+is%3Aissue+label%3Ablocker+milestone%3A8.0.0 Hence I would suggest that I create 8.0.0RC1 over the weekend. Any objections? Best, Markus -- Markus Neteler, PhD https://www.mundialis.de - free data with free software https://grass.osgeo.org https://courses.neteler.org/blog ___ grass-dev mailing list grass-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] help with completing GRASS 8 new features wiki
On Fri, Dec 10, 2021 at 12:41 PM Veronica Andreo wrote: > El jue, 9 dic 2021 a las 23:46, Markus Neteler () escribió: ... >> CHANGELOG creation: >> >> Auto-generated changelog on command line (btw, how to sort the output via >> API?): >> >> gh api repos/OSGeo/grass/releases/generate-notes -f tag_name="8.0.0" >> -f target_commitish=releasebranch_8_0 -q .body > > > What type of sorting do we need? Does it provide the PR number or the hash? > If the number or date, maybe that could help. I have not tested or digged > into it myself so I'm only guessing here This is the current output (massively shortened for here) - note that I added "previous_tag_name=7.8.6" as the point-in-time to start the Changelog: gh api repos/OSGeo/grass/releases/generate-notes -f tag_name="8.0.0" -f previous_tag_name=7.8.6 -f target_commitish=releasebranch_8_0 -q .body ## What's Changed * Needed version updates for GRASS GIS 7.9 by @neteler in https://github.com/OSGeo/grass/pull/77 * change Python shebang to python3 by @neteler in https://github.com/OSGeo/grass/pull/75 * update Python 3 dependencies by @neteler in https://github.com/OSGeo/grass/pull/79 * grass.py: fix typo in info_text, svn -> dev by @landam in https://github.com/OSGeo/grass/pull/78 * change Python shebang to python3 by @neteler in https://github.com/OSGeo/grass/pull/82 * wxGUI: fix 3D view wxPyDeprecationWarning, from https://trac.osgeo.or… by @petrasovaa in https://github.com/OSGeo/grass/pull/81 * i18N: sync from Transifex by @neteler in https://github.com/OSGeo/grass/pull/87 * configure update by @neteler in https://github.com/OSGeo/grass/pull/89 * g.extension: change to python3 by @anikaweinmann in https://github.com/OSGeo/grass/pull/83 * remove now unneeded Python 3 shebang trick by @neteler in https://github.com/OSGeo/grass/pull/90 * r.sun: fix copy paste error when using both lat and lon raster by @petrasovaa in https://github.com/OSGeo/grass/pull/92 ... * v.colors: Fix color inversion by @HuidaeCho in https://github.com/OSGeo/grass/pull/1478 * wxGUI: fix calling coordselect validator by @petrasovaa in https://github.com/OSGeo/grass/pull/1455 * v.random: finished test in reference to #704 by @SunveerSingh in https://github.com/OSGeo/grass/pull/1464 * wxGUI/gcmd: fix read command stdout by @tmszi in https://github.com/OSGeo/grass/pull/1228 * wxGUI: Make Display related toolbars part of Display tab by @lindakladivova in https://github.com/OSGeo/grass/pull/1321 * wxGUI: one row for lmgr toolbar after adding 3D view tab by @lindakladivova in https://github.com/OSGeo/grass/pull/1485 * pythonlib: Fix stylistic Flake8 warnings by @wenzeslaus in https://github.com/OSGeo/grass/pull/1486 ... ## New Contributors * @huhabla made their first contribution in https://github.com/OSGeo/grass/pull/99 * @mlennert made their first contribution in https://github.com/OSGeo/grass/pull/101 * @mankoff made their first contribution in https://github.com/OSGeo/grass/pull/91 * @mwort made their first contribution in https://github.com/OSGeo/grass/pull/85 * @byronbest made their first contribution in https://github.com/OSGeo/grass/pull/113 * @mmacata made their first contribution in https://github.com/OSGeo/grass/pull/151 ... **Full Changelog**: https://github.com/OSGeo/grass/compare/7.8.6...8.0.0 I'd like to see the first PR block sorted by characters, i.e. alphabetically. Then it's easier to transfer it into the topical "blocks" we have in the trac Wiki. This is the documentation: https://cli.github.com/manual/gh_api https://docs.github.com/en/rest/reference/repos#generate-release-notes-content-for-a-release but I don't see how, perhaps a new file '.github/release.yaml' is needed? Markus > > PS: PLEASE always assign a milestone to (new) PRs! ___ grass-dev mailing list grass-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] PR workflow fails due to ubuntu-20.04
On Fri, Dec 10, 2021 at 7:39 AM Martin Landa wrote: > > most of the workflows in my latest PR are queued because of [1]. Any > idea what could be wrong? `ubuntu-20.04` is defined in [2]. > The first link leads me to "Python Flake8 Code Quality" (flake8), but since you are mentioning ubuntu-20.04, that job (although ubuntu-18.04 too) fails with timeout after 6 hours (GitHub job max time). There are some issues with tests that sometimes they get stuck. I was not able to determine the reason from the results. It always seems to be a different test. If someone wants to investigate more or add some time checks to gunittest to mitigate this right there that would be great. I can provide reviews or some other help. Adding a time limit (timeout-minutes [1]) to the job would at least resolve the issue of unnecessary job running. As for the many jobs for PRs being queued, that's now pretty much standard in times which seem to be Western hemisphere working hours. I think the 20 concurrent jobs limit [2] applies to the whole OSGeo org. Let me know if this addresses your question or not. Nothing wrong with your code. The jobs are finished or running at the time of writing this email. Best, Vashek [1] https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#jobsjob_idtimeout-minutes [2] https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration > > Thanks, Martin > > [1] https://github.com/OSGeo/grass/runs/4483450424?check_suite_focus=true > [2] > https://github.com/landam/grass/blob/tgis_bands2semantic_labels/.github/workflows/ubuntu.yml > > -- > Martin Landa > http://geo.fsv.cvut.cz/gwiki/Landa > http://gismentors.cz/mentors/landa > ___ > grass-dev mailing list > grass-dev@lists.osgeo.org > https://lists.osgeo.org/mailman/listinfo/grass-dev > ___ grass-dev mailing list grass-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/grass-dev
[GRASS-dev] PR workflow fails due to ubuntu-20.04
Hi, most of the workflows in my latest PR are queued because of [1]. Any idea what could be wrong? `ubuntu-20.04` is defined in [2]. Thanks, Martin [1] https://github.com/OSGeo/grass/runs/4483450424?check_suite_focus=true [2] https://github.com/landam/grass/blob/tgis_bands2semantic_labels/.github/workflows/ubuntu.yml -- Martin Landa http://geo.fsv.cvut.cz/gwiki/Landa http://gismentors.cz/mentors/landa ___ grass-dev mailing list grass-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] help with completing GRASS 8 new features wiki
El jue, 9 dic 2021 a las 23:46, Markus Neteler () escribió: > On Mon, Nov 29, 2021 at 2:39 AM Vaclav Petras > wrote: > > On Sun, Nov 28, 2021 at 1:06 PM Markus Neteler > wrote: > >> On Wed, Nov 24, 2021 at 2:10 PM Veronica Andreo > wrote: > >> > >> For populating this page I usually use "git log": > ... > > You could also use GitHub CLI to get merged PRs with milestone 8.0.0: > > Ok, I have made a major "milestone" cleanup (some hours of stupid > work, so PLEASE all assign the milestone to their PRs!): > > https://github.com/OSGeo/grass/pulls?q=is%3Apr+no%3Amilestone+is%3Aclosed > gives 0 at time, meaning that each PR has a milestone now assigned. > > I went through 944 unlabeled PRs... :-D > Oh, wow! That's a lot! Thanks Markus!! > > gh pr list --search "milestone:8.0.0" --state merged --limit 100 > > > > This gives 93 PRs. > > Now > - 19 open > - 827 closed > > > Unfortunately, we also have PRs with no milestone which is 919 items: > > > > gh pr list --search "no:milestone" --state merged --limit 100 > > > Now: "No pull requests match your search in OSGeo/grass" :-) > > In my cleanup session, I have created the missing 7.x milestones in > GitHub and assigned the respective PRs to them. See here for the > closed 7.x milestones: > > > https://github.com/OSGeo/grass/milestones?direction=desc=due_date=closed > > (If anyone comes across a wrong assignment, please just fix it right > away by reassigning.) > > Method: Due to the sheer amount of unlabeled PRs I used the > semi-heuristic approach of quick-reading the 944 PR titles and > (ideally) spotting those which I knew they don't belong to 8.x. In > addition, I checked the PR merge date and cross-checked that with the > list of release dates to figure out to which milestone they belong to, > then assigned them accordingly. > > Overall, it looks much better now. > Impressive, thanks again! > > CHANGELOG creation: > > Auto-generated changelog on command line (btw, how to sort the output via > API?): > > gh api repos/OSGeo/grass/releases/generate-notes -f tag_name="8.0.0" > -f target_commitish=releasebranch_8_0 -q .body > What type of sorting do we need? Does it provide the PR number or the hash? If the number or date, maybe that could help. I have not tested or digged into it myself so I'm only guessing here > Alternative (in future use 8.0.0 tag which doesn't exist yet) in the > browser: > https://github.com/OSGeo/grass/compare/7.8.6...releasebranch_8_0 > Doesn't look as nice, but it's an alternative indeed :) Thanks again! Vero PS: PLEASE always assign a milestone to (new) PRs! ___ grass-dev mailing list grass-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/grass-dev
