Re: [GRASS-dev] GRASS Teams on GitHub

2024-03-16 Thread Ondřej Pešek via grass-dev
Hi there,

st 13. 3. 2024 v 1:36 odesílatel Vaclav Petras  napsal:
> On Fri, 8 Mar 2024 at 09:10, Ondřej Pešek  wrote:
>> @Vaclav: Do you have some more points against the master-children
>> schema? It seems that the general agreement is *for* the restructuring
>> into parent and children teams. So far the only point against was "I
>> didn't find team nesting particularly useful and we already had a
>> couple of top-level teams."
>
>
> ...and I didn't see it working for GDAL with people both in the parent team 
> and child teams and repos being assigned to both levels.
>
> How do you suggest we do it? Empty parent team without repos? Would that look 
> good?

According to [1], all the child teams inherit the rights of their
parents. Therefore, I guess that having one empty parent with no
rights is okay and the correct way (also, you can see all children
members there, so it does not "look" empty even if it does not have
any member). Then we could go one of the two ways:
* Having all the current teams as child teams of the master team
* Having it more structured (grass-addons, grass, grass-website/promo)

I prefer the second way (some rights could then be propagated, I
guess) but would appreciate even the first one as it would clean up
the overview a lot.


>> Although I appreciate all the work you
>> dedicate to the GitHub management, I don't think that this is a valid
>> point against when compared to the positive ones (although it's
>> understandable that nobody wants to drop something that they have just
>> created).
> Thanks. It is more that before it was a high priority for me to get access 
> rights in order (access rights to individuals both directly and through 
> teams, inactive people from 2000s and early 2010s grandfathered into GitHub 
> write access, ...). These parent-child teams are low priority compared to 
> that.

Okay, thanks for the explanation. I see the reasoning behind the drop
of the priority and cannot disagree - nobody even seemed to notice
that before. I agree that there are many more important things to do.
Although I still think it would help the situation in the github
teams.

st 13. 3. 2024 v 1:57 odesílatel Even Rouault
 napsal:
> FYI I see this thread referencing the GDAL github team organization. As far 
> as I know, nobody has "designed" it with deep thoughts. It has the current 
> structure most likely as an accident of history... If I were to design it, I 
> would keep it simple and stupid. With git workflows, the concept of 
> "committer" as in SVN era is kinda irrelevant. You just need a sufficient 
> number of people with appropriate push rights to merge the flow of incoming 
> PRs, but if you have more than 10 people with push rights in a single repo, 
> that is already quite big. My 2 cents, and running away as I've no idea how 
> the GRASS team works ;-)

Thanks for the insight, Even. It seems that I am very much on the side
of the accidental structure :-).

[1] 
https://docs.github.com/en/organizations/organizing-members-into-teams/about-teams#nested-teams
___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev


Re: [GRASS-dev] [EXTERNAL] vector patching frustration

2024-03-16 Thread Vincent Bain via grass-dev
Hello Michael,

sorry if I misunderstand your issue, but before patching these two maps
are you sure that each has a set of cat values strictly distinct from
the other? If a vector feature in map A shares the same cat value as
another feature in map B then after patching these features will be
assigned a single record in the attribute table because their cat will
be indentical.

V.


Le samedi 16 mars 2024 à 00:37 +, Michael Barton a écrit :
> I got this to work *finally*. But there are still complications. Here
> is an example work flow:
> 
> 1. Create a map of vector features
> 2. Create a basic attribute table (e.g., with v.db.addtable). 
> 3. Export that table into a csv file using db.out.ogr
> 4. Add some attribute fields to that csv file
> 5. Try to import that csv file using db.in.ogr
> 6. Error: it won't import the cat field
> 7. Edit the csv file to rename cat to mycat
> 8. Try to import the csv file again using db.in.ogr
> 9. If you have not changed the sort order of the csv file, the new
> cat numbers that db.in.ogr automatically assigns (no option about
> this) will match the original cat numbers.
> 10. If cat does not match mycat, no problem because when you connect
> the attribute table to the vector with v.db.connect, you can specify
> mycat as the key field.
> 11. Try to patch this vector with another vector that has the same
> structure of attribute table. *Fail* Because patching creates new cat
> numbers in some order that is not necessarily related to the old
> linkage. The attribute table of the 2nd map is properly added to the
> first attribute table, but the second map is not linked properly to
> the attribute records. 
> 
> In my case, patching updated my non-cat keyfield to the max cat value
> of the original table (154) + the max cat value of the patched table
> (155) = 309. Very odd. This did not match any record. Fortunately,
> because I only have only one vector feature in the 2nd patched map, I
> could edit the cat field in the table (because it was not the key
> field) to match the new cat of the 2nd vector feature, and rejoin the
> table to the vector using cat. If I would have had multiple features
> in the 2nd file, it would have been difficult to impossible. 
> 
> I'm not sure how to fix this. It may need to be a combination of
> allowing various vector modification modules to specify a cat value
> for a feature, assuming no duplication. It may need some change to
> db.in.ogr to allow for importing a field named cat. Maybe more
> changes to patch (and other features that have legacy underlying
> assumptions from the old pre-version6 vector format). 
> 
> Michael
> _
> C. Michael Barton
> Associate Director, School of Complex Adaptive
> Systems (https://scas.asu.edu)
> Professor, School of Human Evolution & Social
> Change (https://shesc.asu.edu)
> Director, Center for Social Dynamics &
> Complexity (https://complexity.asu.edu)
> Arizona State University
> Tempe, AZ 85287-2701
> USA
> 
> Executive Director, Open
> Modeling Foundation (https://openmodelingfoundation.github.io)
> Director, Network for Computational Modeling in Social & Ecological
> Sciences (https://comses.net)
> 
> personal website: http://www.public.asu.edu/~cmbarton 
> 
> 
> > On Mar 15, 2024, at 5:05 PM, Michael Barton
> >  wrote:
> > 
> > Never mind. I figured it out when I saw the post. Now for the next
> > step. 
> > 
> > Michael
> > _
> > C. Michael Barton
> > Associate Director, School of Complex Adaptive
> > Systems (https://scas.asu.edu)
> > Professor, School of Human Evolution & Social
> > Change (https://shesc.asu.edu)
> > Director, Center for Social Dynamics &
> > Complexity (https://complexity.asu.edu)
> > Arizona State University
> > Tempe, AZ 85287-2701
> > USA
> > 
> > Executive Director, Open
> > Modeling Foundation (https://openmodelingfoundation.github.io)
> > Director, Network for Computational Modeling in Social & Ecological
> > Sciences (https://comses.net)
> > 
> > personal website: http://www.public.asu.edu/~cmbarton 
> > 
> > 
> > > On Mar 15, 2024, at 3:29 PM, Michael Barton
> > >  wrote:
> > > 
> > > Something is just not working here. 
> > > 
> > > I can't try the new PR until I can get the original cats fixed.
> > > v.category does not seem to be working as expected. I have a map
> > > with a single area. I clipped it out of another map (where it had
> > > cat=18) using v.select. When I check the categories, it looks
> > > like this:
> > > 
> > > v.category input=SA5@SAA2024 type=centroid option=report 
> > > Layer/table: 1/SA5
> > > type       count        min        max
> > > point          0          0          0
> > > line           0          0          0
> > > boundary       0          0          0
> > > centroid       1         28         28
> > > area           0          0          0
> > > face           0          0          0
> > > kernel         0          0          0
> > > all            1         28