Re: [GRASS-dev] [GRASS GIS] #2278: G__tempfile() lacks perror support
#2278: G__tempfile() lacks perror support
--+-
Reporter: neteler | Owner: grass-dev@…
Type: defect | Status: closed
Priority: normal | Milestone: 7.0.5
Component: LibGIS |Version: svn-releasebranch70
Resolution: fixed| Keywords: r.hants
CPU: Unspecified | Platform: Unspecified
--+-
Changes (by martinl):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"69225" 69225]:
{{{
#!CommitTicketReference repository="" revision="69225"
G__tempfile() lacks perror support (fix #2278, backport r69223 from trunk)
}}}
--
Ticket URL:
GRASS GIS
___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] [GRASS GIS] #2278: G__tempfile() lacks perror support
#2278: G__tempfile() lacks perror support
--+-
Reporter: neteler | Owner: grass-dev@…
Type: defect | Status: new
Priority: normal | Milestone: 7.0.5
Component: LibGIS |Version: svn-releasebranch70
Resolution: | Keywords: r.hants
CPU: Unspecified | Platform: Unspecified
--+-
Comment (by martinl):
In [changeset:"69224" 69224]:
{{{
#!CommitTicketReference repository="" revision="69224"
G__tempfile() lacks perror support (see #2278, backport r69223 from trunk)
}}}
--
Ticket URL:
GRASS GIS
___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] [GRASS GIS] #2278: G__tempfile() lacks perror support
#2278: G__tempfile() lacks perror support
--+-
Reporter: neteler | Owner: grass-dev@…
Type: defect | Status: new
Priority: normal | Milestone: 7.0.5
Component: LibGIS |Version: svn-releasebranch70
Resolution: | Keywords: r.hants
CPU: Unspecified | Platform: Unspecified
--+-
Comment (by martinl):
In [changeset:"69223" 69223]:
{{{
#!CommitTicketReference repository="" revision="69223"
G__tempfile() lacks perror support (see #2278)
}}}
--
Ticket URL:
GRASS GIS
___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] [GRASS GIS] #2278: G__tempfile() lacks perror support
#2278: G__tempfile() lacks perror support -+-- Reporter: neteler | Owner: grass-dev@… Type: defect | Status: new Priority: normal | Milestone: 7.0.0 Component: LibGIS | Version: svn-releasebranch70 Keywords: r.hants |Platform: Unspecified Cpu: Unspecified | -+-- Comment(by neteler): Replying to [comment:1 glynn]: Replying to [ticket:2278 neteler]: For a better error message, perror() should be used: Ideally, strerror() (or similar) should be used, and the string included in the error message. Done by mmetz in r60148 and related. -- Ticket URL: https://trac.osgeo.org/grass/ticket/2278#comment:4 GRASS GIS http://grass.osgeo.org ___ grass-dev mailing list grass-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] [GRASS GIS] #2278: G__tempfile() lacks perror support
#2278: G__tempfile() lacks perror support
-+--
Reporter: neteler | Owner: grass-dev@…
Type: defect | Status: new
Priority: normal | Milestone: 7.0.0
Component: LibGIS | Version: svn-releasebranch70
Keywords: r.hants |Platform: Unspecified
Cpu: Unspecified |
-+--
Comment(by glynn):
Replying to [comment:4 neteler]:
Ideally, strerror() (or similar) should be used, and the string
included in
the error message.
Done by mmetz in r60148 and related.
For robustness, errno should be copied to a local variable immediately
after the failed call, e.g.:
{{{
fcb-null_fd = creat(tempname, 0666);
if (fcb-null_fd 0) {
int err = errno;
...
G_fatal_error(_(No temp files available: %s), strerror(err));
}
}}}
Otherwise, it may be modified by an intervening call (specifically,
close() can modify errno).
--
Ticket URL: https://trac.osgeo.org/grass/ticket/2278#comment:5
GRASS GIS http://grass.osgeo.org
___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] [GRASS GIS] #2278: G__tempfile() lacks perror support
#2278: G__tempfile() lacks perror support -+-- Reporter: neteler | Owner: grass-dev@… Type: defect | Status: new Priority: normal | Milestone: 7.0.0 Component: LibGIS | Version: svn-releasebranch70 Keywords: r.hants |Platform: Unspecified Cpu: Unspecified | -+-- Comment(by glynn): Replying to [ticket:2278 neteler]: For a better error message, perror() should be used: Ideally, strerror() (or similar) should be used, and the string included in the error message. Otherwise, the additional details will be omitted from any logfile ($GIS_ERROR_LOG) or email message ($GRASS_ERROR_MAIL). Except, strerror() isn't thread-safe (it returns a pointer to a static buffer). POSIX.1-2001 specifies strerror_r(), which requires the caller to supply a buffer. Windows doesn't have that, but it has strerror_s (same functionality, different argument order). So we'd need configure checks. -- Ticket URL: http://trac.osgeo.org/grass/ticket/2278#comment:1 GRASS GIS http://grass.osgeo.org ___ grass-dev mailing list grass-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] [GRASS GIS] #2278: G__tempfile() lacks perror support
#2278: G__tempfile() lacks perror support -+-- Reporter: neteler | Owner: grass-dev@… Type: defect | Status: new Priority: normal | Milestone: 7.0.0 Component: LibGIS | Version: svn-releasebranch70 Keywords: r.hants |Platform: Unspecified Cpu: Unspecified | -+-- Comment(by mmetz): Replying to [ticket:2278 neteler]: (The problem arises from r.hants Addon use, reported on grass-user) Using r.hants (derived from r.series) on almost 600 raster maps generates an ERROR: no temp files available on Linux 64bit. r.series with the same number of input maps should fail with the same error. r.hants has been derived from r.series, and both modules have the -z flag (Don't keep files open) which should avoid this problem. -- Ticket URL: https://trac.osgeo.org/grass/ticket/2278#comment:2 GRASS GIS http://grass.osgeo.org ___ grass-dev mailing list grass-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] [GRASS GIS] #2278: G__tempfile() lacks perror support
#2278: G__tempfile() lacks perror support -+-- Reporter: neteler | Owner: grass-dev@… Type: defect | Status: new Priority: normal | Milestone: 7.0.0 Component: LibGIS | Version: svn-releasebranch70 Keywords: r.hants |Platform: Unspecified Cpu: Unspecified | -+-- Comment(by mmetz): Replying to [comment:2 mmetz]: Replying to [ticket:2278 neteler]: (The problem arises from r.hants Addon use, reported on grass-user) Using r.hants (derived from r.series) on almost 600 raster maps generates an ERROR: no temp files available on Linux 64bit. r.series with the same number of input maps should fail with the same error. r.hants has been derived from r.series, and both modules have the -z flag (Don't keep files open) which should avoid this problem. Sorry, the -z flag does not help here because r.hants creates a new output map for each input map, and these need to be kept open. For 600 input maps, the hard limit of the number of open files is usually exceeded. -- Ticket URL: https://trac.osgeo.org/grass/ticket/2278#comment:3 GRASS GIS http://grass.osgeo.org ___ grass-dev mailing list grass-dev@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/grass-dev
