Re: [GRASS-dev] GRASS 8 addons
Hi Vaclav, po 6. 9. 2021 v 3:39 odesílatel Vaclav Petras napsal: > The plan is to create one. You can follow the progress here: > https://github.com/OSGeo/grass-addons/issues/528 > I guess that I should finally clean my glasses. I have tried to check the issues, but I have completely missed this one. Sorry for duplication then. But I can still start one more conversation on GitHub discussions if you want. :-) > I'm waiting with the v8 addon branch for the v8 branch in core or close to > 8.0.0 release. Partially, to avoid people having to make changes to both > addon branches. However, it might be more advantageous at this point to > create the v8 branch in addons since some infrastructure needs to be > updated anyway. (Martin?) > Well, in the issue, there is a note that "The grass7 branch will be superseded by the a branch called grass8 before the 8.0.0 release (likely before branching off release branch for the 8.0 series)". I support that because as far as I understand, the new version of g.extension takes into consideration the current version of GRASS. Therefore, having grass8 branch for addons should not hurt the current behaviour (also we could then get rid of the if statement at [1] that does not seem very self-justifying, at least to me - and it's exactly one of those that gets forgotten in the source code and stays for aeons until nobody knows what it does). We could keep the grass7 branch the default one, start fixing the anticipated bugs, and then just switch the default to grass8. What do you (all) think? We would need to do some cherry-picking meanwhile probably, for those who will not notice such change before grass8 becomes the default branch, but there is not so much traffic in the addons; also, I guess that people working with their own compiled version of GRASS will notice that. Cheers, Ondrej (and sorry for the schisma of splitting the conversation between the mails and the GH issue) [1] https://github.com/OSGeo/grass/blob/main/scripts/g.extension/g.extension.py#L245-L246 ___ grass-dev mailing list grass-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/grass-dev
Re: [GRASS-dev] GRASS 8 addons
Hi Ondrej, On Sat, Sep 4, 2021 at 3:24 AM Ondřej Pešek wrote: > > Currently, there is no GRASS 8 branch in the addons repo. Is there a plan > to create one, or are the changes considered too minor to open a new branch > for that? > The plan is to create one. You can follow the progress here: https://github.com/OSGeo/grass-addons/issues/528 I'm waiting with the v8 addon branch for the v8 branch in core or close to 8.0.0 release. Partially, to avoid people having to make changes to both addon branches. However, it might be more advantageous at this point to create the v8 branch in addons since some infrastructure needs to be updated anyway. (Martin?) > Another solution is having some version checks in the GRASS 7 branch. But > personally, I do not support this idea as it seems weird to me to have an > if statement "if grass.__version__ > 7" in a code that is explicitly > defined as designated for GRASS 7. > I agree that's not ideal, esp. since that can be addressed by the different branches. However, there will be at least some effort to backport changes to Addons from 7 to 8 and having a single version of code may be more practical for some people. So, I think we will leave that decision to individual addon authors. Having said that, a recommended procedure would be nice. Best, Vaclav ___ grass-dev mailing list grass-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/grass-dev
[GRASS-dev] GRASS 8 addons
Hey you lovely devs, In some GRASS modules (e.g. v.db.select), there were certain changes altering their interface between GRASS GIS 7 and the messianic GRASS GIS 8. My question is - how to deal with that in the addons? Currently, there is no GRASS 8 branch in the addons repo. Is there a plan to create one, or are the changes considered too minor to open a new branch for that? These changes probably do not affect a lot of addons, but there are some, and we should approach them minorities with the same solicitude and concernment as we do with the majorities. Another solution is having some version checks in the GRASS 7 branch. But personally, I do not support this idea as it seems weird to me to have an if statement "if grass.__version__ > 7" in a code that is explicitly defined as designated for GRASS 7. Keep that GRASS growing strong, Ondrej ___ grass-dev mailing list grass-dev@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/grass-dev
