[GRASS-dev] trac #637: spaces in path names (wx + tcl)

2009-08-14 Thread Hamish
Hi,

re. stalled bug #637,
  https://trac.osgeo.org/grass/ticket/637#comment:11

I take it the wxGUI use of 'v.db.connect -g' still should explicitly
set the fs='|' and split() on that instead of space?


Also Tcl/Tk versions of same still need attention / testing / 
backporting:

https://trac.osgeo.org/grass/log/grass/branches/develbranch_6/gui/tcltk/gis.m

https://trac.osgeo.org/grass/changeset/38295
https://trac.osgeo.org/grass/changeset/38296
https://trac.osgeo.org/grass/changeset/38426
https://trac.osgeo.org/grass/changeset/38427


and in general C code,
 https://trac.osgeo.org/grass/changeset/38436


... maybe others


thanks,
Hamish
___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev


Re: [GRASS-dev] trac #637: spaces in path names (wx + tcl)

2009-08-14 Thread Glynn Clements

Hamish wrote:

 I take it the wxGUI use of 'v.db.connect -g' still should explicitly
 set the fs='|' and split() on that instead of space?

Yes.

 Also Tcl/Tk versions of same still need attention / testing / 
 backporting:
 
 https://trac.osgeo.org/grass/log/grass/branches/develbranch_6/gui/tcltk/gis.m
 
 https://trac.osgeo.org/grass/changeset/38295
 https://trac.osgeo.org/grass/changeset/38296
 https://trac.osgeo.org/grass/changeset/38426
 https://trac.osgeo.org/grass/changeset/38427
 
 
 and in general C code,
  https://trac.osgeo.org/grass/changeset/38436

The dbmscap fix is in the wrong place. Any quoting should be done
within db_start_driver() (and the Unix version shouldn't be using the
shell; there's no need for it).

More generally, most of those quoting fixes are bogus. The solution is
to use G_spawn() rather than using the shell. Using the shell is a
bug; quoting is just a workaround.

-- 
Glynn Clements gl...@gclements.plus.com
___
grass-dev mailing list
grass-dev@lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/grass-dev