Re: [GRASS-dev] [GRASS GIS] #3607: Removing map layer crashes wxGUI

2020-03-27 Thread GRASS GIS 
#3607: Removing map layer crashes wxGUI
+-
  Reporter:  cmbarton   |  Owner:  grass-dev@…
  Type:  defect | Status:  closed
  Priority:  normal |  Milestone:  7.8.3
 Component:  wxGUI  |Version:  git-releasebranch78
Resolution:  fixed  |   Keywords:  remove layer, layer manager
   CPU:  OSX/Intel  |   Platform:  MacOSX
+-
Changes (by annakrat):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Merged to master and 78.

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3607: Removing map layer crashes wxGUI

2020-03-26 Thread GRASS GIS 
#3607: Removing map layer crashes wxGUI
+-
  Reporter:  cmbarton   |  Owner:  grass-dev@…
  Type:  defect | Status:  new
  Priority:  normal |  Milestone:  7.8.3
 Component:  wxGUI  |Version:  git-releasebranch78
Resolution: |   Keywords:  remove layer, layer manager
   CPU:  OSX/Intel  |   Platform:  MacOSX
+-

Comment (by annakrat):

 Sure: https://github.com/OSGeo/grass/pull/462

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3607: Removing map layer crashes wxGUI

2020-03-26 Thread GRASS GIS 
#3607: Removing map layer crashes wxGUI
+-
  Reporter:  cmbarton   |  Owner:  grass-dev@…
  Type:  defect | Status:  new
  Priority:  normal |  Milestone:  7.8.3
 Component:  wxGUI  |Version:  git-releasebranch78
Resolution: |   Keywords:  remove layer, layer manager
   CPU:  OSX/Intel  |   Platform:  MacOSX
+-

Comment (by nila):

 Replying to [comment:11 annakrat]:
 > Thanks for the detailed analysis. I can't test but this might work:
 >
 >
 > {{{
 > diff --git a/gui/wxpython/lmgr/layertree.py
 b/gui/wxpython/lmgr/layertree.py
 > index 52c20dcc0..b2b39c613 100644
 > --- a/gui/wxpython/lmgr/layertree.py
 > +++ b/gui/wxpython/lmgr/layertree.py
 > @@ -421,7 +421,7 @@ class LayerTree(treemixin.DragAndDrop,
 CT.CustomTreeCtrl):
 >  # select the layer in the same way as right click
 >  if not self.IsSelected(layer):
 >  self.DoSelectItem(layer, True, False)
 > -self.OnLayerContextMenu(event)
 > +wx.CallAfter(self.OnLayerContextMenu, event)
 >
 > }}}

 Brilliant, it works fine, thanks!

 Will you put up a PR?

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3607: Removing map layer crashes wxGUI

2020-03-26 Thread GRASS GIS 
#3607: Removing map layer crashes wxGUI
+-
  Reporter:  cmbarton   |  Owner:  grass-dev@…
  Type:  defect | Status:  new
  Priority:  normal |  Milestone:  7.8.3
 Component:  wxGUI  |Version:  git-releasebranch78
Resolution: |   Keywords:  remove layer, layer manager
   CPU:  OSX/Intel  |   Platform:  MacOSX
+-
Changes (by neteler):

 * version:  7.4.0 => git-releasebranch78
 * milestone:  7.4.5 => 7.8.3


-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3607: Removing map layer crashes wxGUI

2020-03-25 Thread GRASS GIS 
#3607: Removing map layer crashes wxGUI
+-
  Reporter:  cmbarton   |  Owner:  grass-dev@…
  Type:  defect | Status:  new
  Priority:  normal |  Milestone:  7.4.5
 Component:  wxGUI  |Version:  7.4.0
Resolution: |   Keywords:  remove layer, layer manager
   CPU:  OSX/Intel  |   Platform:  MacOSX
+-

Comment (by annakrat):

 Thanks for the detailed analysis. I can't test but this might work:


 {{{
 diff --git a/gui/wxpython/lmgr/layertree.py
 b/gui/wxpython/lmgr/layertree.py
 index 52c20dcc0..b2b39c613 100644
 --- a/gui/wxpython/lmgr/layertree.py
 +++ b/gui/wxpython/lmgr/layertree.py
 @@ -421,7 +421,7 @@ class LayerTree(treemixin.DragAndDrop,
 CT.CustomTreeCtrl):
  # select the layer in the same way as right click
  if not self.IsSelected(layer):
  self.DoSelectItem(layer, True, False)
 -self.OnLayerContextMenu(event)
 +wx.CallAfter(self.OnLayerContextMenu, event)

 }}}

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3607: Removing map layer crashes wxGUI

2020-03-12 Thread GRASS GIS 
#3607: Removing map layer crashes wxGUI
+-
  Reporter:  cmbarton   |  Owner:  grass-dev@…
  Type:  defect | Status:  new
  Priority:  normal |  Milestone:  7.4.5
 Component:  wxGUI  |Version:  7.4.0
Resolution: |   Keywords:  remove layer, layer manager
   CPU:  OSX/Intel  |   Platform:  MacOSX
+-

Comment (by nila):

 I managed to find the cause of this bug (see attachment above). In short:
 1. clicking the button triggers an event with the `GenBitmapButton`
 embedded
 2. the layer (`TreeItem`) is deleted (`GMFrame::OnDeleteLayer()`) and with
 it the included button (the same as in the event)
 3. further event handling (in `wx.lib.buttons.GenButton::OnLeftUp()`)
 deals with a still living python object with a
  "wrapped C/C++ object of type `GenBitmapButton` has been deleted"


 I couldn't find a quick fix for this, but I'll try to come up with a
 solution.
 Still, if someone more experienced is up to the challenge to address this
 I'd be more than happy.

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3607: Removing map layer crashes wxGUI

2020-03-12 Thread GRASS GIS 
#3607: Removing map layer crashes wxGUI
+-
  Reporter:  cmbarton   |  Owner:  grass-dev@…
  Type:  defect | Status:  new
  Priority:  normal |  Milestone:  7.4.5
 Component:  wxGUI  |Version:  7.4.0
Resolution: |   Keywords:  remove layer, layer manager
   CPU:  OSX/Intel  |   Platform:  MacOSX
+-
Changes (by nila):

 * Attachment "3607_debug_log_2020-03-12.txt" added.

 backtrace log up to crash

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3607: Removing map layer crashes wxGUI

2020-03-04 Thread GRASS GIS 
#3607: Removing map layer crashes wxGUI
+-
  Reporter:  cmbarton   |  Owner:  grass-dev@…
  Type:  defect | Status:  new
  Priority:  normal |  Milestone:  7.4.5
 Component:  wxGUI  |Version:  7.4.0
Resolution: |   Keywords:  remove layer, layer manager
   CPU:  OSX/Intel  |   Platform:  MacOSX
+-

Comment (by nila):

 Yes, this only crashes when removing layer from button-menu.

 But **not** from contextual menu (right click), where it works as
 expected.

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3607: Removing map layer crashes wxGUI

2020-03-04 Thread GRASS GIS 
#3607: Removing map layer crashes wxGUI
+-
  Reporter:  cmbarton   |  Owner:  grass-dev@…
  Type:  defect | Status:  new
  Priority:  normal |  Milestone:  7.4.5
 Component:  wxGUI  |Version:  7.4.0
Resolution: |   Keywords:  remove layer, layer manager
   CPU:  OSX/Intel  |   Platform:  MacOSX
+-

Comment (by annakrat):

 Just to make it clear, do you have to press the button to crash, or also
 right click (or whatever you use on mac) would do it as well?

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3607: Removing map layer crashes wxGUI

2020-03-04 Thread GRASS GIS 
#3607: Removing map layer crashes wxGUI
+-
  Reporter:  cmbarton   |  Owner:  grass-dev@…
  Type:  defect | Status:  new
  Priority:  normal |  Milestone:  7.4.5
 Component:  wxGUI  |Version:  7.4.0
Resolution: |   Keywords:  remove layer, layer manager
   CPU:  OSX/Intel  |   Platform:  MacOSX
+-

Comment (by nila):

 This is still an issue with 7.8 branch and master (7.9.dev), with Python
 3.8.2 and wxPython 4.0.7.post2.

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3607: Removing map layer crashes wxGUI

2018-10-02 Thread GRASS GIS 
#3607: Removing map layer crashes wxGUI
+-
  Reporter:  cmbarton   |  Owner:  grass-dev@…
  Type:  defect | Status:  new
  Priority:  normal |  Milestone:  7.4.2
 Component:  wxGUI  |Version:  7.4.0
Resolution: |   Keywords:  remove layer, layer manager
   CPU:  OSX/Intel  |   Platform:  MacOSX
+-

Comment (by cmbarton):

 Every time, but only if removed in this way. All other remove methods work
 fine.

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3607: Removing map layer crashes wxGUI

2018-10-02 Thread GRASS GIS 
#3607: Removing map layer crashes wxGUI
+-
  Reporter:  cmbarton   |  Owner:  grass-dev@…
  Type:  defect | Status:  new
  Priority:  normal |  Milestone:  7.4.2
 Component:  wxGUI  |Version:  7.4.0
Resolution: |   Keywords:  remove layer, layer manager
   CPU:  OSX/Intel  |   Platform:  MacOSX
+-

Comment (by annakrat):

 I can't test myself now, but this seems weird. Does this happen every
 time? Do you have at the same time vector digitizer or 3D view on?

-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev

Re: [GRASS-dev] [GRASS GIS] #3607: Removing map layer crashes wxGUI

2018-10-02 Thread GRASS GIS 
#3607: Removing map layer crashes wxGUI
+-
  Reporter:  cmbarton   |  Owner:  grass-dev@…
  Type:  defect | Status:  new
  Priority:  normal |  Milestone:  7.4.2
 Component:  wxGUI  |Version:  7.4.0
Resolution: |   Keywords:  remove layer, layer manager
   CPU:  OSX/Intel  |   Platform:  MacOSX
+-
Changes (by cmbarton):

 * milestone:   => 7.4.2


-- 
Ticket URL: 
GRASS GIS 

___
grass-dev mailing list
grass-dev@lists.osgeo.org
https://lists.osgeo.org/mailman/listinfo/grass-dev