@ppisati: Would you be able to regression test this on armhf? ** Description changed:
- on openstack rocky-bionic (with patch, see 1771662), xenial guests will - fail to launch as they drop to the busybox prompt after booting. - However, bionic guests will build and launch successfully. + [Impact] + on openstack rocky-bionic (with patch, see 1771662), xenial guests will fail to launch as they drop to the busybox prompt after booting. - Dann F believes this may be related to the xenial image not containing - appropriate acpi modifications. + [Test Case] + Deploy rocky-bionic OpenStack and try to launch a xenial guest. - xenial guest console log: - https://pastebin.canonical.com/p/ntRxFJTvjV/ + [Fix] + Backport ACPI/PCIe support for arm64 from upstream. - xenial virshxml: + [ Regression Risk ] + TLDR: Definitely warrants some regression testing on armhf/arm64, but regression risk seems low for other architectures. Here's a patch-by-patch risk analysis: - https://pastebin.canonical.com/p/cCY4ZVynP7/ + > 0001-UBUNTU-Config-CONFIG_PCI_ECAM-y.patch + Enables code that will be added in the next patch. - bionic virshxml for comparison: + > 0002-PCI-Provide-common-functions-for-ECAM-mapping.patch + Only adds new code w/ no callers yet - https://pastebin.canonical.com/p/MSV3xG7t7g/ + > 0003-PCI-generic-thunder-Use-generic-ECAM-API.patch + As noted in the commit message: + "The patch does not introduce any functional changes other than a very minor one: with the new code, on 64-bit platforms, we do just a single ioremap for the whole config space." - validation: + > 0004-PCI-of-Move-PCI-I-O-space-management-to-PCI-core-cod.patch + As noted, no functional change. - https://pastebin.canonical.com/p/nC9pfSkXVs/ + > 0005-PCI-Move-ecam.h-to-linux-include-pci-ecam.h.patch + As noted, no functional change. + + > 0006-PCI-Add-parent-device-field-to-ECAM-struct-pci_confi.patch + This makes changes to the ecam code, but that was added in this series, so no regression risk there. The pci-thunder-pem changes will be regression tested on the hardware that uses that driver (Cavium ThunderX). + + > 0007-PCI-Add-pci_unmap_iospace-to-unmap-I-O-resources.patch + Only adds new code, w/ no callers yet + + > 0008-PCI-ACPI-Support-I-O-resources-when-parsing-host-bri.patch + Adds and calls a new function that is a no-op on !ARM (PCI_IOBASE is only defined on ARM). Also adds a call to pci_unmap_iospace(), which was added in a previous patch and is also a no-op on !ARM. + + > 0009-UBUNTU-Config-CONFIG_ACPI_MCFG-y.patch + Enables code that will be added in the next patch. + + > 0010-PCI-ACPI-Add-generic-MCFG-table-handling.patch + Adds parsing of a new ACPI table. A possible regression risk to platforms an MCFG table that were working fine w/ 4.4 and there's a latent bug in this parsing code. + + > 0011-PCI-Refactor-pci_bus_assign_domain_nr-for-CONFIG_PCI.patch + As noted, no functional change intended. + + > 0012-PCI-Factor-DT-specific-pci_bus_find_domain_nr-code-o.patch + Again, no functional change. + + > 0013-ARM64-PCI-Add-acpi_pci_bus_find_domain_nr.patch + Only impacts ARM due to CONFIG_PCI_DOMAINS_GENERIC guard + + > 0014-ARM64-PCI-ACPI-support-for-legacy-IRQs-parsing-and-c.patch + arm64-specific PCI initialization code - mitigate risk by regression testing on supported platforms (X-Gene, ThunderX). + + > 0015-ARM64-PCI-Support-ACPI-based-PCI-host-controller.patch + Adds new code for arm64-ACPI support. We didn't previously support these devices, so regression risk is negligible. ** Also affects: linux (Ubuntu Xenial) Importance: Undecided Status: New ** Changed in: linux (Ubuntu Xenial) Status: New => Triaged ** Changed in: linux (Ubuntu Bionic) Status: Triaged => Fix Released ** Changed in: linux (Ubuntu) Status: Triaged => Fix Released ** Changed in: linux (Ubuntu Xenial) Importance: Undecided => High -- You received this bug notification because you are a member of नेपाली भाषा समायोजकहरुको समूह, which is subscribed to Xenial. Matching subscriptions: Ubuntu 16.04 Bugs https://bugs.launchpad.net/bugs/1797092 Title: xenial guest on arm64 drops to busybux under openstack bionic-rocky Status in linux package in Ubuntu: Fix Released Status in linux source package in Xenial: Triaged Status in linux source package in Bionic: Fix Released Bug description: [Impact] on openstack rocky-bionic (with patch, see 1771662), xenial guests will fail to launch as they drop to the busybox prompt after booting. [Test Case] Deploy rocky-bionic OpenStack and try to launch a xenial guest. [Fix] Backport ACPI/PCIe support for arm64 from upstream. [ Regression Risk ] TLDR: Definitely warrants some regression testing on armhf/arm64, but regression risk seems low for other architectures. Here's a patch-by-patch risk analysis: > 0001-UBUNTU-Config-CONFIG_PCI_ECAM-y.patch Enables code that will be added in the next patch. > 0002-PCI-Provide-common-functions-for-ECAM-mapping.patch Only adds new code w/ no callers yet > 0003-PCI-generic-thunder-Use-generic-ECAM-API.patch As noted in the commit message: "The patch does not introduce any functional changes other than a very minor one: with the new code, on 64-bit platforms, we do just a single ioremap for the whole config space." > 0004-PCI-of-Move-PCI-I-O-space-management-to-PCI-core-cod.patch As noted, no functional change. > 0005-PCI-Move-ecam.h-to-linux-include-pci-ecam.h.patch As noted, no functional change. > 0006-PCI-Add-parent-device-field-to-ECAM-struct-pci_confi.patch This makes changes to the ecam code, but that was added in this series, so no regression risk there. The pci-thunder-pem changes will be regression tested on the hardware that uses that driver (Cavium ThunderX). > 0007-PCI-Add-pci_unmap_iospace-to-unmap-I-O-resources.patch Only adds new code, w/ no callers yet > 0008-PCI-ACPI-Support-I-O-resources-when-parsing-host-bri.patch Adds and calls a new function that is a no-op on !ARM (PCI_IOBASE is only defined on ARM). Also adds a call to pci_unmap_iospace(), which was added in a previous patch and is also a no-op on !ARM. > 0009-UBUNTU-Config-CONFIG_ACPI_MCFG-y.patch Enables code that will be added in the next patch. > 0010-PCI-ACPI-Add-generic-MCFG-table-handling.patch Adds parsing of a new ACPI table. A possible regression risk to platforms an MCFG table that were working fine w/ 4.4 and there's a latent bug in this parsing code. > 0011-PCI-Refactor-pci_bus_assign_domain_nr-for-CONFIG_PCI.patch As noted, no functional change intended. > 0012-PCI-Factor-DT-specific-pci_bus_find_domain_nr-code-o.patch Again, no functional change. > 0013-ARM64-PCI-Add-acpi_pci_bus_find_domain_nr.patch Only impacts ARM due to CONFIG_PCI_DOMAINS_GENERIC guard > 0014-ARM64-PCI-ACPI-support-for-legacy-IRQs-parsing-and-c.patch arm64-specific PCI initialization code - mitigate risk by regression testing on supported platforms (X-Gene, ThunderX). > 0015-ARM64-PCI-Support-ACPI-based-PCI-host-controller.patch Adds new code for arm64-ACPI support. We didn't previously support these devices, so regression risk is negligible. To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1797092/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~group.of.nepali.translators Post to : group.of.nepali.translators@lists.launchpad.net Unsubscribe : https://launchpad.net/~group.of.nepali.translators More help : https://help.launchpad.net/ListHelp
