Re: [PATCH] Move normal, serial pci to i386.rmk
Quoting Robert Millan [EMAIL PROTECTED]: This patch moves normal, serial and pci to conf/i386.rmk. Why i386? That code is not i386 specific. Cannot we call it common2 or something like that? I believe we could declare SPARC broken, but keep PowerPC working. The PowerPC code can be cross-compiled and tested in qemu. I can send my testing scripts if you want. Then we could make PowerPC use the new common file. As for SPARC, it would eventually be fixed based on the PowerPC code. -- Regards, Pavel Roskin ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH] Move normal, serial pci to i386.rmk
Pavel Roskin wrote: I believe we could declare SPARC broken, but keep PowerPC working. The PowerPC code can be cross-compiled and tested in qemu. I can send my testing scripts if you want. Can you put that on Wiki? ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH] Move normal, serial pci to i386.rmk
On Mon, Sep 08, 2008 at 10:49:02AM -0400, Pavel Roskin wrote:
Quoting Robert Millan [EMAIL PROTECTED]:
This patch moves normal, serial and pci to conf/i386.rmk.
Why i386? That code is not i386 specific.
It is. Notice it's being moved from conf/i386-*.rmk, not common.rmk.
normal: Includes normal/i386/setjmp.S
serial, pci: Relies on grub_{in,out}{b,w,l} functions, which are only
implemented for i386 so far. Of course, if someone writes the powerpc
stubs, then they could be moved to common.rmk, but they're i386-specific
now.
I believe we could declare SPARC broken, but keep PowerPC working.
Agreed. I suggest we remove the conf/sparc* files, which are burdensome
(since people unaware that SPARC is broken might try to keep them uptodate)
and don't really provide any hard-to-find knowledge, and keep the
kern/*/sparc/* bits which might be useful if/when someone tries to reinstate
the port.
--
Robert Millan
The DRM opt-in fallacy: Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all.
___
Grub-devel mailing list
Grub-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH] Move normal, serial pci to i386.rmk
Robert Millan wrote: On Mon, Sep 08, 2008 at 10:49:02AM -0400, Pavel Roskin wrote: Quoting Robert Millan [EMAIL PROTECTED]: This patch moves normal, serial and pci to conf/i386.rmk. Why i386? That code is not i386 specific. It is. Notice it's being moved from conf/i386-*.rmk, not common.rmk. normal: Includes normal/i386/setjmp.S Should we move this out of normal.mod ? ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
Re: [PATCH] Move normal, serial pci to i386.rmk
On Mon, Sep 08, 2008 at 06:17:34PM +0300, Vesa Jääskeläinen wrote: Robert Millan wrote: On Mon, Sep 08, 2008 at 10:49:02AM -0400, Pavel Roskin wrote: Quoting Robert Millan [EMAIL PROTECTED]: This patch moves normal, serial and pci to conf/i386.rmk. Why i386? That code is not i386 specific. It is. Notice it's being moved from conf/i386-*.rmk, not common.rmk. normal: Includes normal/i386/setjmp.S Should we move this out of normal.mod ? You mean as a standalone module, or to kernel? In a standalone module, we'd still want to have that module in i386.rmk? Then it's basicaly the same issue. And in kernel there's the problem about size... -- Robert Millan The DRM opt-in fallacy: Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all. ___ Grub-devel mailing list Grub-devel@gnu.org http://lists.gnu.org/mailman/listinfo/grub-devel
