Re: arm64/xen: Fix too few arguments to function ‘grub_create_loader_cmdline’

2018-11-21 Thread Lee Jones 
On Wed, 21 Nov 2018, Daniel Kiper wrote:

> On Tue, Nov 20, 2018 at 10:45:04AM +, Lee Jones wrote:
> > From: Lee Jones 
> >
> > arm64/xen: Fix too few arguments to function ‘grub_create_loader_cmdline’
> >
> > Without this fix, building xen_boot.c omits:
> >
> > loader/arm64/xen_boot.c: In function ‘xen_boot_binary_load’:
> > loader/arm64/xen_boot.c:370:7: error: too few arguments to function 
> > ‘grub_create_loader_cmdline’
> >grub_create_loader_cmdline (argc - 1, argv + 1, binary->cmdline,
> >^~
> > In file included from loader/arm64/xen_boot.c:36:0:
> > ../include/grub/lib/cmdline.h:29:12: note: declared here
> >  grub_err_t grub_create_loader_cmdline (int argc, char *argv[], char *buf,
> >
> > Signed-off-by: Lee Jones 
> 
> Pushed despite it had malformed tabs. Next time please use "git format-patch"
> and "git send-email" to build and send the patches.

I normally do this (for my kernel work), but Leif asked me to reply
directly to this mail (since I am not set-up for Grub).

If I continue to contribute, I'll set something up more enduring.

Thank you for your help.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: arm64/xen: Fix too few arguments to function ‘grub_create_loader_cmdline’

2018-11-21 Thread Daniel Kiper 
On Tue, Nov 20, 2018 at 10:45:04AM +, Lee Jones wrote:
> From: Lee Jones 
>
> arm64/xen: Fix too few arguments to function ‘grub_create_loader_cmdline’
>
> Without this fix, building xen_boot.c omits:
>
> loader/arm64/xen_boot.c: In function ‘xen_boot_binary_load’:
> loader/arm64/xen_boot.c:370:7: error: too few arguments to function 
> ‘grub_create_loader_cmdline’
>grub_create_loader_cmdline (argc - 1, argv + 1, binary->cmdline,
>^~
> In file included from loader/arm64/xen_boot.c:36:0:
> ../include/grub/lib/cmdline.h:29:12: note: declared here
>  grub_err_t grub_create_loader_cmdline (int argc, char *argv[], char *buf,
>
> Signed-off-by: Lee Jones 

Pushed despite it had malformed tabs. Next time please use "git format-patch"
and "git send-email" to build and send the patches.

Daniel

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

arm64/xen: Fix too few arguments to function ‘grub_create_loader_cmdline’

2018-11-20 Thread Lee Jones 
From: Lee Jones 

arm64/xen: Fix too few arguments to function ‘grub_create_loader_cmdline’

Without this fix, building xen_boot.c omits:

loader/arm64/xen_boot.c: In function ‘xen_boot_binary_load’:
loader/arm64/xen_boot.c:370:7: error: too few arguments to function 
‘grub_create_loader_cmdline’
   grub_create_loader_cmdline (argc - 1, argv + 1, binary->cmdline,
   ^~
In file included from loader/arm64/xen_boot.c:36:0:
../include/grub/lib/cmdline.h:29:12: note: declared here
 grub_err_t grub_create_loader_cmdline (int argc, char *argv[], char *buf,

Signed-off-by: Lee Jones 

diff --git a/grub-core/loader/arm64/xen_boot.c 
b/grub-core/loader/arm64/xen_boot.c
index 1003a0b99..33a855df4 100644
--- a/grub-core/loader/arm64/xen_boot.c
+++ b/grub-core/loader/arm64/xen_boot.c
@@ -368,7 +368,8 @@ xen_boot_binary_load (struct xen_boot_binary *binary, 
grub_file_t file,
  return;
}
   grub_create_loader_cmdline (argc - 1, argv + 1, binary->cmdline,
- binary->cmdline_size);
+ binary->cmdline_size,
+ GRUB_VERIFY_KERNEL_CMDLINE);
   grub_dprintf ("xen_loader",
"Xen_boot cmdline @ %p %s, size: %d\n",
binary->cmdline, binary->cmdline, binary->cmdline_size);

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

Re: arm64/xen: Fix too few arguments to function ‘grub_create_loader_cmdline’

2018-11-20 Thread Julien Grall 



On 20/11/2018 10:45, Lee Jones wrote:

From: Lee Jones 

arm64/xen: Fix too few arguments to function ‘grub_create_loader_cmdline’
 
Without this fix, building xen_boot.c omits:
 
loader/arm64/xen_boot.c: In function ‘xen_boot_binary_load’:

loader/arm64/xen_boot.c:370:7: error: too few arguments to function 
‘grub_create_loader_cmdline’
grub_create_loader_cmdline (argc - 1, argv + 1, binary->cmdline,
^~
In file included from loader/arm64/xen_boot.c:36:0:
../include/grub/lib/cmdline.h:29:12: note: declared here
  grub_err_t grub_create_loader_cmdline (int argc, char *argv[], char *buf,

Signed-off-by: Lee Jones 


Reviewed-by: Julien Grall 

Cheers,



diff --git a/grub-core/loader/arm64/xen_boot.c 
b/grub-core/loader/arm64/xen_boot.c
index 1003a0b99..33a855df4 100644
--- a/grub-core/loader/arm64/xen_boot.c
+++ b/grub-core/loader/arm64/xen_boot.c
@@ -368,7 +368,8 @@ xen_boot_binary_load (struct xen_boot_binary *binary, 
grub_file_t file,
   return;
 }
grub_create_loader_cmdline (argc - 1, argv + 1, binary->cmdline,
- binary->cmdline_size);
+ binary->cmdline_size,
+ GRUB_VERIFY_KERNEL_CMDLINE);
grub_dprintf ("xen_loader",
 "Xen_boot cmdline @ %p %s, size: %d\n",
 binary->cmdline, binary->cmdline, binary->cmdline_size);



--
Julien Grall

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel