Re: arm64/xen: Remove duplicate check for arguments

2018-11-20 Thread Vladimir 'phcoder' Serbinenko
On Tue, 20 Nov 2018, 14:40 Lee Jones,  wrote:

> From: Lee Jones 
>
> arm64/xen: Remove duplicate check for arguments
>
It's not duplicate because of argc-- right before it

>
> Signed-off-by: Lee Jones 
>
> diff --git a/grub-core/loader/arm64/xen_boot.c
> b/grub-core/loader/arm64/xen_boot.c
> index 1b1dd8c65..5af15c70d 100644
> --- a/grub-core/loader/arm64/xen_boot.c
> +++ b/grub-core/loader/arm64/xen_boot.c
> @@ -404,12 +404,6 @@ grub_cmd_xen_module (grub_command_t cmd
> __attribute__((unused)),
>argc--;
>  }
>
> -  if (!argc)
> -{
> -  grub_error (GRUB_ERR_BAD_ARGUMENT, N_("filename expected"));
> -  goto fail;
> -}
> -
>if (!loaded)
>  {
>grub_error (GRUB_ERR_BAD_ARGUMENT,
>
> ___
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
>
___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel


arm64/xen: Remove duplicate check for arguments

2018-11-20 Thread Lee Jones
From: Lee Jones 

arm64/xen: Remove duplicate check for arguments

Signed-off-by: Lee Jones 

diff --git a/grub-core/loader/arm64/xen_boot.c 
b/grub-core/loader/arm64/xen_boot.c
index 1b1dd8c65..5af15c70d 100644
--- a/grub-core/loader/arm64/xen_boot.c
+++ b/grub-core/loader/arm64/xen_boot.c
@@ -404,12 +404,6 @@ grub_cmd_xen_module (grub_command_t cmd 
__attribute__((unused)),
   argc--;
 }
 
-  if (!argc)
-{
-  grub_error (GRUB_ERR_BAD_ARGUMENT, N_("filename expected"));
-  goto fail;
-}
-
   if (!loaded)
 {
   grub_error (GRUB_ERR_BAD_ARGUMENT,

___
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel