Re: GMemVTable broken

2015-06-27 Thread Philip Withnall
On Sat, 2015-06-27 at 05:38 +0200, Alexander Larsson wrote:
 So, I just tried to use the memory profiler in glib, and I crashes
 really early because the gobject constructor (gobject_init_ctor) 
 calls
 g_malloc before main() is reached.
 
 This means g_mem_set_vtable() is impossible to use. I don't 
 necessarily
 think this is all that bad. Honestly we should never have made it a
 vtable (one extra vfunc per malloc...) and instead do memory 
 profiling
 etc the normal way, i.e. LD_PRELOAD something with malloc
 interceptors. Maybe we should just remove all this code and keep
 g_mem_set_vtable as a dummy function that prints a deprecation 
 warning?

https://bugzilla.gnome.org/show_bug.cgi?id=701694

I think.

signature.asc
Description: This is a digitally signed message part
___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gtk-devel-list


Re: GMemVTable broken

2015-06-27 Thread Alexander Larsson
On Fri, 2015-06-26 at 20:50 -0700, Jasper St. Pierre wrote:
 Yeah, we've all been sort of aware of this for some time. I've abused
 it to the fact where I know that malloc and g_new / free and g_free
 will *always* be the same since a specific glib version.
 
 I think removing all the code is fine.

Patches for this here:
https://bugzilla.gnome.org/show_bug.cgi?id=751592


___
gtk-devel-list mailing list
gtk-devel-list@gnome.org
https://mail.gnome.org/mailman/listinfo/gtk-devel-list