Something I don't understand
I just wondered if someone could help me with something that's puzzling me about a recent Glib commit... On 27th May, Dan Winship made a commit whose description is Add Makefile.glib and GLIB_CONFIG configure macro. According to my Git package (TortoiseGit) it looks as if the following two files got deleted as part of that commit:- gio/gioenumtypes.c.template gio/gioenumtypes.h.template And yet when I look in my gio subfolder, the files are still present and they still seem to get referenced in Glib's makefiles. Initially I assumed they must have gotten added back, sometime later but I can't see any evidence of that. This isn't a criticism BTW - only something that's puzzling me. In fact it's entirely possible that it's some kind of glitch in TortoiseGit but I'm curious to know what would cause the appearance that some files have been removed when (apparently) they're still present and needed. Maybe they did get added back later but I just can't find it? John ___ gtk-devel-list mailing list gtk-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/gtk-devel-list
Re: Something I don't understand
On 31 May 2013, at 09:15, John Emmas wrote: what would cause the appearance that some files have been removed when (apparently) they're still present and needed. Maybe they did get added back later but I just can't find it? Ah, I think maybe the penny just dropped from a closer examination of my commit log it looks like those changes got committed to a different branch (wip/Makefile.glib). i.e. they're not yet committed to master. Does that explain what I'm seeing? John ___ gtk-devel-list mailing list gtk-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/gtk-devel-list
Re: Something I don't understand
On Fri, May 31, 2013 at 09:15:39AM +0100, John Emmas wrote: I just wondered if someone could help me with something that's puzzling me about a recent Glib commit... On 27th May, Dan Winship made a commit whose description is Add Makefile.glib and GLIB_CONFIG configure macro. According to my Git package (TortoiseGit) it looks as if the following two files got deleted as part of that commit:- FWIW I don't see it - do you have the commit ID? Cheers, Patrick ___ gtk-devel-list mailing list gtk-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/gtk-devel-list
回覆: Something I don't understand
Hi John, It does indeed, AFAICT. It seems not unlike the introspection makefiles where people can include so that people simply need to throw into that makefile the files they need to process for the glib-mkenums PERL script. I think this is mainly meant for people using autotools to build their GLib-using project(s), so they don't have to worry too much about calling that script with the correct flags and args. Just my take on this. Sorry if the formatting does not seem nice as I sent this from my phone. With blessings. - 原始郵件 - 寄件者: John Emmas 寄件日期: 2013/5/31 16:55 收件者: gtk-devel-list 主旨: Re: Something I don't understand On 31 May 2013, at 09:15, John Emmas wrote: what would cause the appearance that some files have been removed when (apparently) they're still present and needed. Maybe they did get added back later but I just can't find it? Ah, I think maybe the penny just dropped from a closer examination of my commit log it looks like those changes got committed to a different branch (wip/Makefile.glib). i.e. they're not yet committed to master. Does that explain what I'm seeing? John ___ gtk-devel-list mailing list gtk-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/gtk-devel-list ___ gtk-devel-list mailing list gtk-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/gtk-devel-list
Re: Something I don't understand
On 05/31/2013 05:55 AM, John Emmas wrote: On 31 May 2013, at 09:15, John Emmas wrote: what would cause the appearance that some files have been removed when (apparently) they're still present and needed. Maybe they did get added back later but I just can't find it? Ah, I think maybe the penny just dropped from a closer examination of my commit log it looks like those changes got committed to a different branch (wip/Makefile.glib). i.e. they're not yet committed to master. Does that explain what I'm seeing? Yup. (Makefile.glib is something I'd started working on a long time ago; there's discussion in https://bugzilla.gnome.org/show_bug.cgi?id=654395. I pushed it to git.gnome.org in response to Ryan pushing wip/test-cleanup [https://bugzilla.gnome.org/show_bug.cgi?id=701241]. FTR, after some discussion on IRC, we agreed that we'd go forward with Ryan's branch, and I'd eventually rebase Makefile.glib on top of that, using the cut+paste Makefile approach rather than the installed Makefile approach, since that way it can use automake-level rules, not just make-level ones.) -- Dan ___ gtk-devel-list mailing list gtk-devel-list@gnome.org https://mail.gnome.org/mailman/listinfo/gtk-devel-list
