Re: Import your CK macro into Guile?
Hi, Mark H Weaver m...@netris.org skribis: l...@gnu.org (Ludovic Courtès) writes: Mark H Weaver m...@netris.org skribis: Apologies if I mishandled this, but the problem here is that the code had no explicit license or copying permission notice. If it had been explicitly published as free software, I certainly would not have bothered him about it. There are still two errors in the file: 1. There’s a line “copyright FSF”; 2. The file says to be GPLv3+. Could you fix that by removing the line and stating its actual license? My guess is that Oleg Kiselyov did not bother adding a license boilerplate that would be longer than the actual code, but that’s still a bit embarrassing. Is there an official statement somewhere about its status? As I wrote above, Oleg's code had no explicit license or copying permission notice. I took 15 lines of his code, which is not legally significant according to my reading of the GNU maintainers guile. I then reworked the code to use an auxillary macro instead of the string-literal hack. For that reason I added the FSF copyright. OK, makes sense, since you modified it anyway (I had forgotten that.) It just stroke me when looking at the file to see “copyright FSF” and no copyright line for Oleg; but as you say the copyright line doesn’t mean much here. I then sent Oleg a copy of the file that I proposed for inclusion (with the FSF copyright and the GPLv3+ notice) and asked him if he'd be willing to contribute it to Guile, calling his attention to the attached file. He agreed in a message sent to the guile-devel mailing list. I know, but “would you like to contribute it to Guile” doesn’t mean anything in legal terms. Thanks, Ludo’.
Bug int rtl.scm in wip-rtl
Hi, I just found a bug in rtl.scm, it's triggere by compiling larger rtl codes. In rtl.scm, we have the function (define (link-text-object asm) (let ((buf (make-u32vector (asm-pos asm (let lp ((pos 0) (prev (reverse (asm-prev asm (if (null? prev) (let ((byte-size (* (asm-idx asm) 4))) (bytevector-copy! (asm-cur asm) 0 buf pos byte-size) (unless (eq? (asm-endianness asm) (native-endianness)) (swap-bytes! buf)) (make-object asm '.rtl-text buf (process-relocs buf (asm-relocs asm) (asm-labels asm)) (process-labels (asm-labels asm (let ((len (* *block-size* 4))) (bytevector-copy! (car prev) 0 buf pos len) (lp (+ pos len) (cdr prev))) In thh lp loop I had added reverse in order for the code to emmit the chunks in the right order (the bug was no reverse and we got code emitted in the wrong order) as you can see for smaller codees prev is null and this bug is not triggered. Have fun with rtl, /Stefan
Re: Import your CK macro into Guile?
l...@gnu.org (Ludovic Courtès) writes: Mark H Weaver m...@netris.org skribis: As I wrote above, Oleg's code had no explicit license or copying permission notice. I took 15 lines of his code, which is not legally significant according to my reading of the GNU maintainers guile. I then reworked the code to use an auxillary macro instead of the string-literal hack. For that reason I added the FSF copyright. OK, makes sense, since you modified it anyway (I had forgotten that.) It just stroke me when looking at the file to see “copyright FSF” and no copyright line for Oleg; but as you say the copyright line doesn’t mean much here. I actually did include a copyright line for Oleg, even though none was present on his code. ;;; Copyright (C) 2012 Free Software Foundation, Inc ;;; Copyright (C) 2009, 2011 Oleg Kiselyov 2009 and 2011 are the publication dates of Oleg's code, taken from http://okmij.org/ftp/Scheme/macros.html#ck-macros: dtstrongVersion/strongdt ddThe current version is 1.1, April 2011; original version: March 2009./dd Please let me know if I have acted improperly, and if so, how I should have handled this. Regards, Mark
Re: Import your CK macro into Guile?
Mark H Weaver m...@netris.org skribis: l...@gnu.org (Ludovic Courtès) writes: Mark H Weaver m...@netris.org skribis: As I wrote above, Oleg's code had no explicit license or copying permission notice. I took 15 lines of his code, which is not legally significant according to my reading of the GNU maintainers guile. I then reworked the code to use an auxillary macro instead of the string-literal hack. For that reason I added the FSF copyright. OK, makes sense, since you modified it anyway (I had forgotten that.) It just stroke me when looking at the file to see “copyright FSF” and no copyright line for Oleg; but as you say the copyright line doesn’t mean much here. I actually did include a copyright line for Oleg, even though none was present on his code. ;;; Copyright (C) 2012 Free Software Foundation, Inc ;;; Copyright (C) 2009, 2011 Oleg Kiselyov Oh, right. Please let me know if I have acted improperly, and if so, how I should have handled this. No I guess this is actually the best that can be done. Thanks for bearing with me, Ludo’.
