Re: Unordered finalization, SMOBs, finalizers, and mark functions

2015-03-09 Thread Andy Wingo 
On Wed 04 Mar 2015 11:10, l...@gnu.org (Ludovic Courtès) writes:

 diff --git a/libguile/gc.c b/libguile/gc.c
 index 097cb3d..78999c2 100644
 --- a/libguile/gc.c
 +++ b/libguile/gc.c
 @@ -609,6 +609,7 @@ scm_storage_prehistory ()
target_free_space_divisor = free_space_divisor;
GC_set_free_space_divisor (free_space_divisor);
GC_set_finalize_on_demand (1);
 +  GC_set_java_finalization (1);
  
GC_INIT ();

This is the wrong patch :)  As you can see in scm_init_guardians() we
actually already call this, and the novelty would be to have not-java
finalization.

Andy
-- 
http://wingolog.org/

Re: [PATCH] Exposing the HTTP server constructor and accessors

2015-03-09 Thread Andy Wingo 
On Wed 04 Mar 2015 11:55, l...@gnu.org (Ludovic Courtès) writes:

 Was there any particular reason for not exposing ‘make-server-impl’ et
 al. in (web server)?  If no, I’d like to expose them as well as the
 default implementation.

Sounds fine to me.

A
-- 
http://wingolog.org/

Re: [PATCH] Correct docstring of 'symlink'

2015-03-09 Thread Stefan Monnier 
 - Create a symbolic link named @var{oldpath} with the value\n
 - (i.e., pointing to) @var{newpath}.  The return value is\n
 + Create a symbolic link named @var{newpath} with the value\n
 + (i.e., pointing to) @var{oldpath}.  The return value is\n

This is weird terminology.

First the new vs old is meaningless for a symlink since the target may
not even exist.  In man ln the terminology used is link-name vs
target which I think is a lot more clear (Elisp's `make-symbolic-link'
uses filename vs linkname which is not as good).

Second, the GNU coding standards says:

   Please do not use the term pathname that is used in Unix
   documentation; use file name (two words) instead.  We use the term
   path only for search paths, which are lists of directory names.

so none of the two args should be named somethingpath.


Stefan