Re: [PATCH] Fix minor typos
Thanks Colin and Aleix, This has been committed (856c3f96). Best regards, Mikael On Fri, Dec 2, 2022 at 6:44 PM Aleix Conchillo Flaqué wrote: > On Thu, Dec 1, 2022 at 10:10 PM Colin Woodbury wrote: > >> `make html` should do it. The output is in doc/ref/guile.html/index.html >> >> Yup, that does it. For my future doc improvements I'll make sure to check >> both sides. >> >> So it seems that both the extra period and the superfluous "see" are >> perhaps bugs in Info itself. At least when you open the Guile Guide in >> Emacs, are you able to visually confirm what I'm seeing? >> > Yes, confirmed. I just tried your fix and it looks good both in info and > html. > > LGTM if someone can commit this. > > Aleix >
Re: [PATCH] Fix minor typos
On Thu, Dec 1, 2022 at 10:10 PM Colin Woodbury wrote: > `make html` should do it. The output is in doc/ref/guile.html/index.html > > Yup, that does it. For my future doc improvements I'll make sure to check > both sides. > > So it seems that both the extra period and the superfluous "see" are > perhaps bugs in Info itself. At least when you open the Guile Guide in > Emacs, are you able to visually confirm what I'm seeing? > Yes, confirmed. I just tried your fix and it looks good both in info and html. LGTM if someone can commit this. Aleix
Re: [PATCH] Fix minor typos
`make html` should do it. The output is in doc/ref/guile.html/index.html Yup, that does it. For my future doc improvements I'll make sure to check both sides. So it seems that both the extra period and the superfluous "see" are perhaps bugs in Info itself. At least when you open the Guile Guide in Emacs, are you able to visually confirm what I'm seeing? Colin
Re: [PATCH] Fix minor typos
On Wed, Nov 30, 2022 at 5:04 PM Colin Woodbury wrote: > Hi! > > > On the website this looks OK: > > https://www.gnu.org/software/guile/manual/html_node/Vectors.html > > Did you try to generate the manual in HTML? > > Aleix > > > I didn't (does `make info` do that?); I mainly consume the Guide within > Emacs itself. Interesting also that the "see" bug doesn't appear in the web > version either. > `make html` should do it. The output is in doc/ref/guile.html/index.html Aleix
Re: [PATCH] Fix minor typos
Hi! On the website this looks OK: https://www.gnu.org/software/guile/manual/html_node/Vectors.html Did you try to generate the manual in HTML? Aleix I didn't (does `make info` do that?); I mainly consume the Guide within Emacs itself. Interesting also that the "see" bug doesn't appear in the web version either.
Re: [PATCH] Fix minor typos
Hi! On Wed, Nov 30, 2022 at 5:48 AM Colin Woodbury wrote: > Hi all, this is my first patch to Guile. I have a few more planned, but > figured I'd throw this in first to get my feet wet with the development > process here. > > Detailed comments regarding the typo fixes are included in the patch's > commit message. > > Cheers! > On the website this looks OK: https://www.gnu.org/software/guile/manual/html_node/Vectors.html Did you try to generate the manual in HTML? Aleix