Re: [PATCH 02/24] gnu: Add ghc-paths.

2015-04-08 Thread Ludovic Courtès
Federico Beffa be...@ieee.org skribis:

 On Wed, Apr 8, 2015 at 10:01 AM, Ludovic Courtès l...@gnu.org wrote:
 +(synopsis
 + Knowledge of GHC's installation directories)
 +(description
 + Knowledge of GHC's installation directories.)

 Please expound a little bit.  Otherwise OK.

 Thanks for reviewing all of these!

 The problem with this and some other libraries is that the library
 doesn't have an official home-page (apart from a source repository
 which doesn't include anything other than the source). The description
 is taken one-to-one from the Cabal file and I don't really know how I
 can expand the description.

Often there’s a README or manual that gives a better overview, but yeah,
I don’t mean that you should spend another 10 hours on this.  ;-)  So if
you find a paragraph that’s clearer, that’s nice, otherwise it’s OK.

 The Cabal file of some other libraries like, e.g., ghc-network, give
 an, IMO, too detailed description (sometimes even with a code
 snippet):

Agreed, something like this one is overly detailed.

Ludo’.



Re: [PATCH 19/24] gnu: Add ghc-parsec.

2015-04-08 Thread Ludovic Courtès
Federico Beffa be...@ieee.org skribis:

 From 51556b2660b23a6d6448922acfd152ea7a70a1d2 Mon Sep 17 00:00:00 2001
 From: Federico Beffa be...@fbengineering.ch
 Date: Fri, 27 Mar 2015 18:30:06 +0100
 Subject: [PATCH 19/24] gnu: Add ghc-parsec.

 * gnu/packages/haskell.scm (ghc-parsec): New variable.

[...]

 +(description Parsec is designed from scratch as an industrial-strength
 +parser library.  It is simple, safe, well documented (on the package
 +homepage), has extensive libraries, good error messages, and is fast.  It is

I would remove “industrial-strength” and “(on the package homepage)”.

Otherwise OK.

Ludo’.



Re: cannot fetch narinfo with HTTP pipelining

2015-04-08 Thread Ludovic Courtès
Ricardo Wurmus ricardo.wur...@mdc-berlin.de skribis:

 The numbers in the `bad-response' error message differ for different
 operations.  In all cases the first number (here 403) is larger than the
 second (here 15).  The second number is the reported content length.

That rings a bell.

Could you try this patch?

diff --git a/guix/http-client.scm b/guix/http-client.scm
index 051fcee..abd9e64 100644
--- a/guix/http-client.scm
+++ b/guix/http-client.scm
@@ -135,6 +135,47 @@ closed it will also close PORT, unless the KEEP-ALIVE? is true.
  (when (module-variable %web-http 'read-chunk-body)
(module-set! %web-http 'make-chunked-input-port make-chunked-input-port))
 
+ (define (make-delimited-input-port port len keep-alive?)
+   Return an input port that reads from PORT, and makes sure that
+exactly LEN bytes are available from PORT.  Closing the returned port
+closes PORT, unless KEEP-ALIVE? is true.
+   (define bytes-read 0)
+
+   (define (fail)
+ ((@@ (web response) bad-response)
+  EOF while reading response body: ~a bytes of ~a
+  bytes-read len))
+
+   (define (read! bv start count)
+ ;; Read at most LEN bytes in total.  HTTP/1.1 doesn't say what to do
+ ;; when a server provides more than the Content-Length, but it seems
+ ;; wise to just stop reading at LEN.
+ (let ((count (min count (- len bytes-read
+   (let loop ((ret (get-bytevector-n! port bv start count)))
+ (cond ((eof-object? ret)
+(if (= bytes-read len)
+0  ; EOF
+(fail)))
+   ((and (zero? ret) ( count 0))
+;; Do not return zero since zero means EOF, so try again.
+(loop (get-bytevector-n! port bv start count)))
+   (else
+(set! bytes-read (+ bytes-read ret))
+ret)
+
+   (define close
+ (and (not keep-alive?)
+  (lambda ()
+(close port
+
+   (make-custom-binary-input-port delimited input port read! #f #f close))
+
+ (unless (guile-version? 2.0.9)
+   ;; Guile = 2.0.9 had a bug whereby 'response-body-port' would read more
+   ;; than what 'content-length' says.  See Guile commit 802a25b.
+   (module-set! (resolve-interface '(web response))
+'make-delimited-input-port make-delimited-input-port))
+
  (define (read-response-body* r)
Reads the response body from @var{r}, as a bytevector.  Returns
  @code{#f} if there was no response body.

Anyone using Guile  2.0.11 is welcome to test this and report success
or failure!

Thanks,
Ludo’.


Re: cannot fetch narinfo with HTTP pipelining

2015-04-08 Thread Ricardo Wurmus

Ludovic Courtès writes:

 Ricardo Wurmus ricardo.wur...@mdc-berlin.de skribis:

 The numbers in the `bad-response' error message differ for different
 operations.  In all cases the first number (here 403) is larger than the
 second (here 15).  The second number is the reported content length.

 That rings a bell.

 Could you try this patch?

Thanks for the patch.  Unfortunately, guix fails to compile with the
patch applied:

~
[rwurmus@guix-builder:/localhome/rwurmus-tmp/guix] (621) $ make
make  all-recursive
make[1]: Entering directory `/localhome/rwurmus-tmp/guix'
Making all in po/guix
make[2]: Entering directory `/localhome/rwurmus-tmp/guix/po/guix'
make[2]: Leaving directory `/localhome/rwurmus-tmp/guix/po/guix'
Making all in po/packages
make[2]: Entering directory `/localhome/rwurmus-tmp/guix/po/packages'
make[2]: Leaving directory `/localhome/rwurmus-tmp/guix/po/packages'
make[2]: Entering directory `/localhome/rwurmus-tmp/guix'
/usr/bin/mkdir -p `dirname guix/gnu-maintenance.go` ; \
unset GUILE_LOAD_COMPILED_PATH ;\
LC_ALL=C\
./pre-inst-env  \
/usr/bin/guild compile -L . -L .\
  -Wformat -Wunbound-variable -Warity-mismatch  \
  --target=x86_64-unknown-linux-gnu   
\
  -o guix/gnu-maintenance.go guix/gnu-maintenance.scm
;;; note: source file ./guix/http-client.scm
;;;   newer than compiled 
/home/rwurmus/.cache/guile/ccache/2.0-LE-8-2.0/localhome/rwurmus-tmp/guix/guix/http-client.scm.go
Backtrace:
In system/base/compile.scm:
 216: 19 [read-and-compile #input: guix/gnu-maintenance.scm 5 #:from ...]
 232: 18 [lp () #f #module (#{ g114}#) ca1d80]
 180: 17 [lp (#procedure compile-tree-il (x e opts)) (define-module # # ...) 
...]
In ice-9/boot-9.scm:
2320: 16 [save-module-excursion #procedure e509f0 at 
language/scheme/compile-tree-il.scm:29:3 ()]
In language/scheme/compile-tree-il.scm:
  31: 15 [#procedure e509f0 at language/scheme/compile-tree-il.scm:29:3 ()]
In ice-9/psyntax.scm:
1091: 14 [expand-top-sequence ((define-module # # # ...)) () ((top)) ...]
 976: 13 [scan ((define-module (guix gnu-maintenance) #:use-module ...)) () ...]
 270: 12 [scan ((#(syntax-object let # ...) (#) (# #) ...)) () ...]
In ice-9/eval.scm:
 411: 11 [eval # ()]
In ice-9/boot-9.scm:
2870: 10 [define-module* (guix gnu-maintenance) #:filename ...]
2845: 9 [resolve-imports (((web uri)) ((web client)) ((web response)) ...)]
2783: 8 [resolve-interface (guix http-client) #:select ...]
2708: 7 [#procedure 9a7440 at ice-9/boot-9.scm:2696:4 (name #:optional 
autoload version #:key ensure) # ...]
2981: 6 [try-module-autoload (guix http-client) #f]
2320: 5 [save-module-excursion #procedure fb3510 at ice-9/boot-9.scm:2982:17 
()]
3001: 4 [#procedure fb3510 at ice-9/boot-9.scm:2982:17 ()]
In unknown file:
   ?: 3 [primitive-load-path guix/http-client ...]
In ice-9/eval.scm:
 432: 2 [eval # ()]
In unknown file:
   ?: 1 [scm-error misc-error #f ...]
In ice-9/boot-9.scm:
 106: 0 [#procedure bde140 at ice-9/boot-9.scm:97:6 (thrown-k . args) 
misc-error ...]

ice-9/boot-9.scm:106:20: In procedure #procedure bde140 at 
ice-9/boot-9.scm:97:6 (thrown-k . args):
ice-9/boot-9.scm:106:20: No variable named make-delimited-input-port in 
#interface (web response) f9bd80
make[2]: *** [guix/gnu-maintenance.go] Error 1
make[2]: Leaving directory `/localhome/rwurmus-tmp/guix'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/localhome/rwurmus-tmp/guix'
make: *** [all] Error 2
~


That's odd because:

~
[rwurmus@guix-builder:/localhome/rwurmus-tmp/guix] (631) $ guile
GNU Guile 2.0.9
Copyright (C) 1995-2013 Free Software Foundation, Inc.

Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
This program is free software, and you are welcome to redistribute it
under certain conditions; type `,show c' for details.

Enter `,help' for help.
scheme@(guile-user) ,module (web response)
scheme@(web response) make-delimited-input-port
$1 = #procedure make-delimited-input-port (port len keep-alive?)
scheme@(web response) 
~

The only difference from master is the applied patch.

~~ Ricardo



Re: cannot fetch narinfo with HTTP pipelining

2015-04-08 Thread Ludovic Courtès
Ricardo Wurmus ricardo.wur...@mdc-berlin.de skribis:

 ice-9/boot-9.scm:106:20: In procedure #procedure bde140 at 
 ice-9/boot-9.scm:97:6 (thrown-k . args):
 ice-9/boot-9.scm:106:20: No variable named make-delimited-input-port in 
 #interface (web response) f9bd80

Arf, that’s because I wrote ‘resolve-interface’ instead of
‘resolve-module’ (the former means “public interface”.)

New patch:

diff --git a/guix/http-client.scm b/guix/http-client.scm
index 051fcee..3bffbb1 100644
--- a/guix/http-client.scm
+++ b/guix/http-client.scm
@@ -135,6 +135,47 @@ closed it will also close PORT, unless the KEEP-ALIVE? is true.
  (when (module-variable %web-http 'read-chunk-body)
(module-set! %web-http 'make-chunked-input-port make-chunked-input-port))
 
+ (define (make-delimited-input-port port len keep-alive?)
+   Return an input port that reads from PORT, and makes sure that
+exactly LEN bytes are available from PORT.  Closing the returned port
+closes PORT, unless KEEP-ALIVE? is true.
+   (define bytes-read 0)
+
+   (define (fail)
+ ((@@ (web response) bad-response)
+  EOF while reading response body: ~a bytes of ~a
+  bytes-read len))
+
+   (define (read! bv start count)
+ ;; Read at most LEN bytes in total.  HTTP/1.1 doesn't say what to do
+ ;; when a server provides more than the Content-Length, but it seems
+ ;; wise to just stop reading at LEN.
+ (let ((count (min count (- len bytes-read
+   (let loop ((ret (get-bytevector-n! port bv start count)))
+ (cond ((eof-object? ret)
+(if (= bytes-read len)
+0  ; EOF
+(fail)))
+   ((and (zero? ret) ( count 0))
+;; Do not return zero since zero means EOF, so try again.
+(loop (get-bytevector-n! port bv start count)))
+   (else
+(set! bytes-read (+ bytes-read ret))
+ret)
+
+   (define close
+ (and (not keep-alive?)
+  (lambda ()
+(close port
+
+   (make-custom-binary-input-port delimited input port read! #f #f close))
+
+ (unless (guile-version? 2.0.9)
+   ;; Guile = 2.0.9 had a bug whereby 'response-body-port' would read more
+   ;; than what 'content-length' says.  See Guile commit 802a25b.
+   (module-set! (resolve-module '(web response))
+'make-delimited-input-port make-delimited-input-port))
+
  (define (read-response-body* r)
Reads the response body from @var{r}, as a bytevector.  Returns
  @code{#f} if there was no response body.

Ludo’.


Re: [PATCH 02/24] gnu: Add ghc-paths.

2015-04-08 Thread Federico Beffa
On Wed, Apr 8, 2015 at 10:01 AM, Ludovic Courtès l...@gnu.org wrote:
 +(synopsis
 + Knowledge of GHC's installation directories)
 +(description
 + Knowledge of GHC's installation directories.)

 Please expound a little bit.  Otherwise OK.

Thanks for reviewing all of these!

The problem with this and some other libraries is that the library
doesn't have an official home-page (apart from a source repository
which doesn't include anything other than the source). The description
is taken one-to-one from the Cabal file and I don't really know how I
can expand the description.

The Cabal file of some other libraries like, e.g., ghc-network, give
an, IMO, too detailed description (sometimes even with a code
snippet):

...
description:
  This package provides a low-level networking interface.
  .
  In network-2.6 the @Network.URI@ module was split off into its own
  package, network-uri-2.6. If you're using the @Network.URI@ module
  you can automatically get it from the right package by adding this
  to your .cabal file:
  .
   flag network-uri
 description: Get Network.URI from the network-uri package
 default: True
  
   library
 -- ...
 if flag(network-uri)
   build-depends: network-uri = 2.6, network = 2.6
 else
   build-depends: network-uri  2.6, network  2.6
  .
  That is, get the module from either network  2.6 or from
  network-uri = 2.6.
...

... and they also only have a source repository with no high level
information. For this reason I did cut the description to the,
sometimes very short, high level piece.

I hope it's fine to keep the concise description for these.

Regards,
Fede



Re: [PATCH] gnu: Add libsecret.

2015-04-08 Thread Ludovic Courtès
宋文武 iyzs...@gmail.com skribis:

 * gnu/packages/gnome.scm (libsecret): New variable.

[...]

 +(synopsis GObject bindings for Secret Service API)

“GObject bindings for the \Secret Service\ API”

(The quotes are important otherwise the reader might think you’re
referring to PRISM or something like that.)

Otherwise LGTM!

Ludo’.



Re: [PATCH] gnu: Add WebKitGTK+.

2015-04-08 Thread Ludovic Courtès
宋文武 iyzs...@gmail.com skribis:

 * gnu/packages/gnome.scm (webkitgtk): New variable.

LGTM!

On IRC Andy suggested moving it to a webkit module, which would host
other WebKit-related projects.  I don’t have an opinion, so I’ll let you
make the choice that seems best.

Thanks,
Ludo’.



Re: [PATCH 05/24] gnu: Add ghc-parallel.

2015-04-08 Thread Ludovic Courtès
Federico Beffa be...@ieee.org skribis:

 From 42f5bd8b6ea253e949c06cf791b06673b6379bed Mon Sep 17 00:00:00 2001
 From: Federico Beffa be...@fbengineering.ch
 Date: Fri, 27 Mar 2015 15:11:50 +0100
 Subject: [PATCH 05/24] gnu: Add ghc-parallel.

 * gnu/packages/haskell.scm (ghc-parallel): New variable.

[...]

 +(description
 + This package provides a library for parallel programming.)

Could you expound a bit?  Otherwise OK.

Ludo’.



Re: [PATCH 03/24] gnu: Add ghc-zlib.

2015-04-08 Thread Ludovic Courtès
Federico Beffa be...@ieee.org skribis:

 From 84a68b676fa4a90a97c67a0ef75bdaad45bcb131 Mon Sep 17 00:00:00 2001
 From: Federico Beffa be...@fbengineering.ch
 Date: Fri, 27 Mar 2015 14:31:40 +0100
 Subject: [PATCH 03/24] gnu: Add ghc-zlib.

 * gnu/packages/haskell.scm (ghc-zlib): New variable.

[...]

 +(description
 + This package provides a pure interface for compressing and 
 decompressing
 +streams of data represented as lazy 'ByteString's. It uses the zlib C library
^^^
Two spaces.

OK.

Ludo’.



Re: [PATCH 02/24] gnu: Add ghc-paths.

2015-04-08 Thread Ludovic Courtès
Federico Beffa be...@ieee.org skribis:

 From 3191ee610727c3d0bbf7849fd7bd5c5ec20b6fc4 Mon Sep 17 00:00:00 2001
 From: Federico Beffa be...@fbengineering.ch
 Date: Thu, 26 Mar 2015 17:55:23 +0100
 Subject: [PATCH 02/24] gnu: Add ghc-paths.

 * gnu/packages/haskell.scm: (ghc-paths): New variable.

[...]

 +(synopsis
 + Knowledge of GHC's installation directories)
 +(description
 + Knowledge of GHC's installation directories.)

Please expound a little bit.  Otherwise OK.

Ludo’.



Re: [PATCH 04/24] gnu: Add ghc-stm.

2015-04-08 Thread Ludovic Courtès
Federico Beffa be...@ieee.org skribis:

 From 558c75c9ab70b4d16e783c6c5d0567cef57b4fc4 Mon Sep 17 00:00:00 2001
 From: Federico Beffa be...@fbengineering.ch
 Date: Fri, 27 Mar 2015 14:49:39 +0100
 Subject: [PATCH 04/24] gnu: Add ghc-stm.

 * gnu/packages/haskell.scm (ghc-stm): New variable.

OK.

Ludo'.



Re: [PATCH 01/24] gnu: Add ghc-mtl.

2015-04-08 Thread Ludovic Courtès
Federico Beffa be...@ieee.org skribis:

 From b0380eb828ccdb226a7662ba819df0c0a007cab3 Mon Sep 17 00:00:00 2001
 From: Federico Beffa be...@fbengineering.ch
 Date: Wed, 25 Mar 2015 17:32:33 +0100
 Subject: [PATCH 01/24] gnu: Add ghc-mtl.

 * gnu/packages/haskell.scm: (ghc-mtl): New variable.

LGTM.

I think you can commit such patches in the future if you don’t get
feedback within 48h or so.

Ludo’.



Re: [PATCH 11/24] gnu: Add ghc-tf-random.

2015-04-08 Thread Ludovic Courtès
Federico Beffa be...@ieee.org skribis:

 From 83ec028ffe7985f9e092c6648a603c596350e826 Mon Sep 17 00:00:00 2001
 From: Federico Beffa be...@fbengineering.ch
 Date: Fri, 27 Mar 2015 17:29:42 +0100
 Subject: [PATCH 11/24] gnu: Add ghc-tf-random.

 * gnu/packages/haskell.scm (ghc-tf-random): New variable.

OK.

 +the paper /Splittable Pseudorandom Number Generators Using Cryptographic
 +Hashing/ by Claessen, Pałka for details and the rationale of the design.)

Use double quotes rather than slashes for the title.

Ludo’.



Re: [PATCH 17/24] gnu: Add ghc-unordered-containers.

2015-04-08 Thread Ludovic Courtès
Federico Beffa be...@ieee.org skribis:

 From 29f868b265d7a9c3abebe9b4489232cd5dcbe990 Mon Sep 17 00:00:00 2001
 From: Federico Beffa be...@fbengineering.ch
 Date: Fri, 27 Mar 2015 18:12:43 +0100
 Subject: [PATCH 17/24] gnu: Add ghc-unordered-containers.

 * gnu/packages/haskell.scm (ghc-unordered-containers): New variable.

OK.

Ludo'.



Re: [PATCH 09/24] gnu: Add ghc-random.

2015-04-08 Thread Ludovic Courtès
Federico Beffa be...@ieee.org skribis:

 From b8d42baf8077c7d17a762840d4852b2e315fe01d Mon Sep 17 00:00:00 2001
 From: Federico Beffa be...@fbengineering.ch
 Date: Fri, 27 Mar 2015 16:31:56 +0100
 Subject: [PATCH 09/24] gnu: Add ghc-random.

 * gnu/packages/haskell.scm (ghc-random): New variable.

OK.

Ludo'.



Re: [PATCH 08/24] gnu: Add ghc-hunit

2015-04-08 Thread Ludovic Courtès
Federico Beffa be...@ieee.org skribis:

 From 74c1d7a6e9827876238a6724b81cf449dd213bc3 Mon Sep 17 00:00:00 2001
 From: Federico Beffa be...@fbengineering.ch
 Date: Fri, 27 Mar 2015 16:08:00 +0100
 Subject: [PATCH 08/24] gnu: Add ghc-hunit

 * gnu/packages/haskell.scm (ghc-hunit): New variable.

OK.

 + HUnit is a unit testing framework for Haskell, inspired by the
 +JUnit tool for Java, see: http://www.junit.org.)

I think you can omit the URL here.

Thanks,
Ludo’.



Re: [PATCH 12/24] gnu: Add ghc-quickcheck.

2015-04-08 Thread Ludovic Courtès
Federico Beffa be...@ieee.org skribis:

 From f05d1c5718a99f52e23665198466b90228e90395 Mon Sep 17 00:00:00 2001
 From: Federico Beffa be...@fbengineering.ch
 Date: Fri, 27 Mar 2015 17:36:15 +0100
 Subject: [PATCH 12/24] gnu: Add ghc-quickcheck.

 * gnu/packages/haskell.scm (ghc-quickcheck): New variable.

OK for v2 of this patch.

Ludo’.



Re: [PATCH 23/24] gnu: Add ghc-http.

2015-04-08 Thread Ludovic Courtès
Federico Beffa be...@ieee.org skribis:

 From 486893324024240c6311422ca546579d1d3e399b Mon Sep 17 00:00:00 2001
 From: Federico Beffa be...@fbengineering.ch
 Date: Fri, 27 Mar 2015 19:17:57 +0100
 Subject: [PATCH 23/24] gnu: Add ghc-http.

 * gnu/packages/haskell.scm (ghc-http): New variable.

OK!

Thanks for all this!

Ludo'.



Re: [PATCH 06/24] gnu: Add ghc-text.

2015-04-08 Thread Ludovic Courtès
Federico Beffa be...@ieee.org skribis:

 From d823183b89f4e9341835483b443918618c08302a Mon Sep 17 00:00:00 2001
 From: Federico Beffa be...@fbengineering.ch
 Date: Fri, 27 Mar 2015 15:54:30 +0100
 Subject: [PATCH 06/24] gnu: Add ghc-text.

 * gnu/packages/haskell.scm (ghc-text): New variable.

OK.

Ludo’.



Re: [PATCH 22/24] gnu: Add ghc-network-uri.

2015-04-08 Thread Ludovic Courtès
Federico Beffa be...@ieee.org skribis:

 From 54fd4f04ab620139aee62a6e41d7e820ad78e68b Mon Sep 17 00:00:00 2001
 From: Federico Beffa be...@fbengineering.ch
 Date: Fri, 27 Mar 2015 19:15:21 +0100
 Subject: [PATCH 22/24] gnu: Add ghc-network-uri.

 * gnu/packages/haskell.scm (ghc-network-uri): New variable.

OK.



Re: [PATCH 21/24] gnu: Add ghc-network.

2015-04-08 Thread Ludovic Courtès
Federico Beffa be...@ieee.org skribis:

 From 366040508f9176f36a7eb7fe71cb28a4622dc37d Mon Sep 17 00:00:00 2001
 From: Federico Beffa be...@fbengineering.ch
 Date: Fri, 27 Mar 2015 18:58:03 +0100
 Subject: [PATCH 21/24] gnu: Add ghc-network.

 * gnu/packages/haskell.scm (ghc-network): New variable.

OK.



Re: [PATCH 16/24] gnu: Add ghc-fgl.

2015-04-08 Thread Ludovic Courtès
Federico Beffa be...@ieee.org skribis:

 From 5df2c9b1d5ae6e46bace457bc4841a836d0795d9 Mon Sep 17 00:00:00 2001
 From: Federico Beffa be...@fbengineering.ch
 Date: Fri, 27 Mar 2015 18:03:49 +0100
 Subject: [PATCH 16/24] gnu: Add ghc-fgl.

 * gnu/packages/haskell.scm (ghc-fgl): New variable.

[...]

 +(description An inductive representation of manipulating graph data
 +structures.)

Please expound a little bit.  Otherwise OK.

Ludo’.



Re: [PATCH 07/24] gnu: Add ghc-hashable.

2015-04-08 Thread Ludovic Courtès
Federico Beffa be...@ieee.org skribis:

 From 706f745a84c980ea562c013a55140210f979792a Mon Sep 17 00:00:00 2001
 From: Federico Beffa be...@fbengineering.ch
 Date: Fri, 27 Mar 2015 16:03:35 +0100
 Subject: [PATCH 07/24] gnu: Add ghc-hashable.

 * gnu/packages/haskell.scm (ghc-hashable): New variable.

OK.

Ludo'.



Re: [PATCH 3/9] gnu: Add geoclue.

2015-04-08 Thread Ludovic Courtès
Andy Wingo wi...@pobox.com skribis:

 * gnu/packages/gnome.scm (geoclue): New variable.
 * gnu/packages/patches/geoclue-config.patch: New file.

Applied to core-updates.  I added the patch to gnu-system.am, added
a comment to the top of the file, and changed GEOCLUE_CONFIG_FILE_PATH
to GEOCLUE_CONFIG_FILE.

Thanks!

Ludo’.



Re: cannot fetch narinfo with HTTP pipelining

2015-04-08 Thread Ricardo Wurmus

Ludovic Courtès writes:

 Ricardo Wurmus ricardo.wur...@mdc-berlin.de skribis:

 ice-9/boot-9.scm:106:20: In procedure #procedure bde140 at 
 ice-9/boot-9.scm:97:6 (thrown-k . args):
 ice-9/boot-9.scm:106:20: No variable named make-delimited-input-port in 
 #interface (web response) f9bd80

 Arf, that’s because I wrote ‘resolve-interface’ instead of
 ‘resolve-module’ (the former means “public interface”.)

 New patch:

Thank you!  With this patch applied everything works as expected.  Yay!

~~ Ricardo



Re: [PATCH 2/9] gnu: Add colord service.

2015-04-08 Thread Ludovic Courtès
Andy Wingo wi...@pobox.com skribis:

 * gnu-system.am (GNU_SYSTEM_MODULES): Add gnu/services/colord.scm.
 * gnu/services/colord.scm: New file.

Applied to core-updates with appropriate docstring and doc in
guix.texi.

Thanks,
Ludo’.



core-updates merge imminent

2015-04-08 Thread Ludovic Courtès
If there are no objections, we’ll let Hydra build all of ‘core-updates’
and merge it afterwards–i.e., within 2-3 days.

OK?

Ludo’.



Re: [PATCH 4/9] gnu: Add geoclue service.

2015-04-08 Thread Ludovic Courtès
Andy Wingo wi...@pobox.com skribis:

 * gnu/services/geoclue.scm: New file.
 * gnu-system.am (GNU_SYSTEM_MODULES): Add geoclue service.

LGTM, but...

 +(define* (geoclue-service #:key (geoclue geoclue)
 +  (whitelist '())
 +  (wifi-geolocation-url
 +   ;; Mozilla geolocation service:
 +   
 https://location.services.mozilla.com/v1/geolocate?key=geoclue;)
 +  (submit-data? #f)
 +  (wifi-submission-url
 +   
 https://location.services.mozilla.com/v1/submit?key=geoclue;)
 +  (submission-nick geoclue)
 +  (applications %standard-geoclue-applications))
 +  Return a service that runs the @command{geoclue}, location service.

... could you expound on the docstring, and then add it to guix.texi
like I did for colord?  Specifically, the docstring should mention all
the parameters and their meaning, possibly pointing to the upstream doc
for more details.

(I would do that, but since I’m geoclue-less [haha!] I’d rather let you
handle it.)

Thanks!

Ludo’.



GuixSD tee-shirts and hoodies available

2015-04-08 Thread Luis Felipe López Acevedo

Hi,

I just created a GuixSD tee-shirt and hoodie in teespring: 
http://teespring.com/guixsd-for-the-libre-geek .


For those who can afford it, I hope you enjoy it :)


--
Luis Felipe López Acevedo
http://sirgazil.bitbucket.org/



Re: cannot fetch narinfo with HTTP pipelining

2015-04-08 Thread Ludovic Courtès
Ricardo Wurmus ricardo.wur...@mdc-berlin.de skribis:

 Ludovic Courtès writes:

 Ricardo Wurmus ricardo.wur...@mdc-berlin.de skribis:

 ice-9/boot-9.scm:106:20: In procedure #procedure bde140 at 
 ice-9/boot-9.scm:97:6 (thrown-k . args):
 ice-9/boot-9.scm:106:20: No variable named make-delimited-input-port in 
 #interface (web response) f9bd80

 Arf, that’s because I wrote ‘resolve-interface’ instead of
 ‘resolve-module’ (the former means “public interface”.)

 New patch:

 Thank you!  With this patch applied everything works as expected.  Yay!

Great, pushed!

Ludo’.