Re: "guix pull" expiry channels
Hi, On Fri, 11 Jun 2021 at 23:32, Ludovic Courtès wrote: > The code in (guix git) determines expiration based on the mtime of > sub-directories in ~/.cache/guix/checkouts. But that’s bogus, no? > > Yes, and the Internet confirms: a directory’s mtime is only changed when > a file inside it is renamed, added, or deleted.) Oops! So it would > depend on how frequently you pull, and perhaps on the file system you > use, go figure. Hehe! :-) > diff --git a/guix/git.scm b/guix/git.scm > index 57fa2ca1ee..9c6f326c36 100644 > --- a/guix/git.scm > +++ b/guix/git.scm > @@ -424,6 +424,14 @@ it unchanged." > ;; REPOSITORY as soon as possible. > (repository-close! repository) > > + ;; Update CACHE-DIRECTORY's mtime to so the cache logic sees it. > + (match (gettimeofday) > + ((seconds . microseconds) > + (let ((nanoseconds (* 1000 microseconds))) > +(utime cache-directory > + seconds seconds > + nanoseconds nanoseconds > + > ;; When CACHE-DIRECTORY is a sub-directory of the default cache > ;; directory, remove expired checkouts that are next to it. > (let ((parent (dirname cache-directory))) LGTM. Thanks for the quick fix. :-) Cheers, simon
Re: "guix pull" expiry channels
Hi, zimoun skribis: > I do not know if it is not a bug. From f8acd1a (pulled April, 21rst), I get: > > Updating channel 'guix' from Git repository at > 'https://git.savannah.gnu.org/git/guix.git'... > guix pull: error: Git error: failed to resolve path > '/home/simon/.cache/guix/checkouts/pjmkglp4t7znuugeurpurzikxq3tnlaywmisyr27shj7apsnalwq': > No such file or directory > > > Indeed, after the error, I have this: > > $ ls ~/.cache/guix/checkouts/ > f5uvstgmyyeyhl66lla3yxbp26x25xwt7rbwah3kahh724xwzisa last-expiry-cleanup > > Then if I run again "guix pull", it works as expected. > > It is hard to reproduce. ;-) I suspect a bug in > 'maybe-remove-expired-cache-entries' or 'update-cache-checkout'. Sounds plausible! The code in (guix git) determines expiration based on the mtime of sub-directories in ~/.cache/guix/checkouts. But that’s bogus, no? Yes, and the Internet confirms: a directory’s mtime is only changed when a file inside it is renamed, added, or deleted.) Oops! So it would depend on how frequently you pull, and perhaps on the file system you use, go figure. The patch below should fix it. Will push shortly, thank you! Ludo’. diff --git a/guix/git.scm b/guix/git.scm index 57fa2ca1ee..9c6f326c36 100644 --- a/guix/git.scm +++ b/guix/git.scm @@ -424,6 +424,14 @@ it unchanged." ;; REPOSITORY as soon as possible. (repository-close! repository) + ;; Update CACHE-DIRECTORY's mtime to so the cache logic sees it. + (match (gettimeofday) + ((seconds . microseconds) + (let ((nanoseconds (* 1000 microseconds))) +(utime cache-directory + seconds seconds + nanoseconds nanoseconds + ;; When CACHE-DIRECTORY is a sub-directory of the default cache ;; directory, remove expired checkouts that are next to it. (let ((parent (dirname cache-directory)))
Re: "guix pull" expiry channels
Hi! Pierre Neidhardt skribis: > Same here, I've experienced this bug multiple times for a few months > already. Just so you know, bugs can be reported at bug-g...@gnu.org. :-) I’m being provocative, but really it’s important to report such issues so we can all be aware of them and start hunting them. Ludo’.
Re: "guix pull" expiry channels
Hi Pierre, On Wed, 09 Jun 2021 at 21:26, Pierre Neidhardt wrote: > Same here, I've experienced this bug multiple times for a few months > already. Thanks for confirming. What is your frequency for pulling? More or less? Cheers, simon
Re: "guix pull" expiry channels
Once every second week maybe? Depends, if I need an urgent upgrade then it might be more. -- Pierre Neidhardt https://ambrevar.xyz/ signature.asc Description: PGP signature
"guix pull" expiry channels
Hi, I do not know if it is not a bug. From f8acd1a (pulled April, 21rst), I get: --8<---cut here---start->8--- Updating channel 'guix' from Git repository at 'https://git.savannah.gnu.org/git/guix.git'... guix pull: error: Git error: failed to resolve path '/home/simon/.cache/guix/checkouts/pjmkglp4t7znuugeurpurzikxq3tnlaywmisyr27shj7apsnalwq': No such file or directory --8<---cut here---end--->8--- Indeed, after the error, I have this: --8<---cut here---start->8--- $ ls ~/.cache/guix/checkouts/ f5uvstgmyyeyhl66lla3yxbp26x25xwt7rbwah3kahh724xwzisa last-expiry-cleanup --8<---cut here---end--->8--- Then if I run again "guix pull", it works as expected. It is hard to reproduce. ;-) I suspect a bug in 'maybe-remove-expired-cache-entries' or 'update-cache-checkout'. All the best, simon
